Skip to content

Commit f2241a1

Browse files
authored
watcher tests - increase stop timeout to 60s (#45679) (#45934)
As of #43939 Watcher tests now correctly block until all Watch executions kicked off by that test are finished. Prior we allowed tests to finish with outstanding watch executions. It was known that this would increase the time needed to finish a test. However, running the tests on CI can be slow and on at least 1 occasion it took 60s to actually finish. This PR simply increases the max allowable timeout for Watcher tests to clean up after themselves.
1 parent a3d918b commit f2241a1

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

x-pack/plugin/watcher/src/test/java/org/elasticsearch/xpack/watcher/test/AbstractWatcherIntegrationTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ protected void stopWatcher() throws Exception {
570570
}
571571

572572
throw new AssertionError("unexpected state, retrying with next run");
573-
}, 30, TimeUnit.SECONDS);
573+
}, 60, TimeUnit.SECONDS);
574574
}
575575

576576
public static class NoopEmailService extends EmailService {

x-pack/qa/smoke-test-watcher-with-security/src/test/java/org/elasticsearch/smoketest/SmokeTestWatcherWithSecurityClientYamlTestSuiteIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void stopWatcher() throws Exception {
109109
default:
110110
throw new AssertionError("unknown state[" + state + "]");
111111
}
112-
}, 30, TimeUnit.SECONDS);
112+
}, 60, TimeUnit.SECONDS);
113113
}
114114

115115
@Override

x-pack/qa/smoke-test-watcher-with-security/src/test/java/org/elasticsearch/smoketest/SmokeTestWatcherWithSecurityIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public void stopWatcher() throws Exception {
118118
} catch (IOException e) {
119119
throw new AssertionError(e);
120120
}
121-
}, 30, TimeUnit.SECONDS);
121+
}, 60, TimeUnit.SECONDS);
122122

123123
adminClient().performRequest(new Request("DELETE", "/my_test_index"));
124124
}

x-pack/qa/smoke-test-watcher/src/test/java/org/elasticsearch/smoketest/SmokeTestWatcherTestSuiteIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void stopWatcher() throws Exception {
9393
default:
9494
throw new AssertionError("unknown state[" + state + "]");
9595
}
96-
}, 30, TimeUnit.SECONDS);
96+
}, 60, TimeUnit.SECONDS);
9797
}
9898

9999
@Override

x-pack/qa/smoke-test-watcher/src/test/java/org/elasticsearch/smoketest/WatcherRestIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,6 @@ public void stopWatcher() throws Exception {
9292
default:
9393
throw new AssertionError("unknown state[" + state + "]");
9494
}
95-
}, 30, TimeUnit.SECONDS);
95+
}, 60, TimeUnit.SECONDS);
9696
}
9797
}

x-pack/qa/third-party/jira/src/test/java/org/elasticsearch/smoketest/WatcherJiraYamlTestSuiteIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ public void stopWatcher() throws Exception {
7171
} catch (IOException e) {
7272
throw new AssertionError(e);
7373
}
74-
}, 30, TimeUnit.SECONDS);
74+
}, 60, TimeUnit.SECONDS);
7575
}
7676
}

x-pack/qa/third-party/pagerduty/src/test/java/org/elasticsearch/smoketest/WatcherPagerDutyYamlTestSuiteIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ public void stopWatcher() throws Exception {
7171
} catch (IOException e) {
7272
throw new AssertionError(e);
7373
}
74-
}, 30, TimeUnit.SECONDS);
74+
}, 60, TimeUnit.SECONDS);
7575
}
7676
}

x-pack/qa/third-party/slack/src/test/java/org/elasticsearch/smoketest/WatcherSlackYamlTestSuiteIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ public void stopWatcher() throws Exception {
7171
} catch (IOException e) {
7272
throw new AssertionError(e);
7373
}
74-
}, 30, TimeUnit.SECONDS);
74+
}, 60, TimeUnit.SECONDS);
7575
}
7676
}

0 commit comments

Comments
 (0)