[TEST] Enhance failure message when bulk updates have failures

dakrone · dakrone · commit e66bc0dd8505 · 2018-08-03T15:26:20.000-06:00
diff --git a/server/src/test/java/org/elasticsearch/action/bulk/BulkWithUpdatesIT.java b/server/src/test/java/org/elasticsearch/action/bulk/BulkWithUpdatesIT.java
@@ -404,7 +404,7 @@ public void testBulkUpdateLargerVolume() throws Exception {
                     .setScript(new Script(ScriptType.INLINE, CustomScriptPlugin.NAME, "ctx.op = \"delete\"", Collections.emptyMap())));
         }
         response = builder.execute().actionGet();
-        assertThat(response.hasFailures(), equalTo(false));
+        assertThat("expected no failures but got: " + response.buildFailureMessage(), response.hasFailures(), equalTo(false));
         assertThat(response.getItems().length, equalTo(numDocs));
         for (int i = 0; i < numDocs; i++) {
             assertThat(response.getItems()[i].getItemId(), equalTo(i));

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ public void testBulkUpdateLargerVolume() throws Exception {`
`404`	`404`	`.setScript(new Script(ScriptType.INLINE, CustomScriptPlugin.NAME, "ctx.op = \"delete\"", Collections.emptyMap())));`
`405`	`405`	`}`
`406`	`406`	`response = builder.execute().actionGet();`
`407`		`- assertThat(response.hasFailures(), equalTo(false));`
	`407`	`+ assertThat("expected no failures but got: " + response.buildFailureMessage(), response.hasFailures(), equalTo(false));`
`408`	`408`	`assertThat(response.getItems().length, equalTo(numDocs));`
`409`	`409`	`for (int i = 0; i < numDocs; i++) {`
`410`	`410`	`assertThat(response.getItems()[i].getItemId(), equalTo(i));`