Skip to content

Commit db12005

Browse files
original-brownbearoriginal-brownbear
authored
Fix LineLength Check Suppressions: index.fielddata (#34891)
* Fix linelength suppressions in index.fielddata * Some lines that were too long were dead code => Removed them and all code that became dead because of it * Relates #34884
1 parent 65edec0 commit db12005

23 files changed

+78
-276
lines changed

‎buildSrc/src/main/resources/checkstyle_suppressions.xml‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -261,19 +261,6 @@
261261
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]engine[/\\]Engine.java" checks="LineLength" />
262262
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]engine[/\\]InternalEngine.java" checks="LineLength" />
263263
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]engine[/\\]LiveVersionMap.java" checks="LineLength" />
264-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]IndexFieldDataCache.java" checks="LineLength" />
265-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]IndexFieldDataService.java" checks="LineLength" />
266-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]fieldcomparator[/\\]DoubleValuesComparatorSource.java" checks="LineLength" />
267-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]fieldcomparator[/\\]FloatValuesComparatorSource.java" checks="LineLength" />
268-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]fieldcomparator[/\\]LongValuesComparatorSource.java" checks="LineLength" />
269-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]ordinals[/\\]GlobalOrdinalsBuilder.java" checks="LineLength" />
270-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]ordinals[/\\]MultiOrdinals.java" checks="LineLength" />
271-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]ordinals[/\\]OrdinalsBuilder.java" checks="LineLength" />
272-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]ordinals[/\\]SinglePackedOrdinals.java" checks="LineLength" />
273-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]plain[/\\]AbstractIndexOrdinalsFieldData.java" checks="LineLength" />
274-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]plain[/\\]AbstractLatLonPointDVIndexFieldData.java" checks="LineLength" />
275-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]plain[/\\]BinaryDVIndexFieldData.java" checks="LineLength" />
276-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]plain[/\\]PagedBytesIndexFieldData.java" checks="LineLength" />
277264
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]get[/\\]ShardGetService.java" checks="LineLength" />
278265
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]mapper[/\\]CompletionFieldMapper.java" checks="LineLength" />
279266
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]mapper[/\\]DocumentFieldMappers.java" checks="LineLength" />
@@ -318,8 +305,6 @@
318305
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]IndicesService.java" checks="LineLength" />
319306
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]analysis[/\\]PreBuiltCacheFactory.java" checks="LineLength" />
320307
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]breaker[/\\]HierarchyCircuitBreakerService.java" checks="LineLength" />
321-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]fielddata[/\\]cache[/\\]IndicesFieldDataCache.java" checks="LineLength" />
322-
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]fielddata[/\\]cache[/\\]IndicesFieldDataCacheListener.java" checks="LineLength" />
323308
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]flush[/\\]ShardsSyncedFlushResult.java" checks="LineLength" />
324309
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]flush[/\\]SyncedFlushService.java" checks="LineLength" />
325310
<suppress files="server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]elasticsearch[/\\]indices[/\\]recovery[/\\]PeerRecoverySourceService.java" checks="LineLength" />
@@ -513,10 +498,6 @@
513498
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]analysis[/\\]PreBuiltAnalyzerTests.java" checks="LineLength" />
514499
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]engine[/\\]InternalEngineMergeIT.java" checks="LineLength" />
515500
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]engine[/\\]InternalEngineTests.java" checks="LineLength" />
516-
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]AbstractFieldDataTestCase.java" checks="LineLength" />
517-
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]AbstractStringFieldDataTestCase.java" checks="LineLength" />
518-
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]FieldDataCacheTests.java" checks="LineLength" />
519-
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]fielddata[/\\]IndexFieldDataServiceTests.java" checks="LineLength" />
520501
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]mapper[/\\]CompletionFieldMapperTests.java" checks="LineLength" />
521502
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]mapper[/\\]CompletionFieldTypeTests.java" checks="LineLength" />
522503
<suppress files="server[/\\]src[/\\]test[/\\]java[/\\]org[/\\]elasticsearch[/\\]index[/\\]mapper[/\\]CopyToMapperTests.java" checks="LineLength" />

‎server/src/main/java/org/elasticsearch/index/fielddata/IndexFieldData.java‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,23 +54,6 @@
5454
*/
5555
public interface IndexFieldData<FD extends AtomicFieldData> extends IndexComponent {
5656

57-
class CommonSettings {
58-
public static final String SETTING_MEMORY_STORAGE_HINT = "memory_storage_hint";
59-
60-
public enum MemoryStorageFormat {
61-
ORDINALS, PACKED, PAGED;
62-
63-
public static MemoryStorageFormat fromString(String string) {
64-
for (MemoryStorageFormat e : MemoryStorageFormat.values()) {
65-
if (e.name().equalsIgnoreCase(string)) {
66-
return e;
67-
}
68-
}
69-
return null;
70-
}
71-
}
72-
}
73-
7457
/**
7558
* The field name.
7659
*/

‎server/src/main/java/org/elasticsearch/index/fielddata/IndexFieldDataCache.java‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ public interface IndexFieldDataCache {
3131

3232
<FD extends AtomicFieldData, IFD extends IndexFieldData<FD>> FD load(LeafReaderContext context, IFD indexFieldData) throws Exception;
3333

34-
<FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader, IFD indexFieldData) throws Exception;
34+
<FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader, IFD indexFieldData)
35+
throws Exception;
3536

3637
/**
3738
* Clears all the field data stored cached in on this index.
@@ -59,13 +60,15 @@ default void onRemoval(ShardId shardId, String fieldName, boolean wasEvicted, lo
5960
class None implements IndexFieldDataCache {
6061

6162
@Override
62-
public <FD extends AtomicFieldData, IFD extends IndexFieldData<FD>> FD load(LeafReaderContext context, IFD indexFieldData) throws Exception {
63+
public <FD extends AtomicFieldData, IFD extends IndexFieldData<FD>> FD load(LeafReaderContext context, IFD indexFieldData)
64+
throws Exception {
6365
return indexFieldData.loadDirect(context);
6466
}
6567

6668
@Override
6769
@SuppressWarnings("unchecked")
68-
public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader, IFD indexFieldData) throws Exception {
70+
public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader,
71+
IFD indexFieldData) throws Exception {
6972
return (IFD) indexFieldData.localGlobalDirect(indexReader);
7073
}
7174

‎server/src/main/java/org/elasticsearch/index/fielddata/IndexFieldDataService.java‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,16 @@
4242
public class IndexFieldDataService extends AbstractIndexComponent implements Closeable {
4343
public static final String FIELDDATA_CACHE_VALUE_NODE = "node";
4444
public static final String FIELDDATA_CACHE_KEY = "index.fielddata.cache";
45-
public static final Setting<String> INDEX_FIELDDATA_CACHE_KEY = new Setting<>(FIELDDATA_CACHE_KEY, (s) -> FIELDDATA_CACHE_VALUE_NODE, (s) -> {
46-
switch (s) {
47-
case "node":
48-
case "none":
49-
return s;
50-
default:
51-
throw new IllegalArgumentException("failed to parse [" + s + "] must be one of [node,none]");
52-
}
53-
}, Property.IndexScope);
45+
public static final Setting<String> INDEX_FIELDDATA_CACHE_KEY =
46+
new Setting<>(FIELDDATA_CACHE_KEY, (s) -> FIELDDATA_CACHE_VALUE_NODE, (s) -> {
47+
switch (s) {
48+
case "node":
49+
case "none":
50+
return s;
51+
default:
52+
throw new IllegalArgumentException("failed to parse [" + s + "] must be one of [node,none]");
53+
}
54+
}, Property.IndexScope);
5455

5556
private final CircuitBreakerService circuitBreakerService;
5657

‎server/src/main/java/org/elasticsearch/index/fielddata/fieldcomparator/DoubleValuesComparatorSource.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ public class DoubleValuesComparatorSource extends IndexFieldData.XFieldComparato
4343

4444
private final IndexNumericFieldData indexFieldData;
4545

46-
public DoubleValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) {
46+
public DoubleValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode,
47+
Nested nested) {
4748
super(missingValue, sortMode, nested);
4849
this.indexFieldData = indexFieldData;
4950
}

‎server/src/main/java/org/elasticsearch/index/fielddata/fieldcomparator/FloatValuesComparatorSource.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public class FloatValuesComparatorSource extends IndexFieldData.XFieldComparator
4141

4242
private final IndexNumericFieldData indexFieldData;
4343

44-
public FloatValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) {
44+
public FloatValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode,
45+
Nested nested) {
4546
super(missingValue, sortMode, nested);
4647
this.indexFieldData = indexFieldData;
4748
}

‎server/src/main/java/org/elasticsearch/index/fielddata/fieldcomparator/LongValuesComparatorSource.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ public class LongValuesComparatorSource extends IndexFieldData.XFieldComparatorS
4040

4141
private final IndexNumericFieldData indexFieldData;
4242

43-
public LongValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) {
43+
public LongValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode,
44+
Nested nested) {
4445
super(missingValue, sortMode, nested);
4546
this.indexFieldData = indexFieldData;
4647
}

‎server/src/main/java/org/elasticsearch/index/fielddata/ordinals/GlobalOrdinalsBuilder.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public static IndexOrdinalsFieldData build(final IndexReader indexReader, IndexO
7979
);
8080
}
8181

82-
public static IndexOrdinalsFieldData buildEmpty(IndexSettings indexSettings, final IndexReader indexReader, IndexOrdinalsFieldData indexFieldData) throws IOException {
82+
public static IndexOrdinalsFieldData buildEmpty(IndexSettings indexSettings, final IndexReader indexReader,
83+
IndexOrdinalsFieldData indexFieldData) throws IOException {
8384
assert indexReader.leaves().size() > 1;
8485

8586
final AtomicOrdinalsFieldData[] atomicFD = new AtomicOrdinalsFieldData[indexReader.leaves().size()];

‎server/src/main/java/org/elasticsearch/index/fielddata/ordinals/MultiOrdinals.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public class MultiOrdinals extends Ordinals {
4646
/**
4747
* Return true if this impl is going to be smaller than {@link SinglePackedOrdinals} by at least 20%.
4848
*/
49-
public static boolean significantlySmallerThanSinglePackedOrdinals(int maxDoc, int numDocsWithValue, long numOrds, float acceptableOverheadRatio) {
49+
public static boolean significantlySmallerThanSinglePackedOrdinals(int maxDoc, int numDocsWithValue, long numOrds,
50+
float acceptableOverheadRatio) {
5051
int bitsPerOrd = PackedInts.bitsRequired(numOrds);
5152
bitsPerOrd = PackedInts.fastestFormatAndBits(numDocsWithValue, bitsPerOrd, acceptableOverheadRatio).bitsPerValue;
5253
// Compute the worst-case number of bits per value for offsets in the worst case, eg. if no docs have a value at the

‎server/src/main/java/org/elasticsearch/index/fielddata/ordinals/OrdinalsBuilder.java‎

Lines changed: 11 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,7 @@
1919

2020
package org.elasticsearch.index.fielddata.ordinals;
2121

22-
import org.apache.lucene.index.PostingsEnum;
23-
import org.apache.lucene.index.TermsEnum;
24-
import org.apache.lucene.search.DocIdSetIterator;
2522
import org.apache.lucene.util.ArrayUtil;
26-
import org.apache.lucene.util.BitSet;
27-
import org.apache.lucene.util.BytesRef;
28-
import org.apache.lucene.util.BytesRefIterator;
29-
import org.apache.lucene.util.FixedBitSet;
3023
import org.apache.lucene.util.LongsRef;
3124
import org.apache.lucene.util.packed.GrowableWriter;
3225
import org.apache.lucene.util.packed.PackedInts;
@@ -43,11 +36,6 @@
4336
*/
4437
public final class OrdinalsBuilder implements Closeable {
4538

46-
/**
47-
* Whether to for the use of {@link MultiOrdinals} to store the ordinals for testing purposes.
48-
*/
49-
public static final String FORCE_MULTI_ORDINALS = "force_multi_ordinals";
50-
5139
/**
5240
* Default acceptable overhead ratio. {@link OrdinalsBuilder} memory usage is mostly transient so it is likely a better trade-off to
5341
* trade memory for speed in order to resize less often.
@@ -159,7 +147,8 @@ private static int numOrdinals(int level, long offset) {
159147
this.acceptableOverheadRatio = acceptableOverheadRatio;
160148
positions = new PagedGrowableWriter(maxDoc, PAGE_SIZE, startBitsPerValue, acceptableOverheadRatio);
161149
firstOrdinals = new GrowableWriter(startBitsPerValue, maxDoc, acceptableOverheadRatio);
162-
// over allocate in order to never worry about the array sizes, 24 entries would allow to store several millions of ordinals per doc...
150+
// over allocate in order to never worry about the array sizes, 24 entries would allow
151+
// to store several millions of ordinals per doc...
163152
ordinals = new PagedGrowableWriter[24];
164153
nextLevelSlices = new PagedGrowableWriter[24];
165154
sizes = new int[24];
@@ -200,7 +189,8 @@ private int firstLevel(int docID, long ordinal) {
200189
} else {
201190
final long newSlice = newSlice(1);
202191
if (firstNextLevelSlices == null) {
203-
firstNextLevelSlices = new PagedGrowableWriter(firstOrdinals.size(), PAGE_SIZE, 3, acceptableOverheadRatio);
192+
firstNextLevelSlices =
193+
new PagedGrowableWriter(firstOrdinals.size(), PAGE_SIZE, 3, acceptableOverheadRatio);
204194
}
205195
firstNextLevelSlices.set(docID, newSlice);
206196
final long offset = startOffset(1, newSlice);
@@ -282,14 +272,14 @@ public void appendOrdinals(int docID, LongsRef ords) {
282272
private OrdinalsStore ordinals;
283273
private final LongsRef spare;
284274

285-
public OrdinalsBuilder(int maxDoc, float acceptableOverheadRatio) throws IOException {
275+
public OrdinalsBuilder(int maxDoc, float acceptableOverheadRatio) {
286276
this.maxDoc = maxDoc;
287277
int startBitsPerValue = 8;
288278
ordinals = new OrdinalsStore(maxDoc, startBitsPerValue, acceptableOverheadRatio);
289279
spare = new LongsRef();
290280
}
291281

292-
public OrdinalsBuilder(int maxDoc) throws IOException {
282+
public OrdinalsBuilder(int maxDoc) {
293283
this(maxDoc, DEFAULT_ACCEPTABLE_OVERHEAD_RATIO);
294284
}
295285

@@ -303,7 +293,7 @@ public LongsRef docOrds(int docID) {
303293
}
304294

305295
/**
306-
* Return a {@link org.apache.lucene.util.packed.PackedInts.Reader} instance mapping every doc ID to its first ordinal + 1 if it exists and 0 otherwise.
296+
* Return a {@link PackedInts.Reader} instance mapping every doc ID to its first ordinal + 1 if it exists and 0 otherwise.
307297
*/
308298
public PackedInts.Reader getFirstOrdinals() {
309299
return ordinals.firstOrdinals;
@@ -339,27 +329,6 @@ public OrdinalsBuilder addDoc(int doc) {
339329
return this;
340330
}
341331

342-
/**
343-
* Returns <code>true</code> iff this builder contains a document ID that is associated with more than one ordinal. Otherwise <code>false</code>;
344-
*/
345-
public boolean isMultiValued() {
346-
return numMultiValuedDocs > 0;
347-
}
348-
349-
/**
350-
* Returns the number distinct of document IDs with one or more values.
351-
*/
352-
public int getNumDocsWithValue() {
353-
return numDocsWithValue;
354-
}
355-
356-
/**
357-
* Returns the number distinct of document IDs associated with exactly one value.
358-
*/
359-
public int getNumSingleValuedDocs() {
360-
return numDocsWithValue - numMultiValuedDocs;
361-
}
362-
363332
/**
364333
* Returns the number distinct of document IDs associated with two or more values.
365334
*/
@@ -381,29 +350,15 @@ public long getValueCount() {
381350
return currentOrd + 1;
382351
}
383352

384-
/**
385-
* Builds a {@link BitSet} where each documents bit is that that has one or more ordinals associated with it.
386-
* if every document has an ordinal associated with it this method returns <code>null</code>
387-
*/
388-
public BitSet buildDocsWithValuesSet() {
389-
if (numDocsWithValue == maxDoc) {
390-
return null;
391-
}
392-
final FixedBitSet bitSet = new FixedBitSet(maxDoc);
393-
for (int docID = 0; docID < maxDoc; ++docID) {
394-
if (ordinals.firstOrdinals.get(docID) != 0) {
395-
bitSet.set(docID);
396-
}
397-
}
398-
return bitSet;
399-
}
400-
401353
/**
402354
* Builds an {@link Ordinals} instance from the builders current state.
403355
*/
404356
public Ordinals build() {
405357
final float acceptableOverheadRatio = PackedInts.DEFAULT;
406-
if (numMultiValuedDocs > 0 || MultiOrdinals.significantlySmallerThanSinglePackedOrdinals(maxDoc, numDocsWithValue, getValueCount(), acceptableOverheadRatio)) {
358+
if (numMultiValuedDocs > 0
359+
|| MultiOrdinals.significantlySmallerThanSinglePackedOrdinals(
360+
maxDoc, numDocsWithValue, getValueCount(), acceptableOverheadRatio)
361+
) {
407362
// MultiOrdinals can be smaller than SinglePackedOrdinals for sparse fields
408363
return new MultiOrdinals(this, acceptableOverheadRatio);
409364
} else {
@@ -419,33 +374,6 @@ public int maxDoc() {
419374
return maxDoc;
420375
}
421376

422-
/**
423-
* This method iterates all terms in the given {@link TermsEnum} and
424-
* associates each terms ordinal with the terms documents. The caller must
425-
* exhaust the returned {@link BytesRefIterator} which returns all values
426-
* where the first returned value is associated with the ordinal {@code 1}
427-
* etc.
428-
*/
429-
public BytesRefIterator buildFromTerms(final TermsEnum termsEnum) throws IOException {
430-
return new BytesRefIterator() {
431-
private PostingsEnum docsEnum = null;
432-
433-
@Override
434-
public BytesRef next() throws IOException {
435-
BytesRef ref;
436-
if ((ref = termsEnum.next()) != null) {
437-
docsEnum = termsEnum.postings(docsEnum, PostingsEnum.NONE);
438-
nextOrdinal();
439-
int docId;
440-
while ((docId = docsEnum.nextDoc()) != DocIdSetIterator.NO_MORE_DOCS) {
441-
addDoc(docId);
442-
}
443-
}
444-
return ref;
445-
}
446-
};
447-
}
448-
449377
/**
450378
* Closes this builder and release all resources.
451379
*/

0 commit comments

Comments
 (0)