Skip to content

Commit d1fa9fa

Browse files
committed
Fix and reenable TribeIntegrationTests
Closes #31865
1 parent 1f82cc6 commit d1fa9fa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/tribe/src/test/java/org/elasticsearch/tribe/TribeIntegrationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
package org.elasticsearch.tribe;
2121

22-
import org.apache.lucene.util.LuceneTestCase;
2322
import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
2423
import org.elasticsearch.action.support.DestructiveOperations;
2524
import org.elasticsearch.client.Client;
@@ -87,7 +86,6 @@
8786
* Note, when talking to tribe client, no need to set the local flag on master read operations, it
8887
* does it by default.
8988
*/
90-
@LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/31865")
9189
@ESIntegTestCase.ClusterScope(scope = ESIntegTestCase.Scope.SUITE, numDataNodes = 0, numClientNodes = 0, transportClientRatio = 0.0)
9290
public class TribeIntegrationTests extends ESIntegTestCase {
9391

test/framework/src/main/java/org/elasticsearch/test/InternalTestCluster.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1059,7 +1059,9 @@ public synchronized void validateClusterFormed(String viaNode) {
10591059
try {
10601060
if (awaitBusy(() -> {
10611061
DiscoveryNodes discoveryNodes = client.admin().cluster().prepareState().get().getState().nodes();
1062-
if (discoveryNodes.getSize() != expectedNodes.size()) {
1062+
boolean isTribeNode = nodes.values().size() == 1
1063+
&& nodes.values().iterator().next().node().settings().keySet().stream().anyMatch(s -> s.startsWith("tribe."));
1064+
if (discoveryNodes.getSize() != expectedNodes.size() && isTribeNode == false) {
10631065
return false;
10641066
}
10651067
for (DiscoveryNode expectedNode : expectedNodes) {

0 commit comments

Comments
 (0)