Skip to content

Commit cfea2fd

Browse files
authored
RecoveryMonitor#lastSeenAccessTime should be volatile (#36781)
This local field is accessed on multiple threads and is nonvolatile so theoretically could yield stale values. Not sure it does in practice.
1 parent 4ded471 commit cfea2fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

server/src/main/java/org/elasticsearch/indices/recovery/RecoveriesCollection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ private class RecoveryMonitor extends AbstractRunnable {
258258
private final long recoveryId;
259259
private final TimeValue checkInterval;
260260

261-
private long lastSeenAccessTime;
261+
private volatile long lastSeenAccessTime;
262262

263263
private RecoveryMonitor(long recoveryId, long lastSeenAccessTime, TimeValue checkInterval) {
264264
this.recoveryId = recoveryId;

0 commit comments

Comments
 (0)