Skip to content

Commit c91dfe6

Browse files
committed
Remove "reinstall" packaging tests (#37851)
The packaging tests currently have a test which installs elasticsearch, removes it, modifies ownership of /etc/elasticsearch, and reinstalls. It then checks that the /etc/elasticsearch directory has ownership that the package expects. But the recursive change touches files not owned by the package. In the past this worked because we did a recursive ownership change within the package postinst. However, that was recently removed, and thus this test no longer makes sense.
1 parent 1964f53 commit c91dfe6

File tree

2 files changed

+0
-89
lines changed

2 files changed

+0
-89
lines changed

qa/vagrant/src/test/resources/packaging/tests/90_reinstall.bats

Lines changed: 0 additions & 78 deletions
This file was deleted.

qa/vagrant/src/test/resources/packaging/utils/utils.bash

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -228,17 +228,6 @@ assert_output() {
228228
echo "$output" | grep -E "$1"
229229
}
230230

231-
assert_recursive_ownership() {
232-
local directory=$1
233-
local user=$2
234-
local group=$3
235-
236-
realuser=$(find $directory -printf "%u\n" | sort | uniq)
237-
[ "$realuser" = "$user" ]
238-
realgroup=$(find $directory -printf "%g\n" | sort | uniq)
239-
[ "$realgroup" = "$group" ]
240-
}
241-
242231
# Deletes everything before running a test file
243232
clean_before_test() {
244233

0 commit comments

Comments
 (0)