[ML] Prevent notifications on deletion of a non existent job (#35337)

Author: davidkyle

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportDeleteJobAction.java

@@ -65,6 +65,7 @@
 import org.elasticsearch.xpack.core.ml.job.process.autodetect.state.CategorizerState;
 import org.elasticsearch.xpack.core.ml.job.process.autodetect.state.ModelSnapshot;
 import org.elasticsearch.xpack.core.ml.job.process.autodetect.state.Quantiles;
+import org.elasticsearch.xpack.ml.job.JobManager;
 import org.elasticsearch.xpack.ml.job.persistence.JobDataDeleter;
 import org.elasticsearch.xpack.ml.job.persistence.JobResultsProvider;
 import org.elasticsearch.xpack.ml.notifications.Auditor;
@@ -137,6 +138,8 @@ protected void masterOperation(Task task, DeleteJobAction.Request request, Clust
                                    ActionListener<AcknowledgedResponse> listener) {
         logger.debug("Deleting job '{}'", request.getJobId());
 
+        JobManager.getJobOrThrowIfUnknown(request.getJobId(), state);
+
         TaskId taskId = new TaskId(clusterService.localNode().getId(), task.getId());
         ParentTaskAssigningClient parentTaskClient = new ParentTaskAssigningClient(client, taskId);
 

x-pack/plugin/src/test/resources/rest-api-spec/test/ml/jobs_crud.yml

@@ -460,6 +460,13 @@
           }
   - match: { analysis_limits.model_memory_limit: "30mb" }
 
+---
+"Test delete job that does not exist":
+  - do:
+      catch: missing
+      xpack.ml.delete_job:
+        job_id: not-a-job
+
 ---
 "Test delete job that is referred by a datafeed":
   - do: