MINOR: Remove some deadcode in NodeEnv and Related (#34133)

Author: original-brownbear

server/src/main/java/org/elasticsearch/env/NodeEnvironment.java

@@ -551,10 +551,8 @@ public void deleteIndexDirectoryUnderLock(Index index, IndexSettings indexSettin
      * @param index the index to lock shards for
      * @param lockTimeoutMS how long to wait for acquiring the indices shard locks
      * @return the {@link ShardLock} instances for this index.
-     * @throws IOException if an IOException occurs.
      */
-    public List<ShardLock> lockAllForIndex(Index index, IndexSettings settings, long lockTimeoutMS)
-            throws IOException, ShardLockObtainFailedException {
+    public List<ShardLock> lockAllForIndex(Index index, IndexSettings settings, long lockTimeoutMS) throws ShardLockObtainFailedException {
         final int numShards = settings.getNumberOfShards();
         if (numShards <= 0) {
             throw new IllegalArgumentException("settings must contain a non-null > 0 number of shards");
@@ -842,7 +840,7 @@ public Set<String> availableIndexFoldersForPath(final NodePath nodePath) throws
     /**
      * Resolves all existing paths to <code>indexFolderName</code> in ${data.paths}/nodes/{node.id}/indices
      */
-    public Path[] resolveIndexFolder(String indexFolderName) throws IOException {
+    public Path[] resolveIndexFolder(String indexFolderName) {
         if (nodePaths == null || locks == null) {
             throw new IllegalStateException("node is not configured to store local location");
         }
@@ -987,17 +985,6 @@ public void ensureAtomicMoveSupported() throws IOException {
         }
     }
 
-    /**
-     * Resolve the custom path for a index's shard.
-     * Uses the {@code IndexMetaData.SETTING_DATA_PATH} setting to determine
-     * the root path for the index.
-     *
-     * @param indexSettings settings for the index
-     */
-    public Path resolveBaseCustomLocation(IndexSettings indexSettings) {
-        return resolveBaseCustomLocation(indexSettings, sharedDataPath, nodeLockId);
-    }
-
     /**
      * Resolve the custom path for a index's shard.
      * Uses the {@code IndexMetaData.SETTING_DATA_PATH} setting to determine

server/src/main/java/org/elasticsearch/env/ShardLock.java

@@ -29,7 +29,7 @@
  * directory. Internal processes should acquire a lock on a shard
  * before executing any write operations on the shards data directory.
  *
- * @see org.elasticsearch.env.NodeEnvironment
+ * @see NodeEnvironment
  */
 public abstract class ShardLock implements Closeable {
 
@@ -56,13 +56,6 @@ public final void close() {
 
     protected  abstract void closeInternal();
 
-    /**
-     * Returns true if this lock is still open ie. has not been closed yet.
-     */
-    public final boolean isOpen() {
-        return closed.get() == false;
-    }
-
     @Override
     public String toString() {
         return "ShardLock{" +

server/src/main/java/org/elasticsearch/indices/store/TransportNodesListShardStoreMetaData.java

@@ -254,9 +254,6 @@ public void writeTo(StreamOutput out) throws IOException {
 
     public static class NodesStoreFilesMetaData extends BaseNodesResponse<NodeStoreFilesMetaData> {
 
-        NodesStoreFilesMetaData() {
-        }
-
         public NodesStoreFilesMetaData(ClusterName clusterName, List<NodeStoreFilesMetaData> nodes, List<FailedNodeException> failures) {
             super(clusterName, nodes, failures);
         }