Skip to content

Commit c32e71c

Browse files
hub-caphub-cap
authored
HLRC: split snapshot request converters (#33439)
In an effort to encapsulate the different clients, the request converters are being shuffled around. This splits the SnapshotClient request converters.
1 parent 90c99ea commit c32e71c

File tree

5 files changed

+459
-385
lines changed

5 files changed

+459
-385
lines changed

‎client/rest-high-level/src/main/java/org/elasticsearch/client/RequestConverters.java‎

Lines changed: 0 additions & 129 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@
3030
import org.apache.lucene.util.BytesRef;
3131
import org.elasticsearch.action.DocWriteRequest;
3232
import org.elasticsearch.action.admin.cluster.health.ClusterHealthRequest;
33-
import org.elasticsearch.action.admin.cluster.repositories.delete.DeleteRepositoryRequest;
34-
import org.elasticsearch.action.admin.cluster.repositories.get.GetRepositoriesRequest;
35-
import org.elasticsearch.action.admin.cluster.repositories.put.PutRepositoryRequest;
36-
import org.elasticsearch.action.admin.cluster.repositories.verify.VerifyRepositoryRequest;
37-
import org.elasticsearch.action.admin.cluster.snapshots.create.CreateSnapshotRequest;
38-
import org.elasticsearch.action.admin.cluster.snapshots.delete.DeleteSnapshotRequest;
39-
import org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsRequest;
40-
import org.elasticsearch.action.admin.cluster.snapshots.restore.RestoreSnapshotRequest;
41-
import org.elasticsearch.action.admin.cluster.snapshots.status.SnapshotsStatusRequest;
4233
import org.elasticsearch.action.admin.cluster.storedscripts.DeleteStoredScriptRequest;
4334
import org.elasticsearch.action.admin.cluster.storedscripts.GetStoredScriptRequest;
4435
import org.elasticsearch.action.admin.indices.alias.IndicesAliasesRequest;
@@ -893,126 +884,6 @@ static Request indexPutSettings(UpdateSettingsRequest updateSettingsRequest) thr
893884
return request;
894885
}
895886

896-
static Request getRepositories(GetRepositoriesRequest getRepositoriesRequest) {
897-
String[] repositories = getRepositoriesRequest.repositories() == null ? Strings.EMPTY_ARRAY : getRepositoriesRequest.repositories();
898-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot").addCommaSeparatedPathParts(repositories).build();
899-
Request request = new Request(HttpGet.METHOD_NAME, endpoint);
900-
901-
Params parameters = new Params(request);
902-
parameters.withMasterTimeout(getRepositoriesRequest.masterNodeTimeout());
903-
parameters.withLocal(getRepositoriesRequest.local());
904-
return request;
905-
}
906-
907-
static Request createRepository(PutRepositoryRequest putRepositoryRequest) throws IOException {
908-
String endpoint = new EndpointBuilder().addPathPart("_snapshot").addPathPart(putRepositoryRequest.name()).build();
909-
Request request = new Request(HttpPut.METHOD_NAME, endpoint);
910-
911-
Params parameters = new Params(request);
912-
parameters.withMasterTimeout(putRepositoryRequest.masterNodeTimeout());
913-
parameters.withTimeout(putRepositoryRequest.timeout());
914-
parameters.withVerify(putRepositoryRequest.verify());
915-
916-
request.setEntity(createEntity(putRepositoryRequest, REQUEST_BODY_CONTENT_TYPE));
917-
return request;
918-
}
919-
920-
static Request deleteRepository(DeleteRepositoryRequest deleteRepositoryRequest) {
921-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot").addPathPart(deleteRepositoryRequest.name()).build();
922-
Request request = new Request(HttpDelete.METHOD_NAME, endpoint);
923-
924-
Params parameters = new Params(request);
925-
parameters.withMasterTimeout(deleteRepositoryRequest.masterNodeTimeout());
926-
parameters.withTimeout(deleteRepositoryRequest.timeout());
927-
return request;
928-
}
929-
930-
static Request verifyRepository(VerifyRepositoryRequest verifyRepositoryRequest) {
931-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot")
932-
.addPathPart(verifyRepositoryRequest.name())
933-
.addPathPartAsIs("_verify")
934-
.build();
935-
Request request = new Request(HttpPost.METHOD_NAME, endpoint);
936-
937-
Params parameters = new Params(request);
938-
parameters.withMasterTimeout(verifyRepositoryRequest.masterNodeTimeout());
939-
parameters.withTimeout(verifyRepositoryRequest.timeout());
940-
return request;
941-
}
942-
943-
static Request createSnapshot(CreateSnapshotRequest createSnapshotRequest) throws IOException {
944-
String endpoint = new EndpointBuilder().addPathPart("_snapshot")
945-
.addPathPart(createSnapshotRequest.repository())
946-
.addPathPart(createSnapshotRequest.snapshot())
947-
.build();
948-
Request request = new Request(HttpPut.METHOD_NAME, endpoint);
949-
Params params = new Params(request);
950-
params.withMasterTimeout(createSnapshotRequest.masterNodeTimeout());
951-
params.withWaitForCompletion(createSnapshotRequest.waitForCompletion());
952-
request.setEntity(createEntity(createSnapshotRequest, REQUEST_BODY_CONTENT_TYPE));
953-
return request;
954-
}
955-
956-
static Request getSnapshots(GetSnapshotsRequest getSnapshotsRequest) {
957-
EndpointBuilder endpointBuilder = new EndpointBuilder().addPathPartAsIs("_snapshot")
958-
.addPathPart(getSnapshotsRequest.repository());
959-
String endpoint;
960-
if (getSnapshotsRequest.snapshots().length == 0) {
961-
endpoint = endpointBuilder.addPathPart("_all").build();
962-
} else {
963-
endpoint = endpointBuilder.addCommaSeparatedPathParts(getSnapshotsRequest.snapshots()).build();
964-
}
965-
966-
Request request = new Request(HttpGet.METHOD_NAME, endpoint);
967-
968-
Params parameters = new Params(request);
969-
parameters.withMasterTimeout(getSnapshotsRequest.masterNodeTimeout());
970-
parameters.putParam("ignore_unavailable", Boolean.toString(getSnapshotsRequest.ignoreUnavailable()));
971-
parameters.putParam("verbose", Boolean.toString(getSnapshotsRequest.verbose()));
972-
973-
return request;
974-
}
975-
976-
static Request snapshotsStatus(SnapshotsStatusRequest snapshotsStatusRequest) {
977-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot")
978-
.addPathPart(snapshotsStatusRequest.repository())
979-
.addCommaSeparatedPathParts(snapshotsStatusRequest.snapshots())
980-
.addPathPartAsIs("_status")
981-
.build();
982-
Request request = new Request(HttpGet.METHOD_NAME, endpoint);
983-
984-
Params parameters = new Params(request);
985-
parameters.withMasterTimeout(snapshotsStatusRequest.masterNodeTimeout());
986-
parameters.withIgnoreUnavailable(snapshotsStatusRequest.ignoreUnavailable());
987-
return request;
988-
}
989-
990-
static Request restoreSnapshot(RestoreSnapshotRequest restoreSnapshotRequest) throws IOException {
991-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot")
992-
.addPathPart(restoreSnapshotRequest.repository())
993-
.addPathPart(restoreSnapshotRequest.snapshot())
994-
.addPathPartAsIs("_restore")
995-
.build();
996-
Request request = new Request(HttpPost.METHOD_NAME, endpoint);
997-
Params parameters = new Params(request);
998-
parameters.withMasterTimeout(restoreSnapshotRequest.masterNodeTimeout());
999-
parameters.withWaitForCompletion(restoreSnapshotRequest.waitForCompletion());
1000-
request.setEntity(createEntity(restoreSnapshotRequest, REQUEST_BODY_CONTENT_TYPE));
1001-
return request;
1002-
}
1003-
1004-
static Request deleteSnapshot(DeleteSnapshotRequest deleteSnapshotRequest) {
1005-
String endpoint = new EndpointBuilder().addPathPartAsIs("_snapshot")
1006-
.addPathPart(deleteSnapshotRequest.repository())
1007-
.addPathPart(deleteSnapshotRequest.snapshot())
1008-
.build();
1009-
Request request = new Request(HttpDelete.METHOD_NAME, endpoint);
1010-
1011-
Params parameters = new Params(request);
1012-
parameters.withMasterTimeout(deleteSnapshotRequest.masterNodeTimeout());
1013-
return request;
1014-
}
1015-
1016887
static Request putTemplate(PutIndexTemplateRequest putIndexTemplateRequest) throws IOException {
1017888
String endpoint = new EndpointBuilder().addPathPartAsIs("_template").addPathPart(putIndexTemplateRequest.name()).build();
1018889
Request request = new Request(HttpPut.METHOD_NAME, endpoint);

‎client/rest-high-level/src/main/java/org/elasticsearch/client/SnapshotClient.java‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public final class SnapshotClient {
6565
*/
6666
public GetRepositoriesResponse getRepository(GetRepositoriesRequest getRepositoriesRequest, RequestOptions options)
6767
throws IOException {
68-
return restHighLevelClient.performRequestAndParseEntity(getRepositoriesRequest, RequestConverters::getRepositories, options,
68+
return restHighLevelClient.performRequestAndParseEntity(getRepositoriesRequest, SnapshotRequestConverters::getRepositories, options,
6969
GetRepositoriesResponse::fromXContent, emptySet());
7070
}
7171

@@ -80,7 +80,7 @@ public GetRepositoriesResponse getRepository(GetRepositoriesRequest getRepositor
8080
*/
8181
public void getRepositoryAsync(GetRepositoriesRequest getRepositoriesRequest, RequestOptions options,
8282
ActionListener<GetRepositoriesResponse> listener) {
83-
restHighLevelClient.performRequestAsyncAndParseEntity(getRepositoriesRequest, RequestConverters::getRepositories, options,
83+
restHighLevelClient.performRequestAsyncAndParseEntity(getRepositoriesRequest, SnapshotRequestConverters::getRepositories, options,
8484
GetRepositoriesResponse::fromXContent, listener, emptySet());
8585
}
8686

@@ -94,7 +94,7 @@ public void getRepositoryAsync(GetRepositoriesRequest getRepositoriesRequest, Re
9494
* @throws IOException in case there is a problem sending the request or parsing back the response
9595
*/
9696
public AcknowledgedResponse createRepository(PutRepositoryRequest putRepositoryRequest, RequestOptions options) throws IOException {
97-
return restHighLevelClient.performRequestAndParseEntity(putRepositoryRequest, RequestConverters::createRepository, options,
97+
return restHighLevelClient.performRequestAndParseEntity(putRepositoryRequest, SnapshotRequestConverters::createRepository, options,
9898
AcknowledgedResponse::fromXContent, emptySet());
9999
}
100100

@@ -108,7 +108,7 @@ public AcknowledgedResponse createRepository(PutRepositoryRequest putRepositoryR
108108
*/
109109
public void createRepositoryAsync(PutRepositoryRequest putRepositoryRequest, RequestOptions options,
110110
ActionListener<AcknowledgedResponse> listener) {
111-
restHighLevelClient.performRequestAsyncAndParseEntity(putRepositoryRequest, RequestConverters::createRepository, options,
111+
restHighLevelClient.performRequestAsyncAndParseEntity(putRepositoryRequest, SnapshotRequestConverters::createRepository, options,
112112
AcknowledgedResponse::fromXContent, listener, emptySet());
113113
}
114114

@@ -123,8 +123,8 @@ public void createRepositoryAsync(PutRepositoryRequest putRepositoryRequest, Req
123123
*/
124124
public AcknowledgedResponse deleteRepository(DeleteRepositoryRequest deleteRepositoryRequest, RequestOptions options)
125125
throws IOException {
126-
return restHighLevelClient.performRequestAndParseEntity(deleteRepositoryRequest, RequestConverters::deleteRepository, options,
127-
AcknowledgedResponse::fromXContent, emptySet());
126+
return restHighLevelClient.performRequestAndParseEntity(deleteRepositoryRequest, SnapshotRequestConverters::deleteRepository,
127+
options, AcknowledgedResponse::fromXContent, emptySet());
128128
}
129129

130130
/**
@@ -137,7 +137,7 @@ public AcknowledgedResponse deleteRepository(DeleteRepositoryRequest deleteRepos
137137
*/
138138
public void deleteRepositoryAsync(DeleteRepositoryRequest deleteRepositoryRequest, RequestOptions options,
139139
ActionListener<AcknowledgedResponse> listener) {
140-
restHighLevelClient.performRequestAsyncAndParseEntity(deleteRepositoryRequest, RequestConverters::deleteRepository, options,
140+
restHighLevelClient.performRequestAsyncAndParseEntity(deleteRepositoryRequest, SnapshotRequestConverters::deleteRepository, options,
141141
AcknowledgedResponse::fromXContent, listener, emptySet());
142142
}
143143

@@ -152,8 +152,8 @@ public void deleteRepositoryAsync(DeleteRepositoryRequest deleteRepositoryReques
152152
*/
153153
public VerifyRepositoryResponse verifyRepository(VerifyRepositoryRequest verifyRepositoryRequest, RequestOptions options)
154154
throws IOException {
155-
return restHighLevelClient.performRequestAndParseEntity(verifyRepositoryRequest, RequestConverters::verifyRepository, options,
156-
VerifyRepositoryResponse::fromXContent, emptySet());
155+
return restHighLevelClient.performRequestAndParseEntity(verifyRepositoryRequest, SnapshotRequestConverters::verifyRepository,
156+
options, VerifyRepositoryResponse::fromXContent, emptySet());
157157
}
158158

159159
/**
@@ -166,7 +166,7 @@ public VerifyRepositoryResponse verifyRepository(VerifyRepositoryRequest verifyR
166166
*/
167167
public void verifyRepositoryAsync(VerifyRepositoryRequest verifyRepositoryRequest, RequestOptions options,
168168
ActionListener<VerifyRepositoryResponse> listener) {
169-
restHighLevelClient.performRequestAsyncAndParseEntity(verifyRepositoryRequest, RequestConverters::verifyRepository, options,
169+
restHighLevelClient.performRequestAsyncAndParseEntity(verifyRepositoryRequest, SnapshotRequestConverters::verifyRepository, options,
170170
VerifyRepositoryResponse::fromXContent, listener, emptySet());
171171
}
172172

@@ -178,7 +178,7 @@ public void verifyRepositoryAsync(VerifyRepositoryRequest verifyRepositoryReques
178178
*/
179179
public CreateSnapshotResponse create(CreateSnapshotRequest createSnapshotRequest, RequestOptions options)
180180
throws IOException {
181-
return restHighLevelClient.performRequestAndParseEntity(createSnapshotRequest, RequestConverters::createSnapshot, options,
181+
return restHighLevelClient.performRequestAndParseEntity(createSnapshotRequest, SnapshotRequestConverters::createSnapshot, options,
182182
CreateSnapshotResponse::fromXContent, emptySet());
183183
}
184184

@@ -190,7 +190,7 @@ public CreateSnapshotResponse create(CreateSnapshotRequest createSnapshotRequest
190190
*/
191191
public void createAsync(CreateSnapshotRequest createSnapshotRequest, RequestOptions options,
192192
ActionListener<CreateSnapshotResponse> listener) {
193-
restHighLevelClient.performRequestAsyncAndParseEntity(createSnapshotRequest, RequestConverters::createSnapshot, options,
193+
restHighLevelClient.performRequestAsyncAndParseEntity(createSnapshotRequest, SnapshotRequestConverters::createSnapshot, options,
194194
CreateSnapshotResponse::fromXContent, listener, emptySet());
195195
}
196196

@@ -205,7 +205,7 @@ public void createAsync(CreateSnapshotRequest createSnapshotRequest, RequestOpti
205205
* @throws IOException in case there is a problem sending the request or parsing back the response
206206
*/
207207
public GetSnapshotsResponse get(GetSnapshotsRequest getSnapshotsRequest, RequestOptions options) throws IOException {
208-
return restHighLevelClient.performRequestAndParseEntity(getSnapshotsRequest, RequestConverters::getSnapshots, options,
208+
return restHighLevelClient.performRequestAndParseEntity(getSnapshotsRequest, SnapshotRequestConverters::getSnapshots, options,
209209
GetSnapshotsResponse::fromXContent, emptySet());
210210
}
211211

@@ -219,7 +219,7 @@ public GetSnapshotsResponse get(GetSnapshotsRequest getSnapshotsRequest, Request
219219
* @param listener the listener to be notified upon request completion
220220
*/
221221
public void getAsync(GetSnapshotsRequest getSnapshotsRequest, RequestOptions options, ActionListener<GetSnapshotsResponse> listener) {
222-
restHighLevelClient.performRequestAsyncAndParseEntity(getSnapshotsRequest, RequestConverters::getSnapshots, options,
222+
restHighLevelClient.performRequestAsyncAndParseEntity(getSnapshotsRequest, SnapshotRequestConverters::getSnapshots, options,
223223
GetSnapshotsResponse::fromXContent, listener, emptySet());
224224
}
225225

@@ -234,7 +234,7 @@ public void getAsync(GetSnapshotsRequest getSnapshotsRequest, RequestOptions opt
234234
*/
235235
public SnapshotsStatusResponse status(SnapshotsStatusRequest snapshotsStatusRequest, RequestOptions options)
236236
throws IOException {
237-
return restHighLevelClient.performRequestAndParseEntity(snapshotsStatusRequest, RequestConverters::snapshotsStatus, options,
237+
return restHighLevelClient.performRequestAndParseEntity(snapshotsStatusRequest, SnapshotRequestConverters::snapshotsStatus, options,
238238
SnapshotsStatusResponse::fromXContent, emptySet());
239239
}
240240

@@ -248,7 +248,7 @@ public SnapshotsStatusResponse status(SnapshotsStatusRequest snapshotsStatusRequ
248248
*/
249249
public void statusAsync(SnapshotsStatusRequest snapshotsStatusRequest, RequestOptions options,
250250
ActionListener<SnapshotsStatusResponse> listener) {
251-
restHighLevelClient.performRequestAsyncAndParseEntity(snapshotsStatusRequest, RequestConverters::snapshotsStatus, options,
251+
restHighLevelClient.performRequestAsyncAndParseEntity(snapshotsStatusRequest, SnapshotRequestConverters::snapshotsStatus, options,
252252
SnapshotsStatusResponse::fromXContent, listener, emptySet());
253253
}
254254

@@ -263,7 +263,7 @@ public void statusAsync(SnapshotsStatusRequest snapshotsStatusRequest, RequestOp
263263
* @throws IOException in case there is a problem sending the request or parsing back the response
264264
*/
265265
public RestoreSnapshotResponse restore(RestoreSnapshotRequest restoreSnapshotRequest, RequestOptions options) throws IOException {
266-
return restHighLevelClient.performRequestAndParseEntity(restoreSnapshotRequest, RequestConverters::restoreSnapshot, options,
266+
return restHighLevelClient.performRequestAndParseEntity(restoreSnapshotRequest, SnapshotRequestConverters::restoreSnapshot, options,
267267
RestoreSnapshotResponse::fromXContent, emptySet());
268268
}
269269

@@ -278,7 +278,7 @@ public RestoreSnapshotResponse restore(RestoreSnapshotRequest restoreSnapshotReq
278278
*/
279279
public void restoreAsync(RestoreSnapshotRequest restoreSnapshotRequest, RequestOptions options,
280280
ActionListener<RestoreSnapshotResponse> listener) {
281-
restHighLevelClient.performRequestAsyncAndParseEntity(restoreSnapshotRequest, RequestConverters::restoreSnapshot, options,
281+
restHighLevelClient.performRequestAsyncAndParseEntity(restoreSnapshotRequest, SnapshotRequestConverters::restoreSnapshot, options,
282282
RestoreSnapshotResponse::fromXContent, listener, emptySet());
283283
}
284284

@@ -293,7 +293,7 @@ public void restoreAsync(RestoreSnapshotRequest restoreSnapshotRequest, RequestO
293293
* @throws IOException in case there is a problem sending the request or parsing back the response
294294
*/
295295
public AcknowledgedResponse delete(DeleteSnapshotRequest deleteSnapshotRequest, RequestOptions options) throws IOException {
296-
return restHighLevelClient.performRequestAndParseEntity(deleteSnapshotRequest, RequestConverters::deleteSnapshot, options,
296+
return restHighLevelClient.performRequestAndParseEntity(deleteSnapshotRequest, SnapshotRequestConverters::deleteSnapshot, options,
297297
AcknowledgedResponse::fromXContent, emptySet());
298298
}
299299

@@ -308,7 +308,7 @@ public AcknowledgedResponse delete(DeleteSnapshotRequest deleteSnapshotRequest,
308308
*/
309309
public void deleteAsync(DeleteSnapshotRequest deleteSnapshotRequest, RequestOptions options,
310310
ActionListener<AcknowledgedResponse> listener) {
311-
restHighLevelClient.performRequestAsyncAndParseEntity(deleteSnapshotRequest, RequestConverters::deleteSnapshot, options,
311+
restHighLevelClient.performRequestAsyncAndParseEntity(deleteSnapshotRequest, SnapshotRequestConverters::deleteSnapshot, options,
312312
AcknowledgedResponse::fromXContent, listener, emptySet());
313313
}
314314
}

0 commit comments

Comments
 (0)