Fix IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) (#37414)

tlrx · tlrx · commit c06b0b5d1a06 · 2019-01-15T12:49:05.000+01:00
This commit fixes the IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) 
method where the startReplica parameter was not correctly propagated and the value
 true always used instead.
diff --git a/test/framework/src/main/java/org/elasticsearch/index/shard/IndexShardTestCase.java b/test/framework/src/main/java/org/elasticsearch/index/shard/IndexShardTestCase.java
@@ -551,7 +551,7 @@ protected void recoverReplica(IndexShard replica, IndexShard primary, boolean st
         recoverReplica(replica, primary,
             (r, sourceNode) -> new RecoveryTarget(r, sourceNode, recoveryListener, version -> {
             }),
-            true, true);
+            true, startReplica);
     }
 
     /** recovers a replica from the given primary **/

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ protected void recoverReplica(IndexShard replica, IndexShard primary, boolean st`
`551`	`551`	`recoverReplica(replica, primary,`
`552`	`552`	`(r, sourceNode) -> new RecoveryTarget(r, sourceNode, recoveryListener, version -> {`
`553`	`553`	`}),`
`554`		`- true, true);`
	`554`	`+ true, startReplica);`
`555`	`555`	`}`
`556`	`556`
`557`	`557`	`/ recovers a replica from the given primary /`