Address review comments

Author: davidkyle

client/rest-high-level/src/main/java/org/elasticsearch/client/ml/calendars/Calendar.java

@@ -65,7 +65,7 @@ public class Calendar implements ToXContentObject {
      */
     public Calendar(String id, List<String> jobIds, @Nullable String description) {
         this.id = Objects.requireNonNull(id, ID.getPreferredName() + " must not be null");
-        this.jobIds = Objects.requireNonNull(jobIds, JOB_IDS.getPreferredName() + " must not be null");
+        this.jobIds = Collections.unmodifiableList(Objects.requireNonNull(jobIds, JOB_IDS.getPreferredName() + " must not be null"));
         this.description = description;
     }
 
@@ -74,7 +74,7 @@ public String getId() {
     }
 
     public List<String> getJobIds() {
-        return Collections.unmodifiableList(jobIds);
+        return jobIds;
     }
 
     @Nullable
@@ -100,7 +100,7 @@ public boolean equals(Object obj) {
             return true;
         }
 
-        if (!(obj instanceof Calendar)) {
+        if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
 

client/rest-high-level/src/main/java/org/elasticsearch/client/ml/calendars/ScheduledEvent.java

@@ -107,7 +107,7 @@ public boolean equals(Object obj) {
             return true;
         }
 
-        if (!(obj instanceof ScheduledEvent)) {
+        if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
 

client/rest-high-level/src/test/java/org/elasticsearch/client/ml/PutCalendarRequestTests.java

@@ -39,6 +39,6 @@ protected PutCalendarRequest doParseInstance(XContentParser parser) throws IOExc
 
     @Override
     protected boolean supportsUnknownFields() {
-        return false;
+        return true;
     }
 }

client/rest-high-level/src/test/java/org/elasticsearch/client/ml/PutCalendarResponseTests.java

@@ -38,6 +38,6 @@ protected PutCalendarResponse doParseInstance(XContentParser parser) throws IOEx
 
     @Override
     protected boolean supportsUnknownFields() {
-        return false;
+        return true;
     }
 }

client/rest-high-level/src/test/java/org/elasticsearch/client/ml/calendars/CalendarTests.java

@@ -56,6 +56,6 @@ protected Calendar doParseInstance(XContentParser parser) throws IOException {
 
     @Override
     protected boolean supportsUnknownFields() {
-        return false;
+        return true;
     }
 }

client/rest-high-level/src/test/java/org/elasticsearch/client/ml/calendars/ScheduledEventTests.java

@@ -46,6 +46,6 @@ protected ScheduledEvent doParseInstance(XContentParser parser) {
 
     @Override
     protected boolean supportsUnknownFields() {
-        return false;
+        return true;
     }
 }

docs/java-rest/high-level/ml/get-buckets.asciidoc

@@ -112,7 +112,7 @@ include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-get-buckets-l
 <1> `onResponse` is called back when the action is completed successfully
 <2> `onFailure` is called back when some unexpected error occurs
 
-[[java-rest-high-snapshot-ml-get-buckets-response]]
+[[java-rest-high-x-pack-ml-get-buckets-response]]
 ==== Get Buckets Response
 
 The returned `GetBucketsResponse` contains the requested buckets:

docs/java-rest/high-level/ml/get-categories.asciidoc

@@ -70,7 +70,7 @@ include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-get-categorie
 <1> `onResponse` is called back when the action is completed successfully
 <2> `onFailure` is called back when some unexpected error occurs
 
-[[java-rest-high-snapshot-ml-get-categories-response]]
+[[java-rest-high-x-pack-ml-get-categories-response]]
 ==== Get Categories Response
 
 The returned `GetCategoriesResponse` contains the requested categories:

docs/java-rest/high-level/ml/get-influencers.asciidoc

@@ -99,7 +99,7 @@ include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-get-influence
 <1> `onResponse` is called back when the action is completed successfully
 <2> `onFailure` is called back when some unexpected error occurs
 
-[[java-rest-high-snapshot-ml-get-influencers-response]]
+[[java-rest-high-x-pack-ml-get-influencers-response]]
 ==== Get Influencers Response
 
 The returned `GetInfluencersResponse` contains the requested influencers:

docs/java-rest/high-level/ml/get-overall-buckets.asciidoc

@@ -94,7 +94,7 @@ include-tagged::{doc-tests}/MlClientDocumentationIT.java[x-pack-ml-get-overall-b
 <1> `onResponse` is called back when the action is completed successfully
 <2> `onFailure` is called back when some unexpected error occurs
 
-[[java-rest-high-snapshot-ml-get-overall-buckets-response]]
+[[java-rest-high-x-pack-ml-get-overall-buckets-response]]
 ==== Get Overall Buckets Response
 
 The returned `GetOverallBucketsResponse` contains the requested buckets: