Do not allow negative variances (#37384)

Due to floating point error, it was possible for variances to become negative which should never happen.  This bugfix sets variance to zero if it becomes negative as a result of fp error.

Author: vishnugt

server/src/main/java/org/elasticsearch/search/aggregations/metrics/stats/extended/ExtendedStatsAggregator.java

@@ -202,7 +202,8 @@ public double metric(String name, long owningBucketOrd) {
     private double variance(long owningBucketOrd) {
         double sum = sums.get(owningBucketOrd);
         long count = counts.get(owningBucketOrd);
-        return (sumOfSqrs.get(owningBucketOrd) - ((sum * sum) / count)) / count;
+        double variance = (sumOfSqrs.get(owningBucketOrd) - ((sum * sum) / count)) / count;
+        return variance < 0  ? 0 : variance;
     }
 
     @Override

server/src/main/java/org/elasticsearch/search/aggregations/metrics/stats/extended/InternalExtendedStats.java

@@ -102,7 +102,8 @@ public double getSumOfSquares() {
 
     @Override
     public double getVariance() {
-        return (sumOfSqrs - ((sum * sum) / count)) / count;
+        double variance =  (sumOfSqrs - ((sum * sum) / count)) / count;
+        return variance < 0  ? 0 : variance;
     }
 
     @Override

server/src/test/java/org/elasticsearch/search/aggregations/metrics/ExtendedStatsAggregatorTests.java

@@ -99,6 +99,34 @@ public void testRandomDoubles() throws IOException {
         );
     }
 
+    /**
+     * Testcase for https://github.com/elastic/elasticsearch/issues/37303
+     */
+    public void testVarianceNonNegative() throws IOException {
+        MappedFieldType ft =
+            new NumberFieldMapper.NumberFieldType(NumberFieldMapper.NumberType.DOUBLE);
+        ft.setName("field");
+        final ExtendedSimpleStatsAggregator expected = new ExtendedSimpleStatsAggregator();
+        testCase(ft,
+            iw -> {
+                int numDocs = 3;
+                for (int i = 0; i < numDocs; i++) {
+                    Document doc = new Document();
+                    double value = 49.95d;
+                    long valueAsLong = NumericUtils.doubleToSortableLong(value);
+                    doc.add(new SortedNumericDocValuesField("field", valueAsLong));
+                    expected.add(value);
+                    iw.addDocument(doc);
+                }
+            },
+            stats -> {
+                //since the value(49.95) is a constant, variance should be 0
+                assertEquals(0.0d, stats.getVariance(), TOLERANCE);
+                assertEquals(0.0d, stats.getStdDeviation(), TOLERANCE);
+            }
+        );
+    }
+
     public void testRandomLongs() throws IOException {
         MappedFieldType ft =
             new NumberFieldMapper.NumberFieldType(NumberFieldMapper.NumberType.LONG);
@@ -235,7 +263,8 @@ void add(double value) {
         }
 
         double variance() {
-            return (sumOfSqrs - ((sum * sum) / count)) / count;
+            double variance = (sumOfSqrs - ((sum * sum) / count)) / count;
+            return variance < 0  ? 0 : variance;
         }
     }
 }

server/src/test/java/org/elasticsearch/search/aggregations/metrics/ExtendedStatsIT.java

@@ -74,7 +74,8 @@ private static double variance(int... vals) {
             sum += val;
             sumOfSqrs += val * val;
         }
-        return (sumOfSqrs - ((sum * sum) / vals.length)) / vals.length;
+        double variance  = (sumOfSqrs - ((sum * sum) / vals.length)) / vals.length;
+        return variance < 0  ? 0 : variance;
     }
 
     @Override

server/src/test/java/org/elasticsearch/search/aggregations/pipeline/ExtendedStatsBucketIT.java

@@ -138,6 +138,7 @@ public void testGappyIndexWithSigma() {
         double sumOfSqrs = 1.0 + 1.0 + 1.0 + 4.0 + 0.0 + 1.0;
         double avg = sum / count;
         double var = (sumOfSqrs - ((sum * sum) / count)) / count;
+        var = var < 0  ? 0 : var;
         double stdDev = Math.sqrt(var);
         assertThat(extendedStatsBucketValue, notNullValue());
         assertThat(extendedStatsBucketValue.getName(), equalTo("extended_stats_bucket"));