Skip to content

Commit a0e6972

Browse files
Correct errors - HRLC TermVectorRequest (#35705)
Relates to #35266, #35614
1 parent 214bc96 commit a0e6972

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

client/rest-high-level/src/main/java/org/elasticsearch/client/core/TermVectorsRequest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,6 @@ public void setPerFieldAnalyzer(Map<String, String> perFieldAnalyzer) {
170170
this.perFieldAnalyzer = perFieldAnalyzer;
171171
}
172172

173-
/**
174-
* Sets an artifical document on what to request _termvectors
175-
*/
176-
public void setDoc(XContentBuilder docBuilder) {
177-
this.docBuilder = docBuilder;
178-
}
179-
180173
/**
181174
* Sets conditions for terms filtering
182175
*/

client/rest-high-level/src/test/java/org/elasticsearch/client/CrudIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1214,7 +1214,7 @@ public void testMultiTermvectors() throws IOException {
12141214
{
12151215
// test _mtermvectors where MultiTermVectorsRequest is constructed with ids and a template
12161216
String[] expectedIds = {"1", "2"};
1217-
TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc");
1217+
TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc", "fake_id");
12181218
tvRequestTemplate.setFields("field");
12191219
MultiTermVectorsRequest mtvRequest = new MultiTermVectorsRequest(expectedIds, tvRequestTemplate);
12201220

@@ -1236,10 +1236,10 @@ public void testMultiTermvectors() throws IOException {
12361236
TermVectorsRequest tvRequest1 = new TermVectorsRequest(sourceIndex, "_doc", "1");
12371237
tvRequest1.setFields("field");
12381238
mtvRequest.add(tvRequest1);
1239-
TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc");
1239+
12401240
XContentBuilder docBuilder = XContentFactory.jsonBuilder();
12411241
docBuilder.startObject().field("field", "valuex").endObject();
1242-
tvRequest2.setDoc(docBuilder);
1242+
TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc", docBuilder);
12431243
mtvRequest.add(tvRequest2);
12441244

12451245
MultiTermVectorsResponse mtvResponse =

client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/CRUDDocumentationIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,18 +1692,18 @@ public void testMultiTermVectors() throws Exception {
16921692
new TermVectorsRequest("authors", "_doc", "1");
16931693
tvrequest1.setFields("user");
16941694
request.add(tvrequest1); // <2>
1695-
TermVectorsRequest tvrequest2 =
1696-
new TermVectorsRequest("authors", "_doc");
1695+
16971696
XContentBuilder docBuilder = XContentFactory.jsonBuilder();
16981697
docBuilder.startObject().field("user", "guest-user").endObject();
1699-
tvrequest2.setDoc(docBuilder);
1698+
TermVectorsRequest tvrequest2 =
1699+
new TermVectorsRequest("authors", "_doc", docBuilder);
17001700
request.add(tvrequest2); // <3>
17011701
// end::multi-term-vectors-request
17021702
}
17031703

17041704
// tag::multi-term-vectors-request-template
17051705
TermVectorsRequest tvrequestTemplate =
1706-
new TermVectorsRequest("authors", "_doc"); // <1>
1706+
new TermVectorsRequest("authors", "_doc", "fake_id"); // <1>
17071707
tvrequestTemplate.setFields("user");
17081708
String[] ids = {"1", "2"};
17091709
MultiTermVectorsRequest request =

0 commit comments

Comments
 (0)