[ML-DataFrame] fix test failure in checkpoint retrieval (#45297)

gracefully handle if index response returns null, increase and assert timeout

closes #45238

Author: Hendrik Muhs

x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/checkpoint/DefaultCheckpointProvider.java

@@ -148,7 +148,9 @@ protected void getIndexCheckpoints (ActionListener<Map<String, long[]>> listener
 
         ClientHelper.executeWithHeadersAsync(transformConfig.getHeaders(), ClientHelper.DATA_FRAME_ORIGIN, client, GetIndexAction.INSTANCE,
                 getIndexRequest, ActionListener.wrap(getIndexResponse -> {
-                    Set<String> userIndices = new HashSet<>(Arrays.asList(getIndexResponse.getIndices()));
+                    Set<String> userIndices = getIndexResponse.getIndices() != null
+                            ? new HashSet<>(Arrays.asList(getIndexResponse.getIndices()))
+                            : Collections.emptySet();
                     // 2nd get stats request
                     ClientHelper.executeAsyncWithOrigin(client,
                         ClientHelper.DATA_FRAME_ORIGIN,

x-pack/plugin/data-frame/src/test/java/org/elasticsearch/xpack/dataframe/DataFrameSingleNodeTestCase.java

@@ -70,7 +70,7 @@ protected <T> void assertAsync(Consumer<ActionListener<T>> function, T expected,
         }), latch);
 
         function.accept(listener);
-        latch.await(10, TimeUnit.SECONDS);
+        assertTrue("timed out after 20s", latch.await(20, TimeUnit.SECONDS));
     }
 
 }

x-pack/plugin/data-frame/src/test/java/org/elasticsearch/xpack/dataframe/checkpoint/DataFrameTransformCheckpointServiceNodeTests.java

@@ -73,8 +73,8 @@ public class DataFrameTransformCheckpointServiceNodeTests extends DataFrameSingl
 
     private class MockClientForCheckpointing extends NoOpClient {
 
-        private ShardStats[] shardStats;
-        private String[] indices;
+        private volatile ShardStats[] shardStats;
+        private volatile String[] indices;
 
         MockClientForCheckpointing(String testName) {
             super(testName);
@@ -98,6 +98,7 @@ void doExecute(ActionType<Response> action, Request request, ActionListener<Resp
 
             if (request instanceof GetIndexRequest) {
                 // for this test we only need the indices
+                assert(indices != null);
                 final GetIndexResponse indexResponse = new GetIndexResponse(indices, null, null, null, null);
 
                 listener.onResponse((Response) indexResponse);