Skip to content

Commit 75c973f

Browse files
authored
Test fix - GraphExploreResponse HLRC xContent ordering was unreliable(#34473)
xContent ordering is unreliable when derived from map insertions but the parsed objects’ .equals() methods have the sort logic required to prove connections and vertices are correct. Disabled the xContent equivalence checks. Closes #33686
1 parent 2645574 commit 75c973f

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

x-pack/plugin/core/src/test/java/org/elasticsearch/protocol/xpack/graph/GraphExploreResponseTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ protected GraphExploreResponse doParseInstance(XContentParser parser) throws IO
7575
protected boolean supportsUnknownFields() {
7676
return true;
7777
}
78+
79+
@Override
80+
protected boolean assertToXContentEquivalence() {
81+
return false;
82+
}
7883

7984
@Override
8085
protected String[] getShuffleFieldsExceptions() {

x-pack/protocol/src/test/java/org/elasticsearch/protocol/xpack/graph/GraphExploreResponseTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ protected boolean supportsUnknownFields() {
8989
return true;
9090
}
9191

92+
@Override
93+
protected boolean assertToXContentEquivalence() {
94+
return false;
95+
}
96+
9297
@Override
9398
protected String[] getShuffleFieldsExceptions() {
9499
return new String[]{"vertices", "connections"};

0 commit comments

Comments
 (0)