Skip to content

Commit 6e3fe67

Browse files
committed
Remote assertion that relies on all shards being successful
The assertion that if there are buffered aggs at least one incremental reduce phase should have happened doens't hold if there are shard failure. This commit removes this assertion. Relates to #23288
1 parent 0a69c69 commit 6e3fe67

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

core/src/main/java/org/elasticsearch/action/search/SearchPhaseController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,6 @@ private ReducedQueryPhase reducedQueryPhase(List<? extends AtomicArray.Entry<? e
500500
final List<InternalAggregations> aggregationsList;
501501
if (bufferdAggs != null) {
502502
consumeAggs = false;
503-
assert numReducePhases > 1 : "num reduce phases must be > 1 but was: " + numReducePhases;
504503
// we already have results from intermediate reduces and just need to perform the final reduce
505504
assert firstResult.hasAggs() : "firstResult has no aggs but we got non null buffered aggs?";
506505
aggregationsList = bufferdAggs;

0 commit comments

Comments
 (0)