Add timeout param parsing to start request

Author: davidkyle

client/rest-high-level/src/main/java/org/elasticsearch/client/dataframe/StartDataFrameTransformRequest.java

@@ -29,7 +29,6 @@
 public class StartDataFrameTransformRequest implements Validatable {
 
     private final String id;
-    // TODO The REST endpoint does not accept the timeout parameter yet
     private TimeValue timeout;
 
     public StartDataFrameTransformRequest(String id) {

client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/DataFrameTransformDocumentationIT.java

@@ -204,10 +204,6 @@ public void testStartStop() throws IOException, InterruptedException {
             request.setTimeout(TimeValue.timeValueSeconds(20));  // <1>
             // end::start-data-frame-transform-request-options
 
-
-            // TODO null the timeout value until it is supported in the REST api
-            request.setTimeout(null);
-
             // tag::start-data-frame-transform-execute
             StartDataFrameTransformResponse response =
                     client.dataFrame().startDataFrameTransform(

x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/rest/action/RestStartDataFrameTransformAction.java

@@ -6,14 +6,14 @@
 
 package org.elasticsearch.xpack.dataframe.rest.action;
 
+import org.elasticsearch.action.support.master.AcknowledgedRequest;
 import org.elasticsearch.client.node.NodeClient;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestController;
 import org.elasticsearch.rest.RestRequest;
 import org.elasticsearch.rest.action.RestToXContentListener;
 import org.elasticsearch.xpack.core.dataframe.DataFrameField;
-import org.elasticsearch.xpack.core.rollup.RollupField;
 import org.elasticsearch.xpack.core.dataframe.action.StartDataFrameTransformAction;
 
 import java.io.IOException;
@@ -27,9 +27,11 @@ public RestStartDataFrameTransformAction(Settings settings, RestController contr
 
     @Override
     protected RestChannelConsumer prepareRequest(RestRequest restRequest, NodeClient client) throws IOException {
-        String id = restRequest.param(RollupField.ID.getPreferredName());
+        String id = restRequest.param(DataFrameField.ID.getPreferredName());
         StartDataFrameTransformAction.Request request = new StartDataFrameTransformAction.Request(id);
-
+        if (restRequest.hasParam(DataFrameField.TIMEOUT.getPreferredName())) {
+            request.timeout(restRequest.paramAsTime(DataFrameField.TIMEOUT.getPreferredName(), AcknowledgedRequest.DEFAULT_ACK_TIMEOUT));
+        }
         return channel -> client.execute(StartDataFrameTransformAction.INSTANCE, request, new RestToXContentListener<>(channel));
     }
 

x-pack/plugin/src/test/resources/rest-api-spec/api/data_frame.start_data_frame_transform.json

@@ -11,6 +11,13 @@
           "required": true,
           "description": "The id of the transform to start"
         }
+      },
+      "params": {
+        "timeout": {
+          "type": "time",
+          "required": false,
+          "description": "Controls the time to wait for the transform to start"
+        }
       }
     },
     "body": null