Skip to content

Commit 63cc008

Browse files
committed
Add missing entries to conffiles (#35810)
1 parent d49018d commit 63cc008

File tree

4 files changed

+55
-10
lines changed

4 files changed

+55
-10
lines changed

distribution/packages/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,10 @@ Closure commonPackageConfig(String type, boolean oss) {
167167
configurationFile '/etc/elasticsearch/elasticsearch.yml'
168168
configurationFile '/etc/elasticsearch/jvm.options'
169169
configurationFile '/etc/elasticsearch/log4j2.properties'
170+
configurationFile '/etc/elasticsearch/role_mapping.yml'
171+
configurationFile '/etc/elasticsearch/roles.yml'
172+
configurationFile '/etc/elasticsearch/users'
173+
configurationFile '/etc/elasticsearch/users_roles'
170174
into('/etc/elasticsearch') {
171175
dirMode 0750
172176
fileMode 0660

qa/vagrant/src/main/java/org/elasticsearch/packaging/test/DebPreservationTestCase.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,16 @@ public void test20Remove() {
8787
installation.config("log4j2.properties")
8888
);
8989

90+
if (distribution().isDefault()) {
91+
assertPathsExist(
92+
installation.config,
93+
installation.config("role_mapping.yml"),
94+
installation.config("roles.yml"),
95+
installation.config("users"),
96+
installation.config("users_roles")
97+
);
98+
}
99+
90100
// keystore was removed
91101

92102
assertPathsDontExist(

qa/vagrant/src/main/java/org/elasticsearch/packaging/test/RpmPreservationTestCase.java

Lines changed: 33 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,22 @@ public void test30PreserveConfig() {
100100

101101
sh.run("echo foobar | " + installation.executables().elasticsearchKeystore + " add --stdin foo.bar");
102102
Stream.of(
103-
installation.config("elasticsearch.yml"),
104-
installation.config("jvm.options"),
105-
installation.config("log4j2.properties")
106-
).forEach(path -> append(path, "# foo"));
103+
"elasticsearch.yml",
104+
"jvm.options",
105+
"log4j2.properties"
106+
)
107+
.map(each -> installation.config(each))
108+
.forEach(path -> append(path, "# foo"));
109+
if (distribution().isDefault()) {
110+
Stream.of(
111+
"role_mapping.yml",
112+
"roles.yml",
113+
"users",
114+
"users_roles"
115+
)
116+
.map(each -> installation.config(each))
117+
.forEach(path -> append(path, "# foo"));
118+
}
107119

108120
remove(distribution());
109121
assertRemoved(distribution());
@@ -131,11 +143,22 @@ public void test30PreserveConfig() {
131143
"elasticsearch.yml",
132144
"jvm.options",
133145
"log4j2.properties"
134-
).forEach(configFile -> {
135-
final Path original = installation.config(configFile);
136-
final Path saved = installation.config(configFile + ".rpmsave");
137-
assertFalse(original + " should not exist", Files.exists(original));
138-
assertTrue(saved + " should exist", Files.exists(saved));
139-
});
146+
).forEach(this::assertConfFilePreserved);
147+
148+
if (distribution().isDefault()) {
149+
Stream.of(
150+
"role_mapping.yml",
151+
"roles.yml",
152+
"users",
153+
"users_roles"
154+
).forEach(this::assertConfFilePreserved);
155+
}
156+
}
157+
158+
private void assertConfFilePreserved(String configFile) {
159+
final Path original = installation.config(configFile);
160+
final Path saved = installation.config(configFile + ".rpmsave");
161+
assertFalse(original + " should not exist", Files.exists(original));
162+
assertTrue(saved + " should exist", Files.exists(saved));
140163
}
141164
}

qa/vagrant/src/main/java/org/elasticsearch/packaging/util/Distribution.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,14 @@ public String filename(String version) {
4343
return flavor.name + "-" + version + packaging.extension;
4444
}
4545

46+
public boolean isDefault() {
47+
return flavor.equals(Flavor.DEFAULT);
48+
}
49+
50+
public boolean isOSS() {
51+
return flavor.equals(Flavor.OSS);
52+
}
53+
4654
public enum Packaging {
4755

4856
TAR(".tar.gz", Platforms.LINUX),

0 commit comments

Comments
 (0)