Skip to content

Commit 3e621a8

Browse files
author
David Roberts
authored
[ML-DataFrame] Adjust BWC tests following backport (#45325)
This change adjusts the changes of #45276 to account for the backport to the 7.x branch in #45324.
1 parent c57f6be commit 3e621a8

File tree

3 files changed

+12
-72
lines changed

3 files changed

+12
-72
lines changed

x-pack/qa/rolling-upgrade/src/test/resources/rest-api-spec/test/mixed_cluster/80_data_frame_jobs_crud.yml

Lines changed: 12 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
---
22
"Test put batch data frame transforms on mixed cluster":
3-
- skip:
4-
version: "7.4.0 - "
5-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
63
- do:
74
cluster.health:
85
index: "dataframe-transform-airline-data"
@@ -32,10 +29,7 @@
3229
transform_id: "mixed-simple-transform"
3330
- match: { count: 1 }
3431
- match: { transforms.0.id: "mixed-simple-transform" }
35-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
36-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
37-
# TODO: uncomment this assertion in master
38-
#- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
32+
- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
3933

4034
- do:
4135
data_frame.stop_data_frame_transform:
@@ -48,10 +42,7 @@
4842
transform_id: "mixed-simple-transform"
4943
- match: { count: 1 }
5044
- match: { transforms.0.id: "mixed-simple-transform" }
51-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
52-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
53-
# TODO: uncomment this assertion in master
54-
#- match: { transforms.0.state: "stopped" }
45+
- match: { transforms.0.state: "stopped" }
5546

5647
- do:
5748
data_frame.put_data_frame_transform:
@@ -98,10 +89,7 @@
9889
transform_id: "mixed-complex-transform"
9990
- match: { count: 1 }
10091
- match: { transforms.0.id: "mixed-complex-transform" }
101-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
102-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
103-
# TODO: uncomment this assertion in master
104-
#- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
92+
- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
10593

10694
- do:
10795
data_frame.stop_data_frame_transform:
@@ -114,16 +102,10 @@
114102
transform_id: "mixed-complex-transform"
115103
- match: { count: 1 }
116104
- match: { transforms.0.id: "mixed-complex-transform" }
117-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
118-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
119-
# TODO: uncomment this assertion in master
120-
#- match: { transforms.0.state: "stopped" }
105+
- match: { transforms.0.state: "stopped" }
121106

122107
---
123108
"Test put continuous data frame transform on mixed cluster":
124-
- skip:
125-
version: "7.4.0 - "
126-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
127109
- do:
128110
cluster.health:
129111
index: "dataframe-transform-airline-data-cont"
@@ -169,10 +151,7 @@
169151
transform_id: "mixed-simple-continuous-transform"
170152
- match: { count: 1 }
171153
- match: { transforms.0.id: "mixed-simple-continuous-transform" }
172-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
173-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
174-
# TODO: uncomment this assertion in master
175-
#- match: { transforms.0.state: "/started|indexing/" }
154+
- match: { transforms.0.state: "/started|indexing/" }
176155

177156
- do:
178157
data_frame.stop_data_frame_transform:
@@ -185,16 +164,10 @@
185164
transform_id: "mixed-simple-continuous-transform"
186165
- match: { count: 1 }
187166
- match: { transforms.0.id: "mixed-simple-continuous-transform" }
188-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
189-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
190-
# TODO: uncomment this assertion in master
191-
#- match: { transforms.0.state: "stopped" }
167+
- match: { transforms.0.state: "stopped" }
192168

193169
---
194170
"Test GET, start, and stop old cluster batch transforms":
195-
- skip:
196-
version: "7.4.0 - "
197-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
198171
- do:
199172
cluster.health:
200173
index: "dataframe-transform-airline-data"
@@ -220,10 +193,7 @@
220193
transform_id: "old-simple-transform"
221194
- match: { count: 1 }
222195
- match: { transforms.0.id: "old-simple-transform" }
223-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
224-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
225-
# TODO: uncomment this assertion in master
226-
#- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
196+
- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
227197

228198
- do:
229199
data_frame.stop_data_frame_transform:
@@ -235,10 +205,7 @@
235205
transform_id: "old-simple-transform"
236206
- match: { count: 1 }
237207
- match: { transforms.0.id: "old-simple-transform" }
238-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
239-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
240-
# TODO: uncomment this assertion in master
241-
#- match: { transforms.0.state: "stopped" }
208+
- match: { transforms.0.state: "stopped" }
242209

243210
- do:
244211
data_frame.get_data_frame_transform:
@@ -262,10 +229,7 @@
262229
transform_id: "old-complex-transform"
263230
- match: { count: 1 }
264231
- match: { transforms.0.id: "old-complex-transform" }
265-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
266-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
267-
# TODO: uncomment this assertion in master
268-
#- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
232+
- match: { transforms.0.state: "/started|indexing|stopping|stopped/" }
269233

270234
- do:
271235
data_frame.stop_data_frame_transform:
@@ -277,16 +241,10 @@
277241
transform_id: "old-complex-transform"
278242
- match: { count: 1 }
279243
- match: { transforms.0.id: "old-complex-transform" }
280-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
281-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
282-
# TODO: uncomment this assertion in master
283-
#- match: { transforms.0.state: "stopped" }
244+
- match: { transforms.0.state: "stopped" }
284245

285246
---
286247
"Test GET, stop, start, old continuous transforms":
287-
- skip:
288-
version: "7.4.0 - "
289-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
290248
- do:
291249
cluster.health:
292250
index: "dataframe-transform-airline-data-cont"
@@ -312,10 +270,7 @@
312270
transform_id: "old-simple-continuous-transform"
313271
- match: { count: 1 }
314272
- match: { transforms.0.id: "old-simple-continuous-transform" }
315-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
316-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
317-
# TODO: uncomment this assertion in master
318-
#- match: { transforms.0.state: "/started|indexing/" }
273+
- match: { transforms.0.state: "/started|indexing/" }
319274

320275
- do:
321276
data_frame.stop_data_frame_transform:
@@ -328,7 +283,4 @@
328283
transform_id: "old-simple-continuous-transform"
329284
- match: { count: 1 }
330285
- match: { transforms.0.id: "old-simple-continuous-transform" }
331-
# Since we are breaking the stats format between 7.3 and 7.4 (allowed because we're beta) we cannot
332-
# assert on state in the mixed cluster as it could be state at the top level or state.task_state
333-
# TODO: uncomment this assertion in master
334-
#- match: { transforms.0.state: "stopped" }
286+
- match: { transforms.0.state: "stopped" }

x-pack/qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/80_data_frame_jobs_crud.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
---
22
"Test put batch data frame transforms on old cluster":
3-
- skip:
4-
version: "7.4.0 - "
5-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
63
- do:
74
indices.create:
85
index: dataframe-transform-airline-data
@@ -139,9 +136,6 @@
139136

140137
---
141138
"Test put continuous data frame transform on old cluster":
142-
- skip:
143-
version: "7.4.0 - "
144-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
145139
- do:
146140
indices.create:
147141
index: dataframe-transform-airline-data-cont

x-pack/qa/rolling-upgrade/src/test/resources/rest-api-spec/test/upgraded_cluster/80_data_frame_jobs_crud.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ setup:
77
timeout: 70s
88
---
99
"Get start, stop, and delete old and mixed cluster batch data frame transforms":
10-
- skip:
11-
version: "7.4.0 - "
12-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
1310
# Simple and complex OLD transforms
1411
- do:
1512
data_frame.get_data_frame_transform:
@@ -165,9 +162,6 @@ setup:
165162

166163
---
167164
"Test GET, stop, delete, old and mixed continuous transforms":
168-
- skip:
169-
version: "7.4.0 - "
170-
reason: waiting backport of https://github.com/elastic/elasticsearch/pull/45276
171165
- do:
172166
data_frame.get_data_frame_transform:
173167
transform_id: "old-simple-continuous-transform"

0 commit comments

Comments
 (0)