Skip to content

Commit 3a2339f

Browse files
author
Hendrik Muhs
authored
[Transform] add debug log for configuration index (#49484)
add debug log for transform creation and disallow partial results for retrieval
1 parent f836754 commit 3a2339f

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportDeleteTransformAction.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
*/
66
package org.elasticsearch.xpack.transform.action;
77

8+
import org.apache.logging.log4j.LogManager;
9+
import org.apache.logging.log4j.Logger;
810
import org.elasticsearch.ElasticsearchStatusException;
911
import org.elasticsearch.action.ActionListener;
1012
import org.elasticsearch.action.support.ActionFilters;
@@ -37,6 +39,8 @@
3739

3840
public class TransportDeleteTransformAction extends TransportMasterNodeAction<Request, AcknowledgedResponse> {
3941

42+
private static final Logger logger = LogManager.getLogger(TransportDeleteTransformAction.class);
43+
4044
private final TransformConfigManager transformConfigManager;
4145
private final TransformAuditor auditor;
4246
private final Client client;
@@ -102,6 +106,7 @@ protected void masterOperation(Task task, Request request, ClusterState state, A
102106
} else {
103107
ActionListener<Void> stopTransformActionListener = ActionListener.wrap(
104108
stopResponse -> transformConfigManager.deleteTransform(request.getId(), ActionListener.wrap(r -> {
109+
logger.debug("[{}] deleted transform", request.getId());
105110
auditor.info(request.getId(), "Deleted transform.");
106111
listener.onResponse(new AcknowledgedResponse(r));
107112
}, listener::onFailure)),

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportPutTransformAction.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
package org.elasticsearch.xpack.transform.action;
88

9+
import org.apache.logging.log4j.LogManager;
10+
import org.apache.logging.log4j.Logger;
911
import org.elasticsearch.ElasticsearchStatusException;
1012
import org.elasticsearch.ResourceAlreadyExistsException;
1113
import org.elasticsearch.Version;
@@ -61,6 +63,8 @@
6163

6264
public class TransportPutTransformAction extends TransportMasterNodeAction<Request, AcknowledgedResponse> {
6365

66+
private static final Logger logger = LogManager.getLogger(TransportPutTransformAction.class);
67+
6468
private final XPackLicenseState licenseState;
6569
private final Client client;
6670
private final TransformConfigManager transformConfigManager;
@@ -263,6 +267,7 @@ private void putTransform(Request request, ActionListener<AcknowledgedResponse>
263267

264268
// <3> Return to the listener
265269
ActionListener<Boolean> putTransformConfigurationListener = ActionListener.wrap(putTransformConfigurationResult -> {
270+
logger.debug("[{}] created transform", config.getId());
266271
auditor.info(config.getId(), "Created transform.");
267272
listener.onResponse(new AcknowledgedResponse(true));
268273
}, listener::onFailure);

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/IndexBasedTransformConfigManager.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ public void getTransformCheckpoint(String transformId, long checkpoint, ActionLi
262262
// use sort to get the last
263263
.addSort("_index", SortOrder.DESC)
264264
.setSize(1)
265+
.setAllowPartialSearchResults(false)
265266
.request();
266267

267268
executeAsyncWithOrigin(
@@ -293,6 +294,7 @@ public void getTransformConfiguration(String transformId, ActionListener<Transfo
293294
// use sort to get the last
294295
.addSort("_index", SortOrder.DESC)
295296
.setSize(1)
297+
.setAllowPartialSearchResults(false)
296298
.request();
297299

298300
executeAsyncWithOrigin(
@@ -327,6 +329,7 @@ public void getTransformConfigurationForUpdate(
327329
// use sort to get the last
328330
.addSort("_index", SortOrder.DESC)
329331
.setSize(1)
332+
.setAllowPartialSearchResults(false)
330333
.seqNoAndPrimaryTerm(true)
331334
.request();
332335

@@ -506,6 +509,7 @@ public void getTransformStoredDoc(
506509
// use sort to get the last
507510
.addSort("_index", SortOrder.DESC)
508511
.setSize(1)
512+
.setAllowPartialSearchResults(false)
509513
.seqNoAndPrimaryTerm(true)
510514
.request();
511515

0 commit comments

Comments
 (0)