Enable compiler warnings in xpack core plugin project (#66899)

Co-authored-by: Elastic Machine <[email protected]>

Author: 2 people

server/src/main/java/org/elasticsearch/common/util/CollectionUtils.java

@@ -284,6 +284,8 @@ public static <E> ArrayList<E> iterableAsArrayList(Iterable<? extends E> element
         }
     }
 
+    @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <E> ArrayList<E> arrayAsArrayList(E... elements) {
         if (elements == null) {
             throw new NullPointerException("elements");

test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java

@@ -762,11 +762,15 @@ public static int randomInt(int max) {
     }
 
     /** Pick a random object from the given array. The array must not be empty. */
+    @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <T> T randomFrom(T... array) {
         return randomFrom(random(), array);
     }
 
     /** Pick a random object from the given array. The array must not be empty. */
+    @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <T> T randomFrom(Random random, T... array) {
         return RandomPicks.randomFrom(random, array);
     }

x-pack/plugin/core/build.gradle

@@ -106,9 +106,6 @@ tasks.named('forbiddenApisMain').configure {
   signaturesFiles += files('forbidden/hasher-signatures.txt')
 }
 
-tasks.withType(JavaCompile).configureEach {
-  options.compilerArgs << "-Xlint:-rawtypes,-unchecked"
-}
 
 // make LicenseSigner available for testing signed licenses
 sourceSets.test.resources {

x-pack/plugin/core/src/internalClusterTest/java/org/elasticsearch/xpack/core/search/PointInTimeIT.java

@@ -427,6 +427,7 @@ public void testPITTiebreak() throws Exception {
         }
     }
 
+    @SuppressWarnings({"rawtypes","unchecked"})
     private void assertPagination(PointInTimeBuilder pit, int expectedNumDocs, int size, SortBuilder<?>... sorts) throws Exception {
         Set<String> seen = new HashSet<>();
         SearchRequestBuilder builder = client().prepareSearch()

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/action/AbstractGetResourcesResponse.java

@@ -71,7 +71,7 @@ public boolean equals(Object obj) {
         if (obj instanceof AbstractGetResourcesResponse == false) {
             return false;
         }
-        AbstractGetResourcesResponse other = (AbstractGetResourcesResponse) obj;
+        AbstractGetResourcesResponse<?> other = (AbstractGetResourcesResponse<?>) obj;
         return Objects.equals(resources, other.resources);
     }
 

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/EvaluateDataFrameAction.java

@@ -54,6 +54,7 @@ public static class Request extends ActionRequest implements ToXContentObject {
         private static final ParseField QUERY = new ParseField("query");
         private static final ParseField EVALUATION = new ParseField("evaluation");
 
+        @SuppressWarnings({ "unchecked"})
         private static final ConstructingObjectParser<Request, Void> PARSER = new ConstructingObjectParser<>(
             NAME,
             a -> new Request((List<String>) a[0], (QueryProvider) a[1], (Evaluation) a[2]));

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/ExplainDataFrameAnalyticsAction.java

@@ -37,6 +37,7 @@ public static class Response extends ActionResponse implements ToXContentObject
         public static final ParseField FIELD_SELECTION = new ParseField("field_selection");
         public static final ParseField MEMORY_ESTIMATION = new ParseField("memory_estimation");
 
+        @SuppressWarnings({ "unchecked"})
         static final ConstructingObjectParser<Response, Void> PARSER =
             new ConstructingObjectParser<>(
                 TYPE.getPreferredName(),

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsSource.java

@@ -44,6 +44,7 @@ public class DataFrameAnalyticsSource implements Writeable, ToXContentObject {
     public static final ParseField QUERY = new ParseField("query");
     public static final ParseField _SOURCE = new ParseField("_source");
 
+    @SuppressWarnings({ "unchecked"})
     public static ConstructingObjectParser<DataFrameAnalyticsSource, Void> createParser(boolean ignoreUnknownFields) {
         ConstructingObjectParser<DataFrameAnalyticsSource, Void> parser = new ConstructingObjectParser<>("data_frame_analytics_source",
             ignoreUnknownFields, a -> new DataFrameAnalyticsSource(

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/outlierdetection/ConfusionMatrix.java

@@ -28,6 +28,7 @@ public class ConfusionMatrix extends AbstractConfusionMatrixMetric {
 
     public static final ParseField NAME = new ParseField("confusion_matrix");
 
+    @SuppressWarnings("unchecked")
     private static final ConstructingObjectParser<ConfusionMatrix, Void> PARSER = new ConstructingObjectParser<>(NAME.getPreferredName(),
         a -> new ConfusionMatrix((List<Double>) a[0]));
 

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/outlierdetection/OutlierDetection.java

@@ -38,6 +38,7 @@ public class OutlierDetection implements Evaluation {
 
     private static final ParseField METRICS = new ParseField("metrics");
 
+    @SuppressWarnings("unchecked")
     public static final ConstructingObjectParser<OutlierDetection, Void> PARSER = new ConstructingObjectParser<>(
         NAME.getPreferredName(), a -> new OutlierDetection((String) a[0], (String) a[1], (List<EvaluationMetric>) a[2]));