Skip to content

Commit 345042f

Browse files
committed
Use latest rather than earliest record timestamp when calculating exponential average
1 parent 2b5d2df commit 345042f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/persistence/TimingStatsReporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public TimingStats getCurrentTimingStats() {
3838

3939
public void reportBucket(Bucket bucket) {
4040
currentTimingStats.updateStats(bucket.getProcessingTimeMs());
41-
currentTimingStats.setLatestRecordTimestamp(bucket.getTimestamp().toInstant());
41+
currentTimingStats.setLatestRecordTimestamp(bucket.getTimestamp().toInstant().plusSeconds(bucket.getBucketSpan()));
4242
if (differSignificantly(currentTimingStats, persistedTimingStats)) {
4343
flush();
4444
}

x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/persistence/TimingStatsReporterTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
public class TimingStatsReporterTests extends ESTestCase {
2727

2828
private static final String JOB_ID = "my-job-id";
29-
private static final long BUCKET_SPAN = 10;
29+
private static final long BUCKET_SPAN_SEC = 60;
3030
private static Instant TIMESTAMP = Instant.ofEpochMilli(1000000000);
3131

3232
private JobResultsPersister.Builder bulkResultsPersister;
@@ -160,7 +160,7 @@ private static TimingStats createTimingStats(
160160
@Nullable Double exponentialAvgBucketProcessingTimeMs,
161161
double incrementalBucketProcessingTimeMs) {
162162
ExponentialAverageCalculationContext context =
163-
new ExponentialAverageCalculationContext(incrementalBucketProcessingTimeMs, TIMESTAMP, null);
163+
new ExponentialAverageCalculationContext(incrementalBucketProcessingTimeMs, TIMESTAMP.plusSeconds(BUCKET_SPAN_SEC), null);
164164
return new TimingStats(
165165
jobId,
166166
bucketCount,
@@ -172,7 +172,7 @@ private static TimingStats createTimingStats(
172172
}
173173

174174
private static Bucket createBucket(long processingTimeMs) {
175-
Bucket bucket = new Bucket(JOB_ID, Date.from(TIMESTAMP), BUCKET_SPAN);
175+
Bucket bucket = new Bucket(JOB_ID, Date.from(TIMESTAMP), BUCKET_SPAN_SEC);
176176
bucket.setProcessingTimeMs(processingTimeMs);
177177
return bucket;
178178
}

0 commit comments

Comments
 (0)