Make Job.setDeleting package private and fix logging error

dimitris-athanasiou · dimitris-athanasiou · commit 2cfddfcb9b52 · 2018-09-27T16:24:27.000+03:00
diff --git a/client/rest-high-level/src/main/java/org/elasticsearch/client/ml/job/config/Job.java b/client/rest-high-level/src/main/java/org/elasticsearch/client/ml/job/config/Job.java
@@ -573,7 +573,7 @@ public Builder setResultsIndexName(String resultsIndexName) {
             return this;
         }
 
-        public Builder setDeleting(Boolean deleting) {
+        Builder setDeleting(Boolean deleting) {
             this.deleting = deleting;
             return this;
         }
diff --git a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportDeleteJobAction.java b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportDeleteJobAction.java
@@ -182,7 +182,7 @@ private void notifyListeners(String jobId, @Nullable AcknowledgedResponse ack, @
         synchronized (listenersByJobId) {
             List<ActionListener<AcknowledgedResponse>> listeners = listenersByJobId.remove(jobId);
             if (listeners == null) {
-                logger.error("[{}] No deletion job listeners could be found");
+                logger.error("[{}] No deletion job listeners could be found", jobId);
                 return;
             }
             for (ActionListener<AcknowledgedResponse> listener : listeners) {

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ public Builder setResultsIndexName(String resultsIndexName) {`
`573`	`573`	`return this;`
`574`	`574`	`}`
`575`	`575`
`576`		`- public Builder setDeleting(Boolean deleting) {`
	`576`	`+ Builder setDeleting(Boolean deleting) {`
`577`	`577`	`this.deleting = deleting;`
`578`	`578`	`return this;`
`579`	`579`	`}`
Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ private void notifyListeners(String jobId, @Nullable AcknowledgedResponse ack, @`
`182`	`182`	`synchronized (listenersByJobId) {`
`183`	`183`	`List<ActionListener<AcknowledgedResponse>> listeners = listenersByJobId.remove(jobId);`
`184`	`184`	`if (listeners == null) {`
`185`		`- logger.error("[{}] No deletion job listeners could be found");`
	`185`	`+ logger.error("[{}] No deletion job listeners could be found", jobId);`
`186`	`186`	`return;`
`187`	`187`	`}`
`188`	`188`	`for (ActionListener<AcknowledgedResponse> listener : listeners) {`