[7.x] Fix mapping error to indicate values field (#74132) (#74137)

* Fix mapping error to indicate values field (#74132)

The error message erroneously mentions the count field being out of order. It should instead mention the values field

Author: benwtrent

x-pack/plugin/analytics/src/main/java/org/elasticsearch/xpack/analytics/mapper/HistogramFieldMapper.java

@@ -260,7 +260,7 @@ public void parse(ParseContext context) throws IOException {
                         if (val < previousVal) {
                             // values must be in increasing order
                             throw new MapperParsingException("error parsing field ["
-                                + name() + "], ["+ COUNTS_FIELD + "] values must be in increasing order, got [" + val +
+                                + name() + "], ["+ VALUES_FIELD + "] values must be in increasing order, got [" + val +
                                 "] but previous value was [" + previousVal +"]");
                         }
                         values.add(val);

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/analytics/histogram.yml

@@ -20,7 +20,13 @@ setup:
           - '{"latency": {"values" : [0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6]}}'
           - '{"index": {}}'
           - '{"latency": {"values" : [0, 0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 2, 5, 10, 1, 8]}}'
-
+---
+"Histogram requires values in increasing order":
+  - do:
+      catch: /error parsing field \[latency\], \[values\] values must be in increasing order/
+      index:
+        index: test
+        body: {"latency": {"values" : [1.0, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6]}}
 ---
 "Histogram Aggregations":