[TEST] Fix random RoleDescriptor compat with v6.7 (#82242) (#82363)

allowRestrictedIndices was only added in ES6.7 (see #37577). For
randomised testing we should not set that field if we are generating a
role descriptor that will be serialized into an older version stream.
Resolves: #82216

Author: tvernum

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/RoleDescriptorTests.java

@@ -121,7 +121,7 @@ public void testToString() {
     }
 
     public void testToXContentRoundtrip() throws Exception {
-        final RoleDescriptor descriptor = randomRoleDescriptor();
+        final RoleDescriptor descriptor = randomRoleDescriptor(Version.CURRENT);
         final XContentType xContentType = randomFrom(XContentType.values());
         final BytesReference xContentValue = toShuffledXContent(descriptor, xContentType, ToXContent.EMPTY_PARAMS, false);
         final RoleDescriptor parsed = RoleDescriptor.parse(descriptor.getName(), xContentValue, false, xContentType);
@@ -234,7 +234,7 @@ public void testSerialization() throws Exception {
         BytesStreamOutput output = new BytesStreamOutput();
         output.setVersion(version);
 
-        final RoleDescriptor descriptor = randomRoleDescriptor();
+        final RoleDescriptor descriptor = randomRoleDescriptor(version);
         descriptor.writeTo(output);
         final NamedWriteableRegistry registry = new NamedWriteableRegistry(new XPackClientPlugin(Settings.EMPTY).getNamedWriteables());
         StreamInput streamInput = new NamedWriteableAwareStreamInput(
@@ -388,13 +388,16 @@ public void testIsEmpty() {
         }
     }
 
-    private RoleDescriptor randomRoleDescriptor() {
+    /**
+     * @param compatibleVersion Return a role descriptor that is compatible with the features that existed in this version of Elasticsearch
+     */
+    private RoleDescriptor randomRoleDescriptor(Version compatibleVersion) {
         final RoleDescriptor.IndicesPrivileges[] indexPrivileges = new RoleDescriptor.IndicesPrivileges[randomIntBetween(0, 3)];
         for (int i = 0; i < indexPrivileges.length; i++) {
             final RoleDescriptor.IndicesPrivileges.Builder builder = RoleDescriptor.IndicesPrivileges.builder()
                 .privileges(randomSubsetOf(randomIntBetween(1, 4), IndexPrivilege.names()))
                 .indices(generateRandomStringArray(5, randomIntBetween(3, 9), false, false))
-                .allowRestrictedIndices(randomBoolean());
+                .allowRestrictedIndices(compatibleVersion.onOrAfter(Version.V_6_7_0) && randomBoolean());
             if (randomBoolean()) {
                 builder.query(
                     randomBoolean()