Skip to content

Commit 1a8bdd5

Browse files
committed
Merge branch 'master' into lock-checkindex
2 parents cf6802f + 43ff38c commit 1a8bdd5

File tree

277 files changed

+7894
-1520
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

277 files changed

+7894
-1520
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ subprojects {
196196
"org.elasticsearch.plugin:parent-join-client:${version}": ':modules:parent-join',
197197
"org.elasticsearch.plugin:aggs-matrix-stats-client:${version}": ':modules:aggs-matrix-stats',
198198
"org.elasticsearch.plugin:percolator-client:${version}": ':modules:percolator',
199+
"org.elasticsearch.plugin:rank-eval-client:${version}": ':modules:rank-eval',
199200
]
200201

201202
for (final Version version : versionCollection.versionsIndexCompatibleWithCurrent) {

client/rest-high-level/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ dependencies {
3939
compile "org.elasticsearch.client:elasticsearch-rest-client:${version}"
4040
compile "org.elasticsearch.plugin:parent-join-client:${version}"
4141
compile "org.elasticsearch.plugin:aggs-matrix-stats-client:${version}"
42+
compile "org.elasticsearch.plugin:rank-eval-client:${version}"
4243

4344
testCompile "org.elasticsearch.client:test:${version}"
4445
testCompile "org.elasticsearch.test:framework:${version}"
@@ -60,4 +61,4 @@ forbiddenApisMain {
6061
// specified
6162
signaturesURLs += [PrecommitTasks.getResource('/forbidden/http-signatures.txt')]
6263
signaturesURLs += [file('src/main/resources/forbidden/rest-high-level-signatures.txt').toURI().toURL()]
63-
}
64+
}

client/rest-high-level/src/test/java/org/elasticsearch/client/RestHighLevelClientTests.java

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,6 @@
2121

2222
import com.fasterxml.jackson.core.JsonParseException;
2323

24-
import org.elasticsearch.Build;
25-
import org.elasticsearch.ElasticsearchException;
26-
import org.elasticsearch.Version;
27-
import org.elasticsearch.action.ActionListener;
28-
import org.elasticsearch.action.ActionRequest;
29-
import org.elasticsearch.action.ActionRequestValidationException;
30-
import org.elasticsearch.action.main.MainRequest;
31-
import org.elasticsearch.action.main.MainResponse;
32-
import org.elasticsearch.action.search.ClearScrollRequest;
33-
import org.elasticsearch.action.search.ClearScrollResponse;
34-
import org.elasticsearch.action.search.SearchResponse;
35-
import org.elasticsearch.action.search.SearchResponseSections;
36-
import org.elasticsearch.action.search.SearchScrollRequest;
37-
import org.elasticsearch.action.search.ShardSearchFailure;
3824
import org.apache.http.Header;
3925
import org.apache.http.HttpEntity;
4026
import org.apache.http.HttpHost;
@@ -49,6 +35,20 @@
4935
import org.apache.http.message.BasicRequestLine;
5036
import org.apache.http.message.BasicStatusLine;
5137
import org.apache.http.nio.entity.NStringEntity;
38+
import org.elasticsearch.Build;
39+
import org.elasticsearch.ElasticsearchException;
40+
import org.elasticsearch.Version;
41+
import org.elasticsearch.action.ActionListener;
42+
import org.elasticsearch.action.ActionRequest;
43+
import org.elasticsearch.action.ActionRequestValidationException;
44+
import org.elasticsearch.action.main.MainRequest;
45+
import org.elasticsearch.action.main.MainResponse;
46+
import org.elasticsearch.action.search.ClearScrollRequest;
47+
import org.elasticsearch.action.search.ClearScrollResponse;
48+
import org.elasticsearch.action.search.SearchResponse;
49+
import org.elasticsearch.action.search.SearchResponseSections;
50+
import org.elasticsearch.action.search.SearchScrollRequest;
51+
import org.elasticsearch.action.search.ShardSearchFailure;
5252
import org.elasticsearch.cluster.ClusterName;
5353
import org.elasticsearch.common.CheckedFunction;
5454
import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -57,6 +57,10 @@
5757
import org.elasticsearch.common.xcontent.XContentParser;
5858
import org.elasticsearch.common.xcontent.cbor.CborXContent;
5959
import org.elasticsearch.common.xcontent.smile.SmileXContent;
60+
import org.elasticsearch.index.rankeval.DiscountedCumulativeGain;
61+
import org.elasticsearch.index.rankeval.EvaluationMetric;
62+
import org.elasticsearch.index.rankeval.MeanReciprocalRank;
63+
import org.elasticsearch.index.rankeval.PrecisionAtK;
6064
import org.elasticsearch.join.aggregations.ChildrenAggregationBuilder;
6165
import org.elasticsearch.rest.RestStatus;
6266
import org.elasticsearch.search.SearchHits;
@@ -648,7 +652,7 @@ public void testDefaultNamedXContents() {
648652

649653
public void testProvidedNamedXContents() {
650654
List<NamedXContentRegistry.Entry> namedXContents = RestHighLevelClient.getProvidedNamedXContents();
651-
assertEquals(2, namedXContents.size());
655+
assertEquals(5, namedXContents.size());
652656
Map<Class<?>, Integer> categories = new HashMap<>();
653657
List<String> names = new ArrayList<>();
654658
for (NamedXContentRegistry.Entry namedXContent : namedXContents) {
@@ -658,10 +662,14 @@ public void testProvidedNamedXContents() {
658662
categories.put(namedXContent.categoryClass, counter + 1);
659663
}
660664
}
661-
assertEquals(1, categories.size());
665+
assertEquals(2, categories.size());
662666
assertEquals(Integer.valueOf(2), categories.get(Aggregation.class));
663667
assertTrue(names.contains(ChildrenAggregationBuilder.NAME));
664668
assertTrue(names.contains(MatrixStatsAggregationBuilder.NAME));
669+
assertEquals(Integer.valueOf(3), categories.get(EvaluationMetric.class));
670+
assertTrue(names.contains(PrecisionAtK.NAME));
671+
assertTrue(names.contains(DiscountedCumulativeGain.NAME));
672+
assertTrue(names.contains(MeanReciprocalRank.NAME));
665673
}
666674

667675
private static class TrackingActionListener implements ActionListener<Integer> {

client/rest/src/main/java/org/elasticsearch/client/RestClientBuilder.java

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@
2828
import org.apache.http.impl.nio.client.HttpAsyncClientBuilder;
2929
import org.apache.http.nio.conn.SchemeIOSessionStrategy;
3030

31+
import javax.net.ssl.SSLContext;
3132
import java.security.AccessController;
33+
import java.security.NoSuchAlgorithmException;
3234
import java.security.PrivilegedAction;
3335
import java.util.Objects;
3436

@@ -200,20 +202,25 @@ private CloseableHttpAsyncClient createHttpClient() {
200202
requestConfigBuilder = requestConfigCallback.customizeRequestConfig(requestConfigBuilder);
201203
}
202204

203-
HttpAsyncClientBuilder httpClientBuilder = HttpAsyncClientBuilder.create().setDefaultRequestConfig(requestConfigBuilder.build())
205+
try {
206+
HttpAsyncClientBuilder httpClientBuilder = HttpAsyncClientBuilder.create().setDefaultRequestConfig(requestConfigBuilder.build())
204207
//default settings for connection pooling may be too constraining
205-
.setMaxConnPerRoute(DEFAULT_MAX_CONN_PER_ROUTE).setMaxConnTotal(DEFAULT_MAX_CONN_TOTAL).useSystemProperties();
206-
if (httpClientConfigCallback != null) {
207-
httpClientBuilder = httpClientConfigCallback.customizeHttpClient(httpClientBuilder);
208-
}
209-
210-
final HttpAsyncClientBuilder finalBuilder = httpClientBuilder;
211-
return AccessController.doPrivileged(new PrivilegedAction<CloseableHttpAsyncClient>() {
212-
@Override
213-
public CloseableHttpAsyncClient run() {
214-
return finalBuilder.build();
208+
.setMaxConnPerRoute(DEFAULT_MAX_CONN_PER_ROUTE).setMaxConnTotal(DEFAULT_MAX_CONN_TOTAL)
209+
.setSSLContext(SSLContext.getDefault());
210+
if (httpClientConfigCallback != null) {
211+
httpClientBuilder = httpClientConfigCallback.customizeHttpClient(httpClientBuilder);
215212
}
216-
});
213+
214+
final HttpAsyncClientBuilder finalBuilder = httpClientBuilder;
215+
return AccessController.doPrivileged(new PrivilegedAction<CloseableHttpAsyncClient>() {
216+
@Override
217+
public CloseableHttpAsyncClient run() {
218+
return finalBuilder.build();
219+
}
220+
});
221+
} catch (NoSuchAlgorithmException e) {
222+
throw new IllegalStateException("could not create the default ssl context", e);
223+
}
217224
}
218225

219226
/**

client/transport/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ dependencies {
3232
compile "org.elasticsearch.plugin:lang-mustache-client:${version}"
3333
compile "org.elasticsearch.plugin:percolator-client:${version}"
3434
compile "org.elasticsearch.plugin:parent-join-client:${version}"
35+
compile "org.elasticsearch.plugin:rank-eval-client:${version}"
3536
testCompile "com.carrotsearch.randomizedtesting:randomizedtesting-runner:${versions.randomizedrunner}"
3637
testCompile "junit:junit:${versions.junit}"
3738
testCompile "org.hamcrest:hamcrest-all:${versions.hamcrest}"
@@ -54,4 +55,4 @@ namingConventions {
5455
testClass = 'com.carrotsearch.randomizedtesting.RandomizedTest'
5556
//we don't have integration tests
5657
skipIntegTestInDisguise = true
57-
}
58+
}

core/src/main/java/org/elasticsearch/action/search/ExpandSearchPhase.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ private SearchSourceBuilder buildExpandSearchSourceBuilder(InnerHitBuilder optio
165165
}
166166
groupSource.explain(options.isExplain());
167167
groupSource.trackScores(options.isTrackScores());
168+
groupSource.version(options.isVersion());
168169
return groupSource;
169170
}
170171
}

core/src/main/java/org/elasticsearch/action/support/single/shard/SingleShardOperationRequestBuilder.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,4 @@ public final RequestBuilder setIndex(String index) {
3939
request.index(index);
4040
return (RequestBuilder) this;
4141
}
42-
43-
/**
44-
* Controls if the operation will be executed on a separate thread when executed locally.
45-
*/
46-
@SuppressWarnings("unchecked")
47-
public final RequestBuilder setOperationThreaded(boolean threadedOperation) {
48-
request.operationThreaded(threadedOperation);
49-
return (RequestBuilder) this;
50-
}
5142
}

core/src/main/java/org/elasticsearch/action/support/single/shard/SingleShardRequest.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -94,22 +94,6 @@ public IndicesOptions indicesOptions() {
9494
return INDICES_OPTIONS;
9595
}
9696

97-
/**
98-
* Controls if the operation will be executed on a separate thread when executed locally.
99-
*/
100-
public boolean operationThreaded() {
101-
return threadedOperation;
102-
}
103-
104-
/**
105-
* Controls if the operation will be executed on a separate thread when executed locally.
106-
*/
107-
@SuppressWarnings("unchecked")
108-
public final Request operationThreaded(boolean threadedOperation) {
109-
this.threadedOperation = threadedOperation;
110-
return (Request) this;
111-
}
112-
11397
@Override
11498
public void readFrom(StreamInput in) throws IOException {
11599
super.readFrom(in);

core/src/main/java/org/elasticsearch/action/support/single/shard/TransportSingleShardAction.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ private class TransportHandler implements TransportRequestHandler<Request> {
277277
@Override
278278
public void messageReceived(Request request, final TransportChannel channel) throws Exception {
279279
// if we have a local operation, execute it on a thread since we don't spawn
280-
request.operationThreaded(true);
281280
execute(request, new ActionListener<Response>() {
282281
@Override
283282
public void onResponse(Response result) {

core/src/main/java/org/elasticsearch/cluster/metadata/MetaDataMappingService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,9 @@ private ClusterState applyRequest(ClusterState currentState, PutMappingClusterSt
293293
}
294294
assert mappingType != null;
295295

296-
if (!MapperService.DEFAULT_MAPPING.equals(mappingType) && mappingType.charAt(0) == '_') {
296+
if (MapperService.DEFAULT_MAPPING.equals(mappingType) == false
297+
&& MapperService.SINGLE_MAPPING_NAME.equals(mappingType) == false
298+
&& mappingType.charAt(0) == '_') {
297299
throw new InvalidTypeNameException("Document mapping type name can't start with '_', found: [" + mappingType + "]");
298300
}
299301
MetaData.Builder builder = MetaData.builder(metaData);

0 commit comments

Comments
 (0)