Remove now-unused createParser that uses BytesReference (#28926)

This removes `BytesReference` use from XContent and all subclasses.

Relates to #28504

Author: dakrone

server/src/main/java/org/elasticsearch/common/xcontent/XContent.java

@@ -20,7 +20,6 @@
 package org.elasticsearch.common.xcontent;
 
 import org.elasticsearch.common.Booleans;
-import org.elasticsearch.common.bytes.BytesReference;
 
 import java.io.IOException;
 import java.io.InputStream;
@@ -104,15 +103,6 @@ XContentParser createParser(NamedXContentRegistry xContentRegistry,
     XContentParser createParser(NamedXContentRegistry xContentRegistry,
             DeprecationHandler deprecationHandler, byte[] data, int offset, int length) throws IOException;
 
-    /**
-     * Creates a parser over the provided bytes.
-     * @deprecated use {@link #createParser(NamedXContentRegistry, DeprecationHandler, InputStream)} instead,
-     * the BytesReference coupling in this class will be removed in a future commit
-     */
-    @Deprecated
-    XContentParser createParser(NamedXContentRegistry xContentRegistry,
-            DeprecationHandler deprecationHandler, BytesReference bytes) throws IOException;
-
     /**
      * Creates a parser over the provided reader.
      */

server/src/main/java/org/elasticsearch/common/xcontent/cbor/CborXContent.java

@@ -24,7 +24,6 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.dataformat.cbor.CBORFactory;
 import org.elasticsearch.ElasticsearchParseException;
-import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.io.FastStringReader;
 import org.elasticsearch.common.xcontent.DeprecationHandler;
 import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -103,12 +102,6 @@ public XContentParser createParser(NamedXContentRegistry xContentRegistry,
         return new CborXContentParser(xContentRegistry, deprecationHandler, cborFactory.createParser(data, offset, length));
     }
 
-    @Override
-    public XContentParser createParser(NamedXContentRegistry xContentRegistry,
-            DeprecationHandler deprecationHandler, BytesReference bytes) throws IOException {
-        return createParser(xContentRegistry, deprecationHandler, bytes.streamInput());
-    }
-
     @Override
     public XContentParser createParser(NamedXContentRegistry xContentRegistry,
             DeprecationHandler deprecationHandler, Reader reader) throws IOException {

server/src/main/java/org/elasticsearch/common/xcontent/json/JsonXContent.java

@@ -23,7 +23,6 @@
 import com.fasterxml.jackson.core.JsonFactory;
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.core.JsonParser;
-import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.io.FastStringReader;
 import org.elasticsearch.common.xcontent.DeprecationHandler;
 import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -104,12 +103,6 @@ public XContentParser createParser(NamedXContentRegistry xContentRegistry,
         return new JsonXContentParser(xContentRegistry, deprecationHandler, jsonFactory.createParser(data, offset, length));
     }
 
-    @Override
-    public XContentParser createParser(NamedXContentRegistry xContentRegistry,
-            DeprecationHandler deprecationHandler, BytesReference bytes) throws IOException {
-        return createParser(xContentRegistry, deprecationHandler, bytes.streamInput());
-    }
-
     @Override
     public XContentParser createParser(NamedXContentRegistry xContentRegistry,
             DeprecationHandler deprecationHandler, Reader reader) throws IOException {

server/src/main/java/org/elasticsearch/common/xcontent/smile/SmileXContent.java

@@ -24,7 +24,6 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.dataformat.smile.SmileFactory;
 import com.fasterxml.jackson.dataformat.smile.SmileGenerator;
-import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.io.FastStringReader;
 import org.elasticsearch.common.xcontent.DeprecationHandler;
 import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -104,12 +103,6 @@ public XContentParser createParser(NamedXContentRegistry xContentRegistry,
         return new SmileXContentParser(xContentRegistry, deprecationHandler, smileFactory.createParser(data, offset, length));
     }
 
-    @Override
-    public XContentParser createParser(NamedXContentRegistry xContentRegistry,
-            DeprecationHandler deprecationHandler, BytesReference bytes) throws IOException {
-        return createParser(xContentRegistry, deprecationHandler, bytes.streamInput());
-    }
-
     @Override
     public XContentParser createParser(NamedXContentRegistry xContentRegistry,
             DeprecationHandler deprecationHandler, Reader reader) throws IOException {

server/src/main/java/org/elasticsearch/common/xcontent/yaml/YamlXContent.java

@@ -23,7 +23,6 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
 import org.elasticsearch.ElasticsearchParseException;
-import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.io.FastStringReader;
 import org.elasticsearch.common.xcontent.DeprecationHandler;
 import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -99,12 +98,6 @@ public XContentParser createParser(NamedXContentRegistry xContentRegistry,
         return new YamlXContentParser(xContentRegistry, deprecationHandler, yamlFactory.createParser(data, offset, length));
     }
 
-    @Override
-    public XContentParser createParser(NamedXContentRegistry xContentRegistry,
-            DeprecationHandler deprecationHandler, BytesReference bytes) throws IOException {
-        return createParser(xContentRegistry, deprecationHandler, bytes.streamInput());
-    }
-
     @Override
     public XContentParser createParser(NamedXContentRegistry xContentRegistry,
             DeprecationHandler deprecationHandler, Reader reader) throws IOException {