Fix buffer underrun for wrong received buffer size #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an underrun in the utility function copying a wide-char string to the client application. The impact is limited and it can only happen if the received size of the client buffer is of the wrong size (<=0). The commit also fixes a logging error happening if this function needs to truncate the output. The macro for a format specifier with no precision was provided instead of the needed one with precision. This could potentially crash the client application in case the string to be logged in not 0-terminated, logging is explicitely enabled at an INFO (or higher) level and truncation needs to be applied
bpintea
added a commit
that referenced
this pull request
Nov 28, 2019
This commit fixes an underrun in the utility function copying a wide-char string to the client application. The impact is limited and it can only happen if the received size of the client buffer is of the wrong size (<=0). The commit also fixes a logging error happening if this function needs to truncate the output. The macro for a format specifier with no precision was provided instead of the needed one with precision. This could potentially crash the client application in case the string to be logged in not 0-terminated, logging is explicitely enabled at an INFO (or higher) level and truncation needs to be applied (cherry picked from commit ea2814b)
bpintea
added a commit
that referenced
this pull request
Dec 2, 2019
This commit fixes an underrun in the utility function copying a wide-char string to the client application. The impact is limited and it can only happen if the received size of the client buffer is of the wrong size (<=0). The commit also fixes a logging error happening if this function needs to truncate the output. The macro for a format specifier with no precision was provided instead of the needed one with precision. This could potentially crash the client application in case the string to be logged in not 0-terminated, logging is explicitely enabled at an INFO (or higher) level and truncation needs to be applied (cherry picked from commit ea2814b)
bpintea
added a commit
that referenced
this pull request
Dec 4, 2019
This commit fixes an underrun in the utility function copying a wide-char string to the client application. The impact is limited and it can only happen if the received size of the client buffer is of the wrong size (<=0). The commit also fixes a logging error happening if this function needs to truncate the output. The macro for a format specifier with no precision was provided instead of the needed one with precision. This could potentially crash the client application in case the string to be logged in not 0-terminated, logging is explicitely enabled at an INFO (or higher) level and truncation needs to be applied (cherry picked from commit ea2814b) Merge conflicts: - test/test_util.cc fixed by removing test for utf8_to_wstr(), not present in 6.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an underrun in the utility function copying a
wide-char string to the client application.
The impact is limited and it can only happen if the
received size of the client buffer is of the wrong size (<=0).
The PR also fixes a logging error happening if this function needs
to truncate the output. The macro for a format specifier with no
precision was provided instead of the needed one with precision. This
could potentially crash the client application in case the string to be
logged in not 0-terminated, logging is explicitely
enabled at an INFO (or higher) level and truncation needs to be applied