Trim whitespace from certain DSN fields #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trim whitespace from Cloud ID, User and Host field values before submitting these to the driver (WS is likely to be inserted if copy&pasting these values.) Also, rephrase the error message presented to the user in case the Cloud ID is incorrect.
bpintea
added a commit
that referenced
this pull request
Nov 14, 2019
Trim whitespace from Cloud ID, User and Host field values before submitting these to the driver (WS is likely to be inserted if copy&pasting these values.) Also, rephrase the error message presented to the user in case the Cloud ID is incorrect. (cherry picked from commit c4b36bb)
bpintea
added a commit
that referenced
this pull request
Nov 14, 2019
Trim whitespace from Cloud ID, User and Host field values before submitting these to the driver (WS is likely to be inserted if copy&pasting these values.) Also, rephrase the error message presented to the user in case the Cloud ID is incorrect. (cherry picked from commit c4b36bb)
bpintea
added a commit
that referenced
this pull request
Dec 4, 2019
Trim whitespace from Cloud ID, User and Host field values before submitting these to the driver (WS is likely to be inserted if copy&pasting these values.) Also, rephrase the error message presented to the user in case the Cloud ID is incorrect. (cherry picked from commit c4b36bb) Cherry-pick conflicts: - driver/connect.c - dsneditor/EsOdbcDsnEditor/DSNEditorForm.cs resolved by removing the cloud-id related code from the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim whitespace from
Cloud ID,UserandHostnamefield values beforesubmitting these to the driver.
(WS is likely to be inserted if copy&pasting these values.)
Also, rephrase the error message presented to the user in case the
Cloud IDis incorrect.