Skip to content

Conversation

@ReLium
Copy link

@ReLium ReLium commented Mar 28, 2019

@ReLium
Copy link
Author

ReLium commented Mar 28, 2019

It is a pretty urgent pull request, as elastic search gives warnings
"Deprecated parameter [_source_include] used, expected [_source_includes] instead",

but it is impossible to change parameter in request, because client gives exception "Used params out of whitelist"

@ReLium ReLium force-pushed the update-white-list branch from a7c22c2 to 3e2efd8 Compare April 1, 2019 08:27
@ReLium ReLium force-pushed the update-white-list branch from 3e2efd8 to cc8f9fe Compare April 1, 2019 08:40
@ReLium
Copy link
Author

ReLium commented Apr 1, 2019

BTW,

  1. I signed CLA, but it still failed.
  2. Integration tests fail is not related to my changes

@ezimuel
Copy link
Contributor

ezimuel commented Apr 18, 2019

@ReLium I just checked the CLA and it's ok, don't worry. The integration test are ok now, I fixed it until ES 6.5. I'm planning to release a 6.5 release soon and I'll merge this PR for 6.7. More details will come.
Thanks for your contribution!

@ezimuel ezimuel added this to the 6.7.0 milestone Apr 18, 2019
@ezimuel
Copy link
Contributor

ezimuel commented Apr 24, 2019

I'm closing this in favor of #882. We don't need to remove the old parameter names _source_exclude and _source_include they are only deprecated, people should be able to continue to use it.

@ezimuel ezimuel closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants