Skip to content

Conversation

@stevejgordon
Copy link
Contributor

Main change to existing is removing Response from AsyncSearchResponseBase and making AsyncSearchResponseBase non-generic as a result. This allows the base to be used for the status response which differs by not include the response itself.

@stevejgordon stevejgordon mentioned this pull request Jan 7, 2021
@stevejgordon stevejgordon force-pushed the feature/async-search-status branch from 39c5fda to f04802c Compare January 7, 2021 15:49
@stevejgordon stevejgordon requested a review from Mpdreamz January 7, 2021 15:51
@stevejgordon
Copy link
Contributor Author

stevejgordon commented Jan 7, 2021

@Mpdreamz - I've revised the approach to avoid the breaking change.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stevejgordon stevejgordon merged commit cebf2bd into 7.11 Jan 14, 2021
@stevejgordon stevejgordon deleted the feature/async-search-status branch January 14, 2021 11:39
github-actions bot pushed a commit that referenced this pull request Jan 14, 2021
@github-actions
Copy link
Contributor

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5239-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 cebf2bd53cdfad124316ec0c53f4e6e0ff5ba786
# Push it to GitHub
git push --set-upstream origin backport-5239-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-5239-to-master.

stevejgordon added a commit that referenced this pull request Jan 14, 2021
stevejgordon added a commit that referenced this pull request Jan 14, 2021
stevejgordon added a commit that referenced this pull request Jan 14, 2021
* Implement AsyncSearch Status API (#5239)

* Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants