add support for the reload secure settings API #3536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Jan 25, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left one small nitpick
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// This API will decrypt and re-read the entire keystore, on every cluster node, but only the reloadable secure settings will |
Contributor
There was a problem hiding this comment.
I think this would flow better starting with "Decrypts and re-reads the entire keystore..."
Member
Author
There was a problem hiding this comment.
I took this from the elasticsearch docs, inclined to leave it as. Want to at some point have descriptions as part of the json spec.
Contributor
There was a problem hiding this comment.
I should have been more clear; I think the description is fine, but dislike that it starts with "This API...". This feels superfluous when reading XML docs
Member
Author
There was a problem hiding this comment.
I addressed that comment on the ccr PR and not here. Bit random on my part but your point is absolutely.correct it's superuous :)
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
Mpdreamz
added a commit
that referenced
this pull request
Jan 28, 2019
(cherry picked from commit 89eb85a)
Mpdreamz
added a commit
that referenced
this pull request
Mar 29, 2019
(cherry picked from commit 89eb85a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.