Skip to content

Conversation

@Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jan 2, 2019

elastic/elasticsearch#32844

This one was tricky to implement since delegate_type indicates which settings one can send. Came up with a way to reuse existing typed classes for the other repository settings in the end although its not the cleanest.

@Mpdreamz Mpdreamz added the v6.5.0 label Jan 2, 2019
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mpdreamz Mpdreamz merged commit c7dc984 into 6.5 Jan 24, 2019
@Mpdreamz Mpdreamz deleted the v65/source-repository-snapshot-restore branch January 24, 2019 13:01
Mpdreamz added a commit that referenced this pull request Jan 28, 2019
Mpdreamz added a commit that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants