Add support for condition token filter #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
changed the title
Mpdreamz
changed the title
Mpdreamz
force-pushed
the
v65/condition-token-filter
branch
from
7595ff3 to
71a07a5
Compare
Contributor
|
@Mpdreamz - Looks like serialisation is falling over? |
Mpdreamz
force-pushed
the
v65/condition-token-filter
branch
from
71a07a5 to
19cb079
Compare
russcam
approved these changes
Jan 25, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left small comment about "filter"
| public IScript Script { get; set; } | ||
|
|
||
| /// <inheritdoc cref="IConditionTokenFilter.Filters" /> | ||
| public IEnumerable<string> Filters { get; set; } |
Contributor
There was a problem hiding this comment.
can this be a single filter or enumerable of filters?
Member
Author
There was a problem hiding this comment.
No, this does not allow inline token filter declarations only references.
I've only seen it being documented as an array of string.
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
* Add support for condition token filter elastic/elasticseach#31958 * fix failing unit tests * fix failing unit tests
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
* Add support for condition token filter elastic/elasticseach#31958 * fix failing unit tests * fix failing unit tests
Mpdreamz
added a commit
that referenced
this pull request
Jan 28, 2019
* Add support for condition token filter elastic/elasticseach#31958 * fix failing unit tests * fix failing unit tests (cherry picked from commit a002b40)
Mpdreamz
added a commit
that referenced
this pull request
Mar 29, 2019
* Add support for condition token filter elastic/elasticseach#31958 * fix failing unit tests * fix failing unit tests (cherry picked from commit a002b40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/elasticsearch#31958