Add support for the SQL API's #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Oct 5, 2018
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM 👍 there are folks already looking forward to this!
I left a few small comments
| fields.And(field); | ||
| reader.Read(); // "format"; | ||
| reader.Read(); // "format value"; | ||
| reader.Read(); // "}"; |
Contributor
There was a problem hiding this comment.
Do we have a test for this?
| /// and can take any values as documented on Joda time's DateTimeZone enum. | ||
| /// </summary> | ||
| [JsonProperty("time_zone")] | ||
| string TimeZone { get; set; } |
Contributor
There was a problem hiding this comment.
We should look at standardising TimeZone and Timezone in 7.x
|
|
||
| namespace Nest | ||
| { | ||
| public class SqlRow : ReadOnlyCollection<SqlValue> { |
Contributor
There was a problem hiding this comment.
nitpick: formatting of { not on separate line
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Add QuerySql API methods and tests * Add ClearSqlCursor API methods and tests * Add TranslateSql API methods and tests (cherry picked from commit a59a00a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.