Regenerate docs

Author: russcam

docs/client-concepts/certificates/working-with-certificates.asciidoc

@@ -15,19 +15,19 @@ please modify the original csharp file found at the link and submit the PR with
 [[working-with-certificates]]
 === Working with certificates
 
-If you've enabled SSL on Elasticsearch with https://www.elastic.co/products/x-pack[X-Pack] or through a
+If you've enabled SSL on Elasticsearch with https://www.elastic.co/products/elastic-stack[Elastic Stack Security features], or through a
 proxy in front of Elasticsearch, and the Certificate Authority (CA)
-that generated the certificate is trusted by the machine running the client code, there should be nothing you'll have to do to talk
+that generated the certificate is trusted by the machine running the client code, there should be nothing for you to do to talk
 to the cluster over HTTPS with the client.
 
-If you are using your own CA which is not trusted however, .NET won't allow you to make HTTPS calls to that endpoint by default. With .NET,
-you can pre-empt this though a custom validation callback on the global static
+If you are using your own CA which is not trusted however, .NET won't allow you to make HTTPS calls to that endpoint by default.
+With .NET Framework, you can pre-empt this though a custom validation callback on the global static
 `ServicePointManager.ServerCertificateValidationCallback`. Most examples you will find doing this this will simply return `true` from the
 validation callback and merrily whistle off into the sunset. **This is not advisable** as it allows *any* HTTPS traffic through in the
 current `AppDomain` *without* any validation. Here's a concrete example:
 
-Imagine you deploy a web application that talks to Elasticsearch over HTTPS through NEST, and also uses some third party SOAP/WSDL endpoint;
-by setting
+Imagine you deploy a web application that talks to Elasticsearch over HTTPS using NEST, and also uses some third party SOAP/WSDL endpoint.
+By setting the following
 
 [source,csharp]
 ----
@@ -61,7 +61,7 @@ public class DenyAllCertificatesCluster : SslAndKpiXPackCluster
         .ServerCertificateValidationCallback(CertificateValidations.DenyAll); <1>
 }
 ----
-<1> synonymous with the previous lambda expression
+<1> use a lambda expression or `CertificateValidations.DenyAll` to deny all validation
 
 ===== Allowing all certificate validation
 
@@ -72,18 +72,18 @@ Here we set up `ConnectionSettings` with a validation callback that allows all c
 public class AllowAllCertificatesCluster : SslAndKpiXPackCluster
 {
     protected override ConnectionSettings ConnectionSettings(ConnectionSettings s) => s
-        .ServerCertificateValidationCallback((o, certificate, chain, errors) => true)
+        .ServerCertificateValidationCallback((o, certificate, chain, errors) => true) <1>
         .ServerCertificateValidationCallback(CertificateValidations.AllowAll); <1>
 }
 ----
-<1> synonymous with the previous lambda expression
+<1> use a lambda expression or `CertificateValidations.AllowAll` to allow all validation
 
 ===== Allowing certificates from a Certificate Authority
 
 If your client application has access to the public CA certificate locally, Elasticsearch.NET and NEST ship with some handy helpers
 that can assert that a certificate the server presents is one that came from the local CA.
 
-If you use X-Pack's {ref_current}/certutil.html[`elasticsearch-certutil` tool] to generate SSL certificates, the generated node certificate
+If you use {ref_current}/certutil.html[`elasticsearch-certutil` tool] to generate SSL certificates, the generated node certificate
 does not include the CA in the certificate chain, in order to cut down on SSL handshake size. In those case you can use
 `CertificateValidations.AuthorityIsRoot` and pass it your local copy of the CA public key to assert that
 the certificate the server presented was generated using it
@@ -120,60 +120,3 @@ If you go for a vendor generated SSL certificate, it's common practice for the c
 in the certificate chain. When using such a certificate, use `CertificateValidations.AuthorityPartOfChain` which validates that
 the local CA certificate is part of the chain that was used to generate the servers key.
 
-==== Client Certificates
-
-X-Pack also allows you to configure a {ref_current}/configuring-pki-realm.html[PKI realm] to enable user authentication
-through client certificates. The {ref_current}/certutil.html[`elasticsearch-certutil` tool] included with X-Pack allows you to
-generate client certificates as well and assign the distinguished name (DN) of the
-certificate to a user with a certain role.
-
-By default, the `elasticsearch-certutil` tool only generates a public certificate (`.cer`) and a private key `.key`. To authenticate with client certificates, you need to present both
-as one certificate. The easiest way to do this is to generate a `pfx` or `p12` file from the `.cer` and `.key`
-and attach these to requests using `new X509Certificate(pathToPfx)`.
-
-You can pass a client certificate on `ConnectionSettings` for *all* requests.
-
-[source,csharp]
-----
-public class PkiCluster : CertgenCaCluster
-{
-    public PkiCluster() : base(new SslAndKpiClusterConfiguration
-    {
-        DefaultNodeSettings =
-        {
-            {"xpack.security.authc.realms.file1.enabled", "false"},
-            {"xpack.security.http.ssl.client_authentication", "required"}
-        }
-    }) { }
-
-    protected override ConnectionSettings Authenticate(ConnectionSettings s) => s <1>
-        .ClientCertificate(new X509Certificate2(this.ClusterConfiguration.FileSystem.ClientCertificate));
-}
-----
-<1> Set the client certificate on `ConnectionSettings`
-
-Or on a per request basis on `RequestConfiguration` which will take precedence over the ones defined on `ConnectionConfiguration`
-
-==== Object Initializer syntax example 
-
-[source,csharp]
-----
-new RootNodeInfoRequest
-{
-    RequestConfiguration = new RequestConfiguration
-    {
-        ClientCertificates = new X509Certificate2Collection { new X509Certificate2(this.Certificate) }
-    }
-}
-----
-
-==== Fluent DSL example 
-
-[source,csharp]
-----
-s => s
-.RequestConfiguration(r => r
-        .ClientCertificate(this.Certificate)
-)
-----
-

docs/client-concepts/connection-pooling/exceptions/unexpected-exceptions.asciidoc

@@ -77,7 +77,11 @@ Finally, we assert that we can still see the audit trail for the whole coordinat
 ----
 var audit = new Auditor(() => VirtualClusterWith
     .Nodes(10)
+#if DOTNETCORE
     .ClientCalls(r => r.OnPort(9200).FailAlways(new System.Net.Http.HttpRequestException("recover"))) <1>
+#else
+    .ClientCalls(r => r.OnPort(9200).FailAlways(new System.Net.WebException("recover"))) <1>
+#endif
     .ClientCalls(r => r.OnPort(9201).FailAlways(new Exception("boom!"))) <2>
     .StaticConnectionPool()
     .Settings(s => s.DisablePing())
@@ -96,7 +100,7 @@ audit = await audit.TraceUnexpectedException(
     }
 );
 ----
-<1> calls on 9200 set up to throw a `HttpRequestException`
+<1> calls on 9200 set up to throw a `HttpRequestException` or a `WebException`
 
 <2> calls on 9201 set up to throw an `Exception`
 

docs/client-concepts/connection-pooling/exceptions/unrecoverable-exceptions.asciidoc

@@ -121,13 +121,13 @@ var audit = new Auditor(() => VirtualClusterWith
     .Ping(r => r.SucceedAlways())
     .ClientCalls(r => r.FailAlways(401).ReturnByteResponse(HtmlNginx401Response, "application/json")) <1>
     .StaticConnectionPool()
-    .Settings(s=>s.SkipDeserializationForStatusCodes(401))
+    .Settings(s => s.SkipDeserializationForStatusCodes(401))
 );
 
 audit = await audit.TraceElasticsearchException(
     new ClientCall {
         { AuditEvent.PingSuccess, 9200 },
-        { AuditEvent.BadResponse, 9200 },
+        { AuditEvent.BadResponse, 9201 },
     },
     (e) =>
     {

docs/client-concepts/connection/modifying-default-connection.asciidoc

@@ -97,42 +97,30 @@ to the request, change the maximum number of connections allowed to an endpoint,
 By deriving from `HttpConnection`, it is possible to change the behaviour of the connection. The following
 provides some examples
 
-On .NET full framework the overrides on HttpConnection are different as they are geared towards using HttpWebRequest.
-Here are two examples for .NET full framework
-
 [source,csharp]
 ----
 public class MyCustomHttpConnection : HttpConnection
 {
-    protected override void AlterServicePoint(ServicePoint requestServicePoint, RequestData requestData)
+    protected override HttpRequestMessage CreateRequestMessage(RequestData requestData)
     {
-        base.AlterServicePoint(requestServicePoint, requestData);
-        requestServicePoint.ConnectionLimit = 10000;
-        requestServicePoint.UseNagleAlgorithm = true;
+        var message = base.CreateRequestMessage(requestData);
+        var header = string.Empty;
+        message.Headers.Authorization = new AuthenticationHeaderValue("Negotiate", header);
+        return message;
     }
 }
 
-public class X509CertificateHttpConnection : HttpConnection
+public class KerberosConnection : HttpConnection
 {
-    protected override HttpWebRequest CreateHttpWebRequest(RequestData requestData)
+    protected override HttpRequestMessage CreateRequestMessage(RequestData requestData)
     {
-        var request = base.CreateHttpWebRequest(requestData);
-        request.ClientCertificates.Add(new X509Certificate("file_path_to_cert"));
-        return request;
+        var message = base.CreateRequestMessage(requestData);
+        var header = string.Empty;
+        message.Headers.Authorization = new AuthenticationHeaderValue("Negotiate", header);
+        return message;
     }
 }
 ----
 
-As before, a new instance of the custom connection is passed to `ConnectionSettings` in order to
-use
-
-[source,csharp]
-----
-var connection = new X509CertificateHttpConnection();
-var connectionPool = new SingleNodeConnectionPool(new Uri("http://localhost:9200"));
-var settings = new ConnectionSettings(connectionPool, connection);
-var client = new ElasticClient(settings);
-----
-
 See <<working-with-certificates, Working with certificates>> for further details.
 

docs/client-concepts/high-level/mapping/ignoring-properties.asciidoc

@@ -17,9 +17,11 @@ please modify the original csharp file found at the link and submit the PR with
 
 Properties on a POCO can be ignored for mapping purposes in a few ways:
 
-* Using the `Ignore` property on a derived `ElasticsearchPropertyAttribute` type applied to
+* Using the `Ignore` property on a derived `ElasticsearchPropertyAttributeBase` type, such as `TextAttribute`, applied to
 the property that should be ignored on the POCO
 
+* Using the `Ignore` property on `PropertyNameAttribute` applied to a property that should be ignored on the POCO
+
 * Using the `.DefaultMappingFor<TDocument>(Func<ClrTypeMappingDescriptor<TDocument>, IClrTypeMapping<TDocument>>
 selector)` on `ConnectionSettings`
 
@@ -42,8 +44,11 @@ public class CompanyWithAttributesAndPropertiesToIgnore
     [Text(Ignore = true)]
     public string PropertyToIgnore { get; set; }
 
+    [PropertyName("anotherPropertyToIgnore", Ignore = true)]
     public string AnotherPropertyToIgnore { get; set; }
 
+    public string FluentMappingPropertyToIgnore { get; set; }
+
     [Ignore, JsonIgnore]
     public string JsonIgnoredProperty { get; set; }
 }
@@ -56,7 +61,7 @@ All of the properties except `Name` have been ignored in the mapping
 var connectionSettings = new ConnectionSettings(new InMemoryConnection()) <1>
     .DisableDirectStreaming() <2>
     .DefaultMappingFor<CompanyWithAttributesAndPropertiesToIgnore>(m => m
-        .Ignore(p => p.AnotherPropertyToIgnore)
+        .Ignore(p => p.FluentMappingPropertyToIgnore)
     );
 
 var client = new ElasticClient(connectionSettings);

docs/code-standards/naming-conventions.asciidoc

@@ -173,6 +173,8 @@ var elasticsearchNetAssembly = typeof(IElasticLowLevelClient).Assembly;
 
 var exceptions = new List<Type>
 {
+    elasticsearchNetAssembly.GetType("Microsoft.CodeAnalysis.EmbeddedAttribute"),
+    elasticsearchNetAssembly.GetType("System.Runtime.CompilerServices.IsReadOnlyAttribute"),
     elasticsearchNetAssembly.GetType("System.AssemblyVersionInformation"),
     elasticsearchNetAssembly.GetType("System.FormattableString"),
     elasticsearchNetAssembly.GetType("System.Runtime.CompilerServices.FormattableStringFactory"),