Expose q querystring parameter on search (#4238)

* remove q from block list on SearchOverrides

* Expose ?q as QueryOnQueryString for search like its exposed on other API's as well'

* eventhough we expose q on query string it should not trigger GET as we always end up sending other params in the body

(cherry picked from commit fc1b74a)

Author: Mpdreamz

src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs

@@ -12,7 +12,6 @@ public class SearchOverrides : EndpointOverridesBase
 			"timeout",
 			"explain",
 			"version",
-			"q", //we dont support GET searches
 			"sort",
 			"_source",
 			"_source_includes",

src/Elasticsearch.Net/Api/RequestParameters/RequestParameters.NoNamespace.cs

@@ -1638,6 +1638,13 @@ public string Preference
 			set => Q("preference", value);
 		}
 
+		///<summary>Query in the Lucene query string syntax</summary>
+		public string QueryOnQueryString
+		{
+			get => Q<string>("q");
+			set => Q("q", value);
+		}
+
 		///<summary>Specify if request cache should be used for this request or not, defaults to index level setting</summary>
 		public bool? RequestCache
 		{

src/Nest/Descriptors.NoNamespace.cs

@@ -1272,6 +1272,8 @@ public SearchDescriptor<TInferDocument> Index<TOther>()
 		public SearchDescriptor<TInferDocument> PreFilterShardSize(long? prefiltershardsize) => Qs("pre_filter_shard_size", prefiltershardsize);
 		///<summary>Specify the node or shard the operation should be performed on (default: random)</summary>
 		public SearchDescriptor<TInferDocument> Preference(string preference) => Qs("preference", preference);
+		///<summary>Query in the Lucene query string syntax</summary>
+		public SearchDescriptor<TInferDocument> QueryOnQueryString(string queryonquerystring) => Qs("q", queryonquerystring);
 		///<summary>Specify if request cache should be used for this request or not, defaults to index level setting</summary>
 		public SearchDescriptor<TInferDocument> RequestCache(bool? requestcache = true) => Qs("request_cache", requestcache);
 		///<summary>

src/Nest/Requests.NoNamespace.cs

@@ -2743,6 +2743,13 @@ public string Preference
 			set => Q("preference", value);
 		}
 
+		///<summary>Query in the Lucene query string syntax</summary>
+		public string QueryOnQueryString
+		{
+			get => Q<string>("q");
+			set => Q("q", value);
+		}
+
 		///<summary>Specify if request cache should be used for this request or not, defaults to index level setting</summary>
 		public bool? RequestCache
 		{

src/Nest/Search/Search/SearchRequest.cs

@@ -155,7 +155,7 @@ public partial interface ISearchRequest : ITypedSearchRequest
 		/// </summary>
 		[DataMember(Name = "track_scores")]
 		bool? TrackScores { get; set; }
-		
+
 		/// <summary>
 		/// Return a version for each search hit
 		/// </summary>
@@ -224,7 +224,7 @@ public partial class SearchRequest
 		public bool? Version { get; set; }
 
 		protected override HttpMethod HttpMethod =>
-			RequestState.RequestParameters?.ContainsQueryString("source") == true || RequestState.RequestParameters?.ContainsQueryString("q") == true
+			RequestState.RequestParameters?.ContainsQueryString("source") == true
 				? HttpMethod.GET
 				: HttpMethod.POST;
 
@@ -246,7 +246,7 @@ public partial class SearchRequest<TInferDocument> : ISearchRequest<TInferDocume
 	public partial class SearchDescriptor<TInferDocument> where TInferDocument : class
 	{
 		protected override HttpMethod HttpMethod =>
-			RequestState.RequestParameters?.ContainsQueryString("source") == true || RequestState.RequestParameters?.ContainsQueryString("q") == true
+			RequestState.RequestParameters?.ContainsQueryString("source") == true
 				? HttpMethod.GET
 				: HttpMethod.POST;