bump Proc 0.3.6 and use it explicit hook for WaitForEndOfStream Error

Author: Mpdreamz

src/Elastic.Managed/Elastic.Managed.csproj

@@ -19,7 +19,7 @@
     <PackageTags>elastic,elasticsearch,cluster,observable,rx</PackageTags>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Proc" Version="0.3.5" />
+    <PackageReference Include="Proc" Version="0.3.6" />
     <!--<ProjectReference Include="..\..\..\..\proc\src\Proc\Proc.csproj" />-->
     <PackageReference Include="SemanticVersioning" Version="0.8.0" />
   </ItemGroup>

src/Elastic.Managed/ElasticsearchNode.cs

@@ -125,14 +125,15 @@ protected override void OnBeforeSetCompletedHandle()
 			base.OnBeforeSetCompletedHandle();
 		}
 
-		protected override void OnError(IObserver<CharactersOut> observer, Exception e)
+		protected override void OnBeforeWaitForEndOfStreamsError(TimeSpan waited)
 		{
-			if (e is ObservableProcessException oe && e.Message.StartsWith("Waited"))
-			{
-				HardKill(this.HostProcessId);
-				HardKill(this.JavaProcessId);
-			}
-			base.OnError(observer, e);
+			// The wait for streams finished before streams were fully read.
+			// this usually indicates the process is still running.
+			// Proc will successfully kill the host but will leave the JavaProcess the bat file starts running
+			// The elasticsearch jar is closing down so won't leak but might prevent EphemeralClusterComposer to do its clean up.
+			// We do a hard kill on both here to make sure both processes are gone.
+			HardKill(this.HostProcessId);
+			HardKill(this.JavaProcessId);
 		}
 
 		private static void HardKill(int? processId)

src/Examples/ScratchPad/ScratchPad.csproj

@@ -5,7 +5,7 @@
     <IsPackable>False</IsPackable>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Proc" Version="0.3.5" />
+    <PackageReference Include="Proc" Version="0.3.6" />
     <!--<ProjectReference Include="..\..\..\..\..\proc\src\Proc\Proc.csproj" />-->
     <ProjectReference Include="..\..\Elastic.Managed.Ephemeral\Elastic.Managed.Ephemeral.csproj" />
     <PackageReference Include="NEST" Version="6.0.1" />