Ensure IEphemeralCluster extends ICluster (#60)

Author: Mpdreamz

src/Elastic.Elasticsearch.Ephemeral/IEphemeralCluster.cs

@@ -8,7 +8,7 @@
 
 namespace Elastic.Elasticsearch.Ephemeral
 {
-	public interface IEphemeralCluster
+	public interface IEphemeralCluster : ICluster
 	{
 		ICollection<Uri> NodesUris(string hostName = null);
 		string GetCacheFolderName();

src/Elastic.Elasticsearch.Managed/ClusterBase.cs

@@ -17,26 +17,39 @@
 
 namespace Elastic.Elasticsearch.Managed
 {
-	public interface ICluster<out TConfiguration> : IDisposable
-		where TConfiguration : IClusterConfiguration<NodeFileSystem>
+	public interface ICluster
 	{
+		/// <summary>
+		/// Whether known proxies were detected as running during startup
+		/// </summary>
+		DetectedProxySoftware DetectedProxy { get; }
+
+		/// <summary> A friendly name for this cluster, derived from the implementation name</summary>
 		string ClusterMoniker { get; }
-		TConfiguration ClusterConfiguration { get; }
+
+		/// <inheritdoc cref="INodeFileSystem"/>
 		INodeFileSystem FileSystem { get; }
+
+		/// <summary> Indicating if this cluster was started correctly </summary>
 		bool Started { get; }
+
+		/// <summary>
+		/// The collection of <see cref="ElasticsearchNode"/>'s that make up the cluster
+		/// </summary>
 		ReadOnlyCollection<ElasticsearchNode> Nodes { get; }
+	}
+
+	public interface ICluster<out TConfiguration> : ICluster,IDisposable
+		where TConfiguration : IClusterConfiguration<NodeFileSystem>
+	{
+		TConfiguration ClusterConfiguration { get; }
 		IConsoleLineHandler Writer { get; }
 
 		IDisposable Start();
 
 		IDisposable Start(TimeSpan waitForStarted);
 
 		IDisposable Start(IConsoleLineHandler writer, TimeSpan waitForStarted);
-
-		/// <summary>
-		/// Whether known proxies were detected as running during startup
-		/// </summary>
-		DetectedProxySoftware DetectedProxy { get; }
 	}
 
 

src/Elastic.Elasticsearch.Xunit/XunitClusterExtensions.cs

@@ -13,8 +13,7 @@ namespace Elastic.Elasticsearch.Xunit
 	/// </summary>
 	public static class XunitClusterExtensions
 	{
-		private static readonly ConcurrentDictionary<IEphemeralCluster, object> Clients =
-			new ConcurrentDictionary<IEphemeralCluster, object>();
+		private static readonly ConcurrentDictionary<IEphemeralCluster, object> Clients = new();
 
 		/// <summary>
 		///     Gets a client for the cluster if one exists, or creates a new client if one doesn't.