Skip to content

Conversation

@estolfo
Copy link
Contributor

@estolfo estolfo commented Feb 1, 2022

Ensure that the go routine finishes sending to the APM server before the extension considers its work done and polls for the next event.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Feb 1, 2022
@estolfo estolfo marked this pull request as draft February 1, 2022 11:15
@estolfo estolfo changed the title Use WaitGroup to ensure background go routine finishes sending Use WaitGroup to ensure go routine finishes sending Feb 1, 2022
@estolfo estolfo changed the title Use WaitGroup to ensure go routine finishes sending Use WaitGroup to ensure go routine finishes sending to APM server Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-01T11:14:57.822+0000

  • Duration: 12 min 17 sec

  • Commit: d053807

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@estolfo estolfo marked this pull request as ready for review February 1, 2022 13:10
@estolfo estolfo requested review from astorm and jlvoiseux February 1, 2022 15:45
@jlvoiseux jlvoiseux self-requested a review February 1, 2022 17:47
Copy link
Contributor

@jlvoiseux jlvoiseux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also passes the end-to-end tests developed on branch jlvoiseux/e2e-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants