From a474e1626309f74bf5df23ab03d0c7596f8042ab Mon Sep 17 00:00:00 2001
From: Steve James <4stevejames@gmail.com>
Date: Sat, 13 Jan 2018 13:55:45 -0800
Subject: [PATCH 01/12] $variable and more comments
Mostly changing to $naming scheme for jQuery objects and adding more comments.
---
src/jquery.multiselect.js | 419 +++++++++++++++++++-------------------
1 file changed, 204 insertions(+), 215 deletions(-)
diff --git a/src/jquery.multiselect.js b/src/jquery.multiselect.js
index 7bd32d5..ddaeaf7 100644
--- a/src/jquery.multiselect.js
+++ b/src/jquery.multiselect.js
@@ -1,11 +1,11 @@
/* jshint forin:true, noarg:true, noempty:true, eqeqeq:true, boss:true, undef:true, curly:true, browser:true, jquery:true */
/*
- * jQuery MultiSelect UI Widget 2.0.1
+ * jQuery MultiSelect UI Widget 3.0.0
* Copyright (c) 2012 Eric Hynds
*
* Depends:
- * - jQuery 1.4.2+
- * - jQuery UI 1.11 widget factory
+ * - jQuery 1.7+ (http://api.jquery.com/)
+ * - jQuery UI 1.11 widget factory (http://api.jqueryui.com/jQuery.widget/)
*
* Optional:
* - jQuery UI effects
@@ -25,59 +25,59 @@
// default options
options: {
- header: true,
- height: 175,
- minWidth: 225,
- classes: '',
- openIcon: '' + o.openIcon + ' ' + o.openIcon + '
')
+ var $menu = (this.$menu = $('
'))
.addClass('ui-multiselect-menu ui-widget ui-widget-content ui-corner-all ' + o.classes)
.appendTo(this._getAppendEl());
// Menu header to hold controls for the menu
- this.header = $('
')
+ var $header = (this.$header = $('
'))
.addClass('ui-widget-header ui-corner-all ui-multiselect-header ui-helper-clearfix')
- .appendTo(this.menu);
+ .appendTo($menu);
// Header controls, will contain the check all/uncheck all buttons
// Depending on how the options are set, this may be empty or simply plain text
- this.headerLinkContainer = $('')
+ this.$headerLinkContainer = $('')
.addClass('ui-helper-reset')
.html(function() {
if(o.header === true) {
@@ -132,12 +133,12 @@
}
})
.append('' + o.closeIcon + ' " + value + " ");
+ this.$headerLinkContainer.children("li:not(:last-child)").remove();
+ this.$headerLinkContainer.prepend("" + value + " ");
}
break;
case 'checkAllText':
- menu.find('a.ui-multiselect-all span').eq(-1).text(value); // eq(-1) finds the last span
- break;
case 'uncheckAllText':
- menu.find('a.ui-multiselect-none span').eq(-1).text(value);
- break;
case 'flipAllText':
- menu.find('a.ui-multiselect-flip span').eq(-1).text(value);
+ $menu.find('a.ui-multiselect-' + {checkAllText: 'all', uncheckAllText: 'none', flipAllText: 'flip'}[key] + ' span').eq(-1).text(value); // eq(-1) finds the last span
break;
case 'checkAllIcon':
- menu.find('a.ui-multiselect-all span').eq(0).replaceWith(value);
- break;
case 'uncheckAllIcon':
- menu.find('a.ui-multiselect-none span').eq(0).replaceWith(value);
- break;
case 'flipAllIcon':
- menu.find('a.ui-multiselect-flip span').eq(0).replaceWith(value);
+ $menu.find('a.ui-multiselect-' + {checkAllIcon: 'all', uncheckAllIcon: 'none', flipAllIcon: 'flip'}[key] + ' span').eq(0).replaceWith(value); // eq(0) finds the first span
break;
case 'openIcon':
- menu.find('span.ui-multiselect-open').html(value);
+ $menu.find('span.ui-multiselect-open').html(value);
break;
case 'closeIcon':
- menu.find('a.ui-multiselect-close').html(value);
+ $menu.find('a.ui-multiselect-close').html(value);
break;
case 'height':
this.options[key] = value;
@@ -1006,13 +995,13 @@
this.update();
break;
case 'classes':
- menu.add(this.button).removeClass(this.options.classes).addClass(value);
+ $menu.add(this.$button).removeClass(this.options.classes).addClass(value);
break;
case 'multiple':
var el_0 = this.element[0];
if (!!el_0.multiple != value) {
- menu.toggleClass('ui-multiselect-multiple', value);
- menu.toggleClass('ui-multiselect-single', !value);
+ $menu.toggleClass('ui-multiselect-multiple', value);
+ $menu.toggleClass('ui-multiselect-single', !value);
el_0.multiple = value;
this.uncheckAll();
this.refresh();
From 5d0f625ec143b13ddeaaa419bae2653915a8ef60 Mon Sep 17 00:00:00 2001
From: Steve James <4stevejames@gmail.com>
Date: Sat, 13 Jan 2018 13:59:13 -0800
Subject: [PATCH 02/12] $variable naming and ditch bind
bind() is deprecated. Use on() instead.
---
src/jquery.multiselect.filter.js | 65 ++++++++++++++++----------------
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git a/src/jquery.multiselect.filter.js b/src/jquery.multiselect.filter.js
index 435920d..9c873d6 100644
--- a/src/jquery.multiselect.filter.js
+++ b/src/jquery.multiselect.filter.js
@@ -1,11 +1,12 @@
/* jshint forin:true, noarg:true, noempty:true, eqeqeq:true, boss:true, undef:true, curly:true, browser:true, jquery:true */
/*
- * jQuery MultiSelect UI Widget Filtering Plugin 2.0.0
+ * jQuery MultiSelect UI Widget Filtering Plugin 3.0.0
* Copyright (c) 2012 Eric Hynds
*
* http://www.erichynds.com/jquery/jquery-ui-multiselect-widget/
*
* Depends:
+ * - jQuery 1.7+
* - jQuery UI MultiSelect widget
*
* Dual licensed under the MIT and GPL licenses:
@@ -48,30 +49,30 @@
_create: function() {
var opts = this.options;
- var elem = $(this.element);
+ var $elem = this.element;
// get the multiselect instance
- this.instance = elem.multiselect('instance');
+ this.instance = $elem.multiselect('instance');
// store header; add filter class so the close/check all/uncheck all links can be positioned correctly
- this.header = this.instance.menu.find('.ui-multiselect-header').addClass('ui-multiselect-hasfilter');
+ this.$header = this.instance.$menu.find('.ui-multiselect-header').addClass('ui-multiselect-hasfilter');
- // wrapper elem
- this.input = $("
").addClass("ui-multiselect-filter").text(opts.label).append(this.input).prependTo(this.header);
+ this.$wrapper = $("
").addClass("ui-multiselect-filter").text(opts.label).append(this.$input).prependTo(this.$header);
// reference to the actual inputs
- this.inputs = this.instance.menu.find('input[type="checkbox"], input[type="radio"]');
+ this.$inputs = this.instance.$menu.find('input[type="checkbox"], input[type="radio"]');
// cache input values for searching
this.updateCache();
// rewrite internal _toggleChecked fn so that when checkAll/uncheckAll is fired,
- // only the currently filtered elements are checked
+ // only the currently filtered $elements are checked
this.instance._toggleChecked = function(flag, group) {
- var $inputs = (group && group.length) ? group : this.labels.find('input');
+ var $inputs = (group && group.length) ? group : this.$labels.find('input');
var _self = this;
// do not include hidden elems if the menu isn't open.
@@ -149,11 +150,11 @@
// thx for the logic here ben alman
_handler: function(e) {
- var term = $.trim(this.input[0].value.toLowerCase()),
+ var term = $.trim(this.$input[0].value.toLowerCase()),
// speed up lookups
- rows = this.rows, inputs = this.inputs, cache = this.cache;
- var $groups = this.instance.menu.find(".ui-multiselect-optgroup");
+ rows = this.rows, $inputs = this.$inputs, $cache = this.$cache;
+ var $groups = this.instance.$menu.find(".ui-multiselect-optgroup");
$groups.show();
if(!term) {
rows.show();
@@ -162,10 +163,10 @@
var regex = new RegExp(term.replace(rEscape, "\\$&"), 'gi');
- this._trigger("filter", e, $.map(cache, function(v, i) {
+ this._trigger("filter", e, $.map($cache, function(v, i) {
if(v.search(regex) !== -1) {
rows.eq(i).show();
- return inputs.get(i);
+ return $inputs.get(i);
}
return null;
@@ -183,36 +184,36 @@
},
_reset: function() {
- this.input.val('').trigger('input', '');
+ this.$input.val('').trigger('input', '');
},
updateCache: function() {
// each list item
- this.rows = this.instance.labels.parent();
+ this.rows = this.instance.$labels.parent();
// cache
- this.cache = this.element.children().map(function() {
- var elem = $(this);
+ this.$cache = this.element.children().map(function() {
+ var $elem = $(this);
// account for optgroups
if(this.tagName.toLowerCase() === "optgroup") {
- elem = elem.children();
+ $elem = $elem.children();
}
- return elem.map(function() {
+ return $elem.map(function() {
return this.innerHTML.toLowerCase();
}).get();
}).get();
},
widget: function() {
- return this.wrapper;
+ return this.$wrapper;
},
destroy: function() {
$.Widget.prototype.destroy.call(this);
- this.input.val('').trigger("keyup");
- this.wrapper.remove();
+ this.$input.val('').trigger("keyup");
+ this.$wrapper.remove();
}
});
From e8921e8564c7f2b570a4c54ceff39461055b6b90 Mon Sep 17 00:00:00 2001
From: Steve James <4stevejames@gmail.com>
Date: Sat, 13 Jan 2018 14:12:35 -0800
Subject: [PATCH 03/12] Update limited selectedList/checkAll test
Changed the default selectedText to be "# of # selected" so that developers will be aware that this form is available. (It always has been available..)
---
tests/unit/options.js | 592 +++++++++++++++++++++---------------------
1 file changed, 296 insertions(+), 296 deletions(-)
diff --git a/tests/unit/options.js b/tests/unit/options.js
index 3388170..5ca530a 100644
--- a/tests/unit/options.js
+++ b/tests/unit/options.js
@@ -1,182 +1,182 @@
(function($){
- module("options");
+ module("options");
- test("noneSelectedText", function(){
- expect(7);
- var text;
+ test("noneSelectedText", function(){
+ expect(7);
+ var text;
- el = $("select").multiselect({
- noneSelectedText: 'None Selected'
- });
+ el = $("select").multiselect({
+ noneSelectedText: 'None Selected'
+ });
- // read from widget
- text = el.multiselect("option", "noneSelectedText");
+ // read from widget
+ text = el.multiselect("option", "noneSelectedText");
- equals( button().text(), text, 'on init, button reads "None Selected"');
- el.multiselect("checkAll");
- ok( button().text() !== text, 'after checkAll, button no longer reads "None Selected"');
- el.multiselect("uncheckAll");
- equals( button().text(), text, 'after uncheckAll, button text restored to "None Selected"');
+ equals( button().text(), text, 'on init, button reads "None Selected"');
+ el.multiselect("checkAll");
+ ok( button().text() !== text, 'after checkAll, button no longer reads "None Selected"');
+ el.multiselect("uncheckAll");
+ equals( button().text(), text, 'after uncheckAll, button text restored to "None Selected"');
- // change the option value
- el.multiselect("option", "noneSelectedText", "No Checkboxes Checked");
- equals( el.multiselect("option", "noneSelectedText"), "No Checkboxes Checked", "new noneSelectedText value set correctly");
+ // change the option value
+ el.multiselect("option", "noneSelectedText", "No Checkboxes Checked");
+ equals( el.multiselect("option", "noneSelectedText"), "No Checkboxes Checked", "new noneSelectedText value set correctly");
- // read updated value from widget
- text = el.multiselect("option", "noneSelectedText");
+ // read updated value from widget
+ text = el.multiselect("option", "noneSelectedText");
- // test against the new value
- equals( button().text(), text, 'after changing the option value, button now reads "No Checkboxes Checked"');
- el.multiselect("checkAll");
- ok( button().text() !== text, 'after checkAll, button no longer reads "No Checkboxes Checked"');
- el.multiselect("uncheckAll");
- equals( button().text(), text, 'after uncheckAll, button text restored to "No Checkboxes Checked"');
+ // test against the new value
+ equals( button().text(), text, 'after changing the option value, button now reads "No Checkboxes Checked"');
+ el.multiselect("checkAll");
+ ok( button().text() !== text, 'after checkAll, button no longer reads "No Checkboxes Checked"');
+ el.multiselect("uncheckAll");
+ equals( button().text(), text, 'after uncheckAll, button text restored to "No Checkboxes Checked"');
- el.multiselect("destroy");
- });
+ el.multiselect("destroy");
+ });
- test("selectedText", function(){
- expect(3);
- var numOptions = $("select option").length;
+ test("selectedText", function(){
+ expect(3);
+ var numOptions = $("select option").length;
- el = $("select").multiselect({
- selectedText: '# of # selected'
- });
+ el = $("select").multiselect({
+ selectedText: '# of # selected'
+ });
- el.multiselect("checkAll");
- equals( button().text(), numOptions+' of '+numOptions+' selected', 'after checkAll, button reflects the total number of checked boxes');
+ el.multiselect("checkAll");
+ equals( button().text(), numOptions+' of '+numOptions+' selected', 'after checkAll, button reflects the total number of checked boxes');
- // change option value
- el.multiselect("option", "selectedText", function( numChecked ){
- return numChecked + ' options selected';
- });
+ // change option value
+ el.multiselect("option", "selectedText", function( numChecked ){
+ return numChecked + ' options selected';
+ });
- equals( button().text(), numOptions+' options selected', 'after changing the option to a function value, button reflects the new text');
+ equals( button().text(), numOptions+' options selected', 'after changing the option to a function value, button reflects the new text');
- // uncheck all
- el.multiselect("uncheckAll");
- equals( button().text(), el.multiselect("option","noneSelectedText"), 'after unchecking all, button text now reflects noneSelectedText option value');
+ // uncheck all
+ el.multiselect("uncheckAll");
+ equals( button().text(), el.multiselect("option","noneSelectedText"), 'after unchecking all, button text now reflects noneSelectedText option value');
- el.multiselect("destroy");
- });
+ el.multiselect("destroy");
+ });
- test("selectedList", function(){
- expect(2);
+ test("selectedList", function(){
+ expect(2);
- var html = 'foo "with quotes" bar baz foo "with quotes" bar baz foo bar baz foo bar baz A&E A&E foo foo foo bar ')
- .appendTo(document.body)
- .multiselect();
-
- var boxes = menu().find("input");
- var disabled = boxes.first();
- var enabled = boxes.last();
- var key = "ech-multiselect-disabled";
-
- equals(disabled.is(":disabled"), true, "The first option is disabled");
- el.multiselect("disable");
- equals(disabled.attr(key), undefined, "After disabling the widget, the pre-disabled option is not flagged to re-enable");
- equals(enabled.attr(key), "true", "and the enabled option is flagged to be re-enable");
- el.multiselect("enable");
- equals(disabled.is(":disabled"), true, "After enabling, the first option is still disabled");
- equals(disabled.attr(key), undefined, "and the option no longer has the stored data flag");
- el.multiselect("destroy").remove();
- });
-
- test("widget", function(){
- expect(1);
-
- el = $("select").multiselect();
- ok( menu().is("div.ui-multiselect-menu"), 'Widget is the menu element');
- el.multiselect("destroy");
- });
-
- test("getButton", function(){
- expect(1);
-
- el = $("select").multiselect();
- var button = el.multiselect("getButton");
- ok( button.is("button.ui-multiselect"), 'Button is the button element');
- el.multiselect("destroy");
- });
-
- test("getMenu", function(){
- expect(1);
- el = $("select").multiselect();
- var menu = el.multiselect("getMenu");
- ok( menu.is(".ui-multiselect-menu"), 'Menu is the menu element');
- el.multiselect("destroy");
- });
-
- test("getLabels", function(){
- expect(1);
- el = $("select").multiselect();
- var labels = el.multiselect("getLabels");
- ok(labels.length === $(".ui-multiselect-menu label").length, 'Returns all the labels');
- el.multiselect("destroy");
- });
-
- test("addOption", function() {
- expect(2);
- el = $("select").clone().appendTo(body).multiselect();
- var attrs = {title: "Test Title", value: "newOption"};
- el.multiselect("addOption", attrs, "Option New");
- ok(el.find("option[value=newOption]").length === 1, "The option is added to the source element");
- ok(menu().find("input[value=newOption]").length === 1, "The option is added to the menu");
- el.multiselect("destroy").remove();
- });
-
- test("removeOption", function() {
- expect(4);
- el = $("select").clone().appendTo(body).multiselect();
- ok(el.find("option[value=1]").length === 1, "The option exists in the source element");
- ok(menu().find("input[value=1]").length === 1, "The option exists in the menu");
- el.multiselect("removeOption", "1");
- ok(el.find("option[value=1]").length === 0, "The option is removed from the source element");
- ok(menu().find("input[value=1]").length === 0, "The option is removed from the menu");
- el.multiselect("destroy").remove();
- });
-
- test("checkAll", function(){
- expect(1);
-
- el = $("select").multiselect().multiselect("checkAll");
- var inputs = menu().find("input");
- ok( inputs.filter(":checked").length === inputs.length, 'All inputs selected on the widget?');
- el.multiselect("destroy");
- });
-
- test("uncheckAll", function(){
- expect(1);
-
- el = $("select").multiselect().multiselect("checkAll").multiselect("uncheckAll");
- ok( menu().find("input:checked").length === 0, 'All inputs unchecked on the widget?');
- el.multiselect("destroy");
- });
-
- test("isOpen", function(){
- expect(2);
-
- el = $("select").multiselect().multiselect("open");
- ok( el.multiselect("isOpen"), 'Testing isOpen method after calling open method');
- el = $("select").multiselect("close");
- ok( !el.multiselect("isOpen"), 'Testing isOpen method after calling close method');
- el.multiselect("destroy");
- });
-
- test("destroy", function(){
- expect(2);
-
- el = $("select").multiselect().multiselect("destroy");
- ok( !$(".ui-multiselect").length , 'button.ui-multiselect removed from the DOM');
- ok( !el.data("multiselect") , 'no more multiselect obj attached to elem');
- });
-
- test("getChecked", function(){
- expect(2);
-
- el = $("select").multiselect().multiselect("checkAll");
- equals( el.multiselect("getChecked").length, 9, 'number of checkboxes returned after checking all and calling getChecked');
- el.multiselect("uncheckAll");
- equals( el.multiselect("getChecked").length, 0, 'number of checkboxes returned after unchecking all and calling getChecked');
- el.multiselect("destroy");
- });
+ module("methods");
+
+ test("open", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("open");
+ ok( el.multiselect("isOpen"), "isOpen parameter true" );
+ equals( menu().css("display"), "block", "Test display CSS property" );
+ el.multiselect("destroy");
+ });
+
+ test("close", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("open").multiselect("close");
+ ok( !el.multiselect("isOpen"), "isOpen parameter false" );
+ equals( menu().css("display"), "none", "Test display CSS property" );
+ el.multiselect("destroy");
+ });
+
+ test("enable", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("disable").multiselect("enable");
+ ok( button().is(":disabled") === false, "Button is enabled" );
+ ok( el.is(":disabled") === false, "Original select is enabled" );
+ el.multiselect("destroy");
+ });
+
+ test("disable", function(){
+ expect(2);
+
+ // clone this one so the original is not affected
+ el = $("select").clone(true).appendTo(body).multiselect().multiselect("disable");
+ ok( button().is(":disabled"), 'Button is disabled');
+ ok( el.is(":disabled"), 'Original select is disabled');
+ el.multiselect("destroy").remove();
+ });
+
+ test("enabling w/ pre-disabled tags (#216)", function(){
+ expect(5);
+
+ el = $('foo bar ')
+ .appendTo(document.body)
+ .multiselect();
+
+ var boxes = menu().find("input");
+ var disabled = boxes.first();
+ var enabled = boxes.last();
+ var key = "ech-multiselect-disabled";
+
+ equals(disabled.is(":disabled"), true, "The first option is disabled");
+ el.multiselect("disable");
+ equals(disabled.attr(key), undefined, "After disabling the widget, the pre-disabled option is not flagged to re-enable");
+ equals(enabled.attr(key), "true", "and the enabled option is flagged to be re-enable");
+ el.multiselect("enable");
+ equals(disabled.is(":disabled"), true, "After enabling, the first option is still disabled");
+ equals(disabled.attr(key), undefined, "and the option no longer has the stored data flag");
+ el.multiselect("destroy").remove();
+ });
+
+ test("widget", function(){
+ expect(1);
+
+ el = $("select").multiselect();
+ ok( menu().is("div.ui-multiselect-menu"), 'Widget is the menu element');
+ el.multiselect("destroy");
+ });
+
+ test("getButton", function(){
+ expect(1);
+
+ el = $("select").multiselect();
+ var button = el.multiselect("getButton");
+ ok( button.is("button.ui-multiselect"), 'Button is the button element');
+ el.multiselect("destroy");
+ });
+
+ test("getMenu", function(){
+ expect(1);
+ el = $("select").multiselect();
+ var menu = el.multiselect("getMenu");
+ ok( menu.is(".ui-multiselect-menu"), 'Menu is the menu element');
+ el.multiselect("destroy");
+ });
+
+ test("getLabels", function(){
+ expect(1);
+ el = $("select").multiselect();
+ var labels = el.multiselect("getLabels");
+ ok(labels.length === $(".ui-multiselect-menu label").length, 'Returns all the labels');
+ el.multiselect("destroy");
+ });
+
+ test("addOption", function() {
+ expect(2);
+ el = $("select").clone().appendTo(body).multiselect();
+ var attrs = {title: "Test Title", value: "newOption"};
+ el.multiselect("addOption", attrs, "Option New");
+ ok(el.find("option[value=newOption]").length === 1, "The option is added to the source element");
+ ok(menu().find("input[value=newOption]").length === 1, "The option is added to the menu");
+ el.multiselect("destroy").remove();
+ });
+
+ test("removeOption", function() {
+ expect(4);
+ el = $("select").clone().appendTo(body).multiselect();
+ ok(el.find("option[value=1]").length === 1, "The option exists in the source element");
+ ok(menu().find("input[value=1]").length === 1, "The option exists in the menu");
+ el.multiselect("removeOption", "1");
+ ok(el.find("option[value=1]").length === 0, "The option is removed from the source element");
+ ok(menu().find("input[value=1]").length === 0, "The option is removed from the menu");
+ el.multiselect("destroy").remove();
+ });
+
+ test("checkAll", function(){
+ expect(1);
+
+ el = $("select").multiselect().multiselect("checkAll");
+ var inputs = menu().find("input");
+ ok( inputs.filter(":checked").length === inputs.length, 'All inputs selected on the widget?');
+ el.multiselect("destroy");
+ });
+
+ test("uncheckAll", function(){
+ expect(1);
+
+ el = $("select").multiselect().multiselect("checkAll").multiselect("uncheckAll");
+ ok( menu().find("input:checked").length === 0, 'All inputs unchecked on the widget?');
+ el.multiselect("destroy");
+ });
+
+ test("isOpen", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("open");
+ ok( el.multiselect("isOpen"), 'Testing isOpen method after calling open method');
+ el = $("select").multiselect("close");
+ ok( !el.multiselect("isOpen"), 'Testing isOpen method after calling close method');
+ el.multiselect("destroy");
+ });
+
+ test("destroy", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("destroy");
+ ok( !$(".ui-multiselect").length , 'button.ui-multiselect removed from the DOM');
+ ok( !el.data("multiselect") , 'no more multiselect obj attached to elem');
+ });
+
+ test("getChecked", function(){
+ expect(2);
+
+ el = $("select").multiselect().multiselect("checkAll");
+ equals( el.multiselect("getChecked").length, 9, 'number of checkboxes returned after checking all and calling getChecked');
+ el.multiselect("uncheckAll");
+ equals( el.multiselect("getChecked").length, 0, 'number of checkboxes returned after unchecking all and calling getChecked');
+ el.multiselect("destroy");
+ });
test("getUnchecked", function(){
- expect(2);
-
- el = $("select").multiselect().multiselect("checkAll");
- equals( el.multiselect("getUnchecked").length, 0, 'number of checkboxes returned after checking all and calling getUnchecked');
- el.multiselect("uncheckAll");
- equals( el.multiselect("getUnchecked").length, 9, 'number of checkboxes returned after unchecking all and calling getUnchecked');
- el.multiselect("destroy");
- });
-
- test("refresh", function(){
- expect(6);
-
- el = $("select").clone().appendTo(body).multiselect();
- el.empty().html('foo bar ');
- el.multiselect('refresh');
-
- var checkboxes, getCheckboxes = (function hai(){
- checkboxes = menu().find('input[type="checkbox"]');
- return hai;
- })();
-
- equals( checkboxes.length, 2, "After clearing the select, adding 2 options, and refresh(), only 2 checkboxes exist");
- equals( checkboxes.eq(0).val(), 'foo', 'first is foo' );
- equals( checkboxes.eq(1).val(), 'bar', 'second is bar' );
-
- // add one more w/ append, just for safety's sake
- el.append('baz ');
- el.multiselect('refresh');
- getCheckboxes();
- equals( checkboxes.eq(2).val(), 'baz', 'after an append() call, the third option is now baz' );
- equals($(el.multiselect("instance").inputs[0]).data().testval, 123, "the first input has the data attribute testval with value 123");
- equals($(el.multiselect("instance").inputs[2]).data().testval, "something", "the third input has the data attribute testval with value something");
-
- el.multiselect("destroy").remove();
- });
-
- test("position", function() {
+ expect(2);
+
+ el = $("select").multiselect().multiselect("checkAll");
+ equals( el.multiselect("getUnchecked").length, 0, 'number of checkboxes returned after checking all and calling getUnchecked');
+ el.multiselect("uncheckAll");
+ equals( el.multiselect("getUnchecked").length, 9, 'number of checkboxes returned after unchecking all and calling getUnchecked');
+ el.multiselect("destroy");
+ });
+
+ test("refresh", function(){
+ expect(6);
+
+ el = $("select").clone().appendTo(body).multiselect();
+ el.empty().html('foo bar ');
+ el.multiselect('refresh');
+
+ var checkboxes, getCheckboxes = (function hai(){
+ checkboxes = menu().find('input[type="checkbox"]');
+ return hai;
+ })();
+
+ equals( checkboxes.length, 2, "After clearing the select, adding 2 options, and refresh(), only 2 checkboxes exist");
+ equals( checkboxes.eq(0).val(), 'foo', 'first is foo' );
+ equals( checkboxes.eq(1).val(), 'bar', 'second is bar' );
+
+ // add one more w/ append, just for safety's sake
+ el.append('baz ');
+ el.multiselect('refresh');
+ getCheckboxes();
+ equals( checkboxes.eq(2).val(), 'baz', 'after an append() call, the third option is now baz' );
+ equals($(el.multiselect("instance").$inputs[0]).data().testval, 123, "the first input has the data attribute testval with value 123");
+ equals($(el.multiselect("instance").$inputs[2]).data().testval, "something", "the third input has the data attribute testval with value something");
+
+ el.multiselect("destroy").remove();
+ });
+
+ test("position", function() {
expect(2);
var left = "500px";
@@ -216,6 +216,6 @@
equals(menu().css("left"), left, "After calling position(), the menu has updated to the same left value as the button");
el.multiselect("destroy").remove();
- });
+ });
})(jQuery);
From 730198a6961b76f5d539b85ee866b34910ac7748 Mon Sep 17 00:00:00 2001
From: Steve James <4stevejames@gmail.com>
Date: Sat, 13 Jan 2018 14:37:33 -0800
Subject: [PATCH 05/12] Fix comment alignment
---
src/jquery.multiselect.js | 58 +++++++++++++++++++--------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/src/jquery.multiselect.js b/src/jquery.multiselect.js
index ddaeaf7..4f4517d 100644
--- a/src/jquery.multiselect.js
+++ b/src/jquery.multiselect.js
@@ -4,7 +4,7 @@
* Copyright (c) 2012 Eric Hynds
*
* Depends:
- * - jQuery 1.7+ (http://api.jquery.com/)
+ * - jQuery 1.7+ (http://api.jquery.com/)
* - jQuery UI 1.11 widget factory (http://api.jqueryui.com/jQuery.widget/)
*
* Optional:
@@ -25,48 +25,48 @@
// default options
options: {
- header: true, // (true | false) If true, the header is shown.
- height: 175, // (int) Sets the height of the menu.
- minWidth: 225, // (int) Sets the minimum width of the menu.
- classes: '', // Classes that you can provide to be applied to the elements making up the widget.
+ header: true, // (true | false) If true, the header is shown.
+ height: 175, // (int) Sets the height of the menu.
+ minWidth: 225, // (int) Sets the minimum width of the menu.
+ classes: '', // Classes that you can provide to be applied to the elements making up the widget.
openIcon: '' + o.openIcon + ' LIMIT OF " + (numChecked - 1) + " REACHED! foo "with quotes" bar baz foo "with quotes" bar baz foo bar baz foo "with quotes" bar baz foo bar baz A&E A&E foo foo