[Backport] Fix docBlock for hasInvoices(), hasShipments(), hasCreditmemos() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able Qty Increments' filed in product import
[Backport] magento#16079 translation possibility for moreButtonText
Add missing showInStore attributes on Braintree configuration as there are some values that are changeable on store view (Title, Descriptors, merchant name override) and are not accessible from store view level.
…tes magento#16550 - Merge Pull Request magento#16550 from e-conomix/magento2:2.1-braintree-backport - Merged commits: 1. 6d79c64
…agento#16735 - Merge Pull Request magento#16735 from Karlasa/magento2:BP-PR-16559 - Merged commits: 1. 818519e 2. c11e329 3. 59a9f32
- Merge Pull Request magento#16731 from gelanivishal/magento2:2.1-develop-PR-port-16524 - Merged commits: 1. 71a3340
…n the js-translations.json magento#16720 - Merge Pull Request magento#16720 from sanganinamrata/magento2:2.1-develop-PR-port-13528 - Merged commits: 1. aa0e051
…n the js-translations.json magento#16720
…e \`Enable Qty Increments\` field magento#14380 - Merge Pull Request magento#14380 from simpleadm/magento2:backport/2.1-fix-product-import-enable-qty-inc - Merged commits: 1. ead41d9 2. 053fea2
…t page] magento#16526 - Merge Pull Request magento#16526 from hitesh-wagento/magento2:2.1-wrong-password-checkout - Merged commits: 1. 86ed9df 2. b5902e9
Accepted Public Pull Requests: - magento#16720: [Backport] Fix for magento#12081: missing translations in the js-translations.json (by @sanganinamrata) - magento#16731: [Backport] Removed extra code (by @gelanivishal) - magento#16735: [backport] magento#16559 fix icon color variable naming (by @Karlasa) Fixed GitHub Issues: - magento#12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. (reported by @jhruehl) has been fixed in magento#16720 by @sanganinamrata in 2.1-develop branch Related commits: 1. aa0e051
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759 - Merge Pull Request magento#16759 from mageprince/magento2:2.1-develop-PR-port-16699 - Merged commits: 1. 9f06c5f 2. d6e647d
… in Magento_Sales and Magento_Paypal magento#16760 - Merge Pull Request magento#16760 from mageprince/magento2:2.1-develop-PR-port-16698 - Merged commits: 1. db30595
… in Magento_Sales and Magento_Paypal magento#16760
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759
eduard13
pushed a commit
that referenced
this pull request
Oct 26, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
eduard13
pushed a commit
that referenced
this pull request
Nov 7, 2018
Remove unnecesary "header" block redeclaration
eduard13
pushed a commit
that referenced
this pull request
Jan 23, 2019
Missing setTotalCount on $searchResults object in getList method
eduard13
pushed a commit
that referenced
this pull request
Jan 30, 2019
removes extra dot on "How to run Magento" in phpserve/README.md
eduard13
pushed a commit
that referenced
this pull request
Feb 20, 2019
Add Brazilian Credit Cards Support #1
eduard13
pushed a commit
that referenced
this pull request
Feb 20, 2019
nmalevanec
pushed a commit
that referenced
this pull request
Feb 26, 2019
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
eduard13
pushed a commit
that referenced
this pull request
Oct 2, 2019
eduard13
pushed a commit
that referenced
this pull request
Oct 9, 2019
eduard13
pushed a commit
that referenced
this pull request
Oct 23, 2019
Issue #1: Static content deploy waits 3 sec in single-job mode after finish Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... } Issue magento#2: Static content deploy has 5 secs delay between checking if worker job finished processing. It leads up to 5 sec time waste before next job will start. Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec) On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
eduard13
pushed a commit
that referenced
this pull request
Oct 30, 2019
…ription-input-box-fix Fix label being cutoff in Newsletter registration
eduard13
pushed a commit
that referenced
this pull request
Nov 22, 2019
…rrors Filter error array by unique values
eduard13
pushed a commit
that referenced
this pull request
Nov 22, 2019
update forked repository 2.3 branch
eduard13
pushed a commit
that referenced
this pull request
Mar 31, 2021
eduard13
pushed a commit
that referenced
this pull request
Oct 14, 2021
…rateCustomerToken Fixed the not expiry of token in generateCustomerToken graphql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
Description
Small improvements of docBlock for app/code/Magento/Sales/Model/Order.php docBlock description.
hasInvoices(), hasShipments(), hasCreditmemos() returns int and not bool
Manual testing scenarios
No testing scenarios, just docBlock changed
Contribution checklist