From 13588ddf89750f430214e36ad2a9ccf1b0e6ab73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Fri, 30 Sep 2022 12:44:08 +0200 Subject: [PATCH] fix DetailedProgressViewer.remove() fixes #342 #370 If the job is not (yet) drawn it should still be logically removed. found by ProgressContantsTest.testKeepOneProperty() --- .../ui/internal/progress/DetailedProgressViewer.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java index da91c77721a..53a1a8b205a 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java @@ -394,14 +394,12 @@ public void remove(JobTreeElement... elements) { if (parent != null && parent != element) remove(parent); } - if (item != null) { - items.remove(element); - unmapElement(element); - } + items.remove(element); + unmapElement(element); } } // also sort again, otherwise removed job may appear at top again: - updateItems(items); + updateItems(items); } @Override