Issue #301 - wrong transparency when drawing image (regression from PR #224) #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-meier
requested review from
iloveeclipse and
niraj-modi
as code owners
jonathan-meier
changed the title
jonathan-meier
force-pushed
the
issue301
branch
from
0cb4c14 to
636f560
Compare
Contributor
…ata.data for icons Fixes the regression introduced in PR eclipse-platform#244 (commit 8def011) which also allowed alpha data in ImageData.data for bitmaps. Alpha data for bitmaps must be provided in ImageData.alphaData. This ensures proper conversion of the image data to pre-multiplied alpha format and aligns the behavior of Image initialization with the implementation for Linux.
… are always opaque DDBs can have a 32 bit depth but the returned alpha channel data is always 0 which means fully transparent. Since we want to avoid a costly blit operation from 32 to 24 bits, stripping the alpha channel data, we set the alpha channel data to 255 for better compatibility. Note that alpha channel data in ImageData.data should always be ignored anyway and be read from ImageData.alphaData instead.
jonathan-meier
force-pushed
the
issue301
branch
from
636f560 to
dde8a36
Compare
Contributor
|
@SyntevoAlex can you reiview and merge this one? |
Member
|
I could have a look, hopefully today or tomorrow. |
niraj-modi
approved these changes
Aug 11, 2022
Member
niraj-modi
left a comment
niraj-modi
left a comment
There was a problem hiding this comment.
This patch works as expected, tested with below snippet:
#301 (comment)
Contributor
|
Thanks, everyone! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301.