Add tests for all DND transfer types

The individual Transfer types had no automatic testing, so this commit
provides tests for all the transfer types and ensures copy/paste
to external to SWT works too by implementing flavors for all types
in the Swing remote clipboard test app.

Part of #2126

Author: jonahgraham

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/graphics/ImageDataTestHelper.java

@@ -15,6 +15,9 @@
 package org.eclipse.swt.tests.graphics;
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
@@ -226,4 +229,35 @@ public static void assertImageDataEqual(ImageData source, ImageData actual, Imag
 
 		assertArrayEquals(actual.data, expected.data);
 	}
+
+	/**
+	 * Compares ImageData, allows for change in things like bit depth by comparing pixel values rather
+	 */
+	public static void assertImageDataEqualPixelValues(ImageData expected, ImageData actual) {
+		if (expected == null) {
+			assertNull(actual);
+		}
+
+		if (TEST_BLIT_SHOW_IMAGES) {
+			Image[] images = new Image[2];
+			images[0] = new Image(Display.getCurrent(), expected);
+			images[1] = new Image(Display.getCurrent(), actual);
+			SwtTestUtil.debugDisplayImages(images, 2);
+			images[0].dispose();
+			images[1].dispose();
+		}
+
+		assertEquals(expected.width, actual.width);
+		assertEquals(expected.height, actual.height);
+		if (expected.getRGBs() != null || actual.getRGBs() != null) {
+			fail("We don't have code yet for comparing palettized image datas");
+		}
+		for (int x = 0; x < expected.width; x++) {
+			for (int y = 0; y < expected.width; y++) {
+				assertEquals(expected.getPixel(x, y), actual.getPixel(x, y));
+				assertEquals(expected.getAlpha(x, y), actual.getAlpha(x, y));
+			}
+		}
+		assertEquals(expected.transparentPixel, actual.transparentPixel);
+	}
 }

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/AllNonBrowserTests.java

@@ -43,7 +43,14 @@
 		Test_org_eclipse_swt_accessibility_AccessibleControlEvent.class, //
 		Test_org_eclipse_swt_accessibility_AccessibleEvent.class, //
 		Test_org_eclipse_swt_accessibility_AccessibleTextEvent.class, //
-		Test_org_eclipse_swt_dnd_Clipboard.class,
+		Test_org_eclipse_swt_dnd_ByteArrayTransfer.class, //
+		Test_org_eclipse_swt_dnd_Clipboard.class, //
+		Test_org_eclipse_swt_dnd_FileTransfer.class, //
+		Test_org_eclipse_swt_dnd_HTMLTransfer.class, //
+		Test_org_eclipse_swt_dnd_ImageTransfer.class, //
+		Test_org_eclipse_swt_dnd_RTFTransfer.class, //
+		Test_org_eclipse_swt_dnd_TextTransfer.class, //
+		Test_org_eclipse_swt_dnd_URLTransfer.class, //
 		Test_org_eclipse_swt_events_ArmEvent.class, //
 		Test_org_eclipse_swt_events_ControlEvent.class, //
 		Test_org_eclipse_swt_events_DisposeEvent.class, //

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/RemoteClipboard.java

@@ -55,7 +55,13 @@ public void start() throws Exception {
 				"ClipboardTest", //
 				"ClipboardCommands", //
 				"ClipboardCommandsImpl", //
-				"ClipboardTest$LocalHostOnlySocketFactory" //
+				"ClipboardTest$FileListSelection", //
+				"ClipboardTest$HtmlSelection", //
+				"ClipboardTest$ImageSelection", //
+				"ClipboardTest$LocalHostOnlySocketFactory", //
+				"ClipboardTest$MyTypeSelection", //
+				"ClipboardTest$RtfSelection", //
+				"ClipboardTest$UrlSelection" //
 		).forEach((f) -> {
 			// extract the files and put them in the temp directory
 			SwtTestUtil.copyFile("/clipboard/" + f + ".class",
@@ -85,6 +91,7 @@ public void start() throws Exception {
 			throw new RuntimeException("Failed to get port");
 		});
 		assertNotEquals(0, port);
+
 		try {
 			Registry reg = LocateRegistry.getRegistry("127.0.0.1", port);
 			long stopTime = System.currentTimeMillis() + 10000;
@@ -186,6 +193,11 @@ public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOEx
 		}
 	}
 
+	@Override
+	public void setContents(String string) throws RemoteException {
+		setContents(string, CLIPBOARD);
+	}
+
 	@Override
 	public void setContents(String string, int clipboardId) throws RemoteException {
 		remote.setContents(string, clipboardId);
@@ -196,6 +208,11 @@ public void setFocus() throws RemoteException {
 		remote.setFocus();
 	}
 
+	@Override
+	public String getStringContents() throws RemoteException {
+		return getStringContents(CLIPBOARD);
+	}
+
 	@Override
 	public String getStringContents(int clipboardId) throws RemoteException {
 		return remote.getStringContents(clipboardId);
@@ -207,7 +224,68 @@ public void waitUntilReady() throws RemoteException {
 	}
 
 	@Override
-	public void waitForButtonPress()  throws RemoteException {
+	public void waitForButtonPress() throws RemoteException {
 		remote.waitForButtonPress();
 	}
+
+	@Override
+	public void setRtfContents(String test) throws RemoteException {
+		remote.setRtfContents(test);
+	}
+
+	@Override
+	public String getRtfContents() throws RemoteException {
+		return remote.getRtfContents();
+	}
+
+	@Override
+	public void setHtmlContents(String test) throws RemoteException {
+		remote.setHtmlContents(test);
+	}
+
+	@Override
+	public String getHtmlContents() throws RemoteException {
+		return remote.getHtmlContents();
+	}
+
+	@Override
+	public void setUrlContents(byte[] test) throws RemoteException {
+		remote.setUrlContents(test);
+	}
+
+	@Override
+	public byte[] getUrlContents() throws RemoteException {
+		return remote.getUrlContents();
+	}
+
+	@Override
+	public void setImageContents(byte[] imageContents) throws RemoteException {
+		remote.setImageContents(imageContents);
+	}
+
+	@Override
+	public byte[] getImageContents() throws RemoteException {
+		return remote.getImageContents();
+	}
+
+	@Override
+	public void setFileListContents(String[] fileList) throws RemoteException {
+		remote.setFileListContents(fileList);
+	}
+
+	@Override
+	public String[] getFileListContents() throws RemoteException {
+		return remote.getFileListContents();
+	}
+
+	@Override
+	public void setMyTypeContents(byte[] bytes) throws RemoteException {
+		remote.setMyTypeContents(bytes);
+	}
+
+	@Override
+	public byte[] getMyTypeContents() throws RemoteException {
+		return remote.getMyTypeContents();
+	}
+
 }