Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Oct 17, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175160?focus=true

Description

Adds ad clicks attributed metric as per specs in https://app.asana.com/1/137249556945/project/1206716555947156/task/1211301604929610?focus=true

Steps to test this PR

While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"

Feature 1

  • We need fresh install (including removing DDG folder in file system)
  • Open the app
  • wait until "skip onboarding" appears
  • After downloading privacy config and atb init, you should see Client status running: true -> isActive: true, isEnabled: true
  • Skip onboarding, and go to the browser
  • Perform search like "hotels in vietnam"
  • click the first ad
  • Ensure in logs Collected event ad_click
  • Go to settings -> Attributed Metrics Dev Settings
  • Click on "Add Ad clicks Events" so we add some test data
  • Update installation date with 2d ago (and click save)
  • Close the app, open it again (or fire button)
  • Perform search like "restaurants in vietnam"
  • Click first ad
  • Ensure Fired pixel user_average_ad_clicks_past_week

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

cmonfortep commented Oct 17, 2025

@cmonfortep cmonfortep force-pushed the feature/cristian/ad_attributed_metrics branch from bd049c1 to b0586cd Compare October 17, 2025 16:46
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonfortep cmonfortep force-pushed the feature/cristian/retention_attributed_metric branch from 7c10354 to 8763abc Compare October 24, 2025 08:22
@cmonfortep cmonfortep force-pushed the feature/cristian/ad_attributed_metrics branch from b0586cd to d5957c1 Compare October 24, 2025 08:22
@cmonfortep cmonfortep force-pushed the feature/cristian/retention_attributed_metric branch from 8763abc to 8f0cbda Compare October 29, 2025 16:30
@cmonfortep cmonfortep force-pushed the feature/cristian/ad_attributed_metrics branch from d5957c1 to f88ee1d Compare October 29, 2025 16:30
@cmonfortep cmonfortep force-pushed the feature/cristian/retention_attributed_metric branch from 8f0cbda to 7c167da Compare October 31, 2025 11:56
@cmonfortep cmonfortep force-pushed the feature/cristian/ad_attributed_metrics branch from f88ee1d to 6633627 Compare October 31, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants