From 73b0bdc196d9dc04be8694eed7fdc145b9c51b45 Mon Sep 17 00:00:00 2001 From: Sam Ansmink Date: Mon, 19 May 2025 18:13:27 +0200 Subject: [PATCH] set secret type extension --- extension/httpfs/create_secret_functions.cpp | 2 ++ test/sql/secret/test_secret_type.test | 17 +++++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 test/sql/secret/test_secret_type.test diff --git a/extension/httpfs/create_secret_functions.cpp b/extension/httpfs/create_secret_functions.cpp index 7929cdb4..b3984b33 100644 --- a/extension/httpfs/create_secret_functions.cpp +++ b/extension/httpfs/create_secret_functions.cpp @@ -211,6 +211,7 @@ void CreateS3SecretFunctions::RegisterCreateSecretFunction(DatabaseInstance &ins secret_type.name = type; secret_type.deserializer = KeyValueSecret::Deserialize; secret_type.default_provider = "config"; + secret_type.extension = "httpfs"; ExtensionUtil::RegisterSecretType(instance, secret_type); @@ -225,6 +226,7 @@ void CreateBearerTokenFunctions::Register(DatabaseInstance &instance) { secret_type_hf.name = HUGGINGFACE_TYPE; secret_type_hf.deserializer = KeyValueSecret::Deserialize; secret_type_hf.default_provider = "config"; + secret_type_hf.extension = "httpfs"; ExtensionUtil::RegisterSecretType(instance, secret_type_hf); // Huggingface config provider diff --git a/test/sql/secret/test_secret_type.test b/test/sql/secret/test_secret_type.test new file mode 100644 index 00000000..231c5180 --- /dev/null +++ b/test/sql/secret/test_secret_type.test @@ -0,0 +1,17 @@ +# name: test/sql/secret/test_secret_type.test +# description: Test the secret types added by this extension +# group: [httpfs] + +require httpfs + +statement ok +PRAGMA enable_verification + +query II +SELECT type, default_provider from duckdb_secret_types() where extension='httpfs' order by type; +---- +aws config +gcs config +huggingface config +r2 config +s3 config \ No newline at end of file