From 3387b0bf1f206eae471a500f8d9d05d0d3e7b190 Mon Sep 17 00:00:00 2001 From: Nicolas Renkamp Date: Thu, 18 Sep 2025 20:39:13 +0000 Subject: [PATCH 1/2] Pass profile into DefaultAWSCredentialsProviderChain and use it instead of ProfileConfigFileAWSCredentialsProvider --- src/aws_extension.cpp | 4 +++- src/aws_secret.cpp | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/aws_extension.cpp b/src/aws_extension.cpp index 08c2e69..2e6d6b3 100644 --- a/src/aws_extension.cpp +++ b/src/aws_extension.cpp @@ -19,7 +19,9 @@ static AwsSetCredentialsResult TrySetAwsCredentials(DBConfig &config, const stri if (!profile.empty()) { // The user has specified a specific profile they want to use instead of the current profile specified by the // system - Aws::Auth::ProfileConfigFileAWSCredentialsProvider provider(profile.c_str()); + Aws::Client::ClientConfiguration::CredentialProviderConfiguration config; + config.profile = profile.c_str() + Aws::Auth::DefaultAWSCredentialsProviderChain provider(config); credentials = provider.GetAWSCredentials(); } else { Aws::Auth::DefaultAWSCredentialsProviderChain provider; diff --git a/src/aws_secret.cpp b/src/aws_secret.cpp index 80fd601..82e962f 100644 --- a/src/aws_secret.cpp +++ b/src/aws_secret.cpp @@ -220,7 +220,9 @@ static unique_ptr CreateAWSSecretFromCredentialChain(ClientContext & credentials = provider.GetAWSCredentials(); } else { if (input.options.find("profile") != input.options.end()) { - Aws::Auth::ProfileConfigFileAWSCredentialsProvider provider(profile.c_str()); + Aws::Client::ClientConfiguration::CredentialProviderConfiguration config; + config.profile = profile.c_str() + Aws::Auth::DefaultAWSCredentialsProviderChain provider(config); credentials = provider.GetAWSCredentials(); } else { Aws::Auth::DefaultAWSCredentialsProviderChain provider; From 1c442b8105ce609dc973d79afbb002e6ebcee34c Mon Sep 17 00:00:00 2001 From: Nicolas Renkamp Date: Tue, 30 Sep 2025 09:32:16 +0200 Subject: [PATCH 2/2] triggger CI --- src/aws_extension.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/aws_extension.cpp b/src/aws_extension.cpp index 2e6d6b3..0fb8daa 100644 --- a/src/aws_extension.cpp +++ b/src/aws_extension.cpp @@ -31,7 +31,7 @@ static AwsSetCredentialsResult TrySetAwsCredentials(DBConfig &config, const stri auto s3_config = Aws::Client::ClientConfiguration(profile.c_str()); auto region = s3_config.region; - // TODO: We would also like to get the endpoint here, but it's currently not supported by the AWS SDK: + // TODO: We would also like to get the endpoint here, but it's currently not supported by the AWS Sdk: // https://github.com/aws/aws-sdk-cpp/issues/2587 AwsSetCredentialsResult ret; @@ -156,4 +156,4 @@ DUCKDB_CPP_EXTENSION_ENTRY(aws, loader) { duckdb::LoadInternal(loader); } -} \ No newline at end of file +}