Skip to content

Commit 074853a

Browse files
committed
Suggest resolving conflicts by adding new commits vs amending the merge commit
This gives us slightly messier git history, but more importantly makes reviewing substantially easier.
1 parent 5b5ed44 commit 074853a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/update-release-branch.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,11 @@ def open_pr(
8585
body.append('')
8686
body.append('Please review the following:')
8787
if len(conflicted_files) > 0:
88-
body.append(' - [ ] You have amended the merge commit appearing in this branch to resolve ' +
89-
'the merge conflicts in the following files:')
88+
body.append(' - [ ] You have added commits to this branch that resolve the merge conflicts ' +
89+
'in the following files:')
9090
body.extend([f' - [ ] `{file}`' for file in conflicted_files])
91+
body.append(' - [ ] Another maintainer has reviewed the additional commits you added to this ' +
92+
'branch to resolve the merge conflicts.')
9193
body.append(' - [ ] The CHANGELOG displays the correct version and date.')
9294
body.append(' - [ ] The CHANGELOG includes all relevant, user-facing changes since the last release.')
9395
body.append(' - [ ] There are no unexpected commits being merged into the ' + target_branch + ' branch.')

0 commit comments

Comments
 (0)