Update Pattern Lab PHP Core Minimum PHP Version to 7.0+ #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…concise ways to write out common PHP logic (ex. the Null coalescing operator - https://stackoverflow.com/a/36796941) in addition to performance gains PHP 7 introduced. Given that PHP 7.0 first came out nearly 2 years ago (December 3rd, 2015) I think it's about time we took the plunge...
|
One thing to consider is that macOS Sierra (the current OS) comes with PHP 5.6 - so basically we're saying that every person who uses PL on their machine will need to update PHP. I'm not against this, but it's something we should consider and acknowledge early. |
Collaborator
Author
|
Closing this last PR out. Might end up revisiting this on the main Pattern Lab repo down the road but tabling this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the minimum PHP dependency in Pattern Lab PHP Core to PHP 7.0 to open the door for more concise ways to write out common PHP logic (ex. the Null coalescing operator - https://stackoverflow.com/a/36796941) in addition to the performance gains PHP 7 introduced.
Given that PHP 7.0 first came out nearly 2 years ago (December 3rd, 2015) I think it's about time we took the plunge...
Perhaps we could use this as a base for a major Pattern Lab PHP Core v3.0.0 release?